Changeset 190819 in webkit
- Timestamp:
- Oct 9, 2015 2:34:56 PM (9 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r190805 r190819 1 2015-10-09 Simon Fraser <simon.fraser@apple.com> 2 3 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext 4 https://bugs.webkit.org/show_bug.cgi?id=149960 5 6 Reviewed by Tim Horton. 7 8 Use adoptWK(), and null out some members (file is not using ARC). 9 10 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: 11 (UIScriptContext::uiScriptComplete): 12 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: 13 (-[TestRunnerWKWebView dealloc]): 14 1 15 2015-10-09 Csaba Osztrogonác <ossy@webkit.org> 2 16 -
trunk/Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp
r190368 r190819 139 139 void UIScriptContext::uiScriptComplete(JSStringRef result) 140 140 { 141 WKRetainPtr<WKStringRef> uiScriptResult = WKStringCreateWithJSString(result);141 WKRetainPtr<WKStringRef> uiScriptResult = adoptWK(WKStringCreateWithJSString(result)); 142 142 m_delegate.uiScriptDidComplete(uiScriptResult.get(), m_currentScriptCallbackID); 143 143 m_currentScriptCallbackID = 0; -
trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm
r190517 r190819 71 71 - (void)dealloc 72 72 { 73 [[NSNotificationCenter defaultCenter] removeObserver:self]; 74 75 self.willBeginZoomingCallback = nil; 76 self.didEndZoomingCallback = nil; 77 self.didShowKeyboardCallback = nil; 78 self.didHideKeyboardCallback = nil; 79 80 self.zoomToScaleCompletionHandler = nil; 81 self.showKeyboardCompletionHandler = nil; 82 73 83 [super dealloc]; 74 [[NSNotificationCenter defaultCenter] removeObserver:self];75 84 } 76 85
Note: See TracChangeset
for help on using the changeset viewer.