Changeset 190917 in webkit

Timestamp:

Oct 12, 2015 7:10:08 PM (9 years ago)

Author:

jonlee@apple.com

Message:

Add canvas path fill tests
​https://bugs.webkit.org/show_bug.cgi?id=150071
<rdar://problem/23082001>

Reviewed by Dean Jackson.

• Animometer/runner/resources/tests.js: Add new pathTypes for path fills.
• Animometer/tests/simple/resources/simple-canvas-paths.js:

(CanvasLinePoint): Add basic point for a line, and call lineTo.
(SimpleCanvasPathFillStage): Add a new stage similar to SimpleCanvasPathStrokeStage.
(CanvasPathBenchmark.prototype.createStage): Add the tests.

Location:

trunk/PerformanceTests

Files:

• Animometer/runner/resources/tests.js (modified) (1 diff)
• Animometer/tests/simple/resources/simple-canvas-paths.js (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/PerformanceTests/Animometer/runner/resources/tests.js

@@ -168 +168 @@
         },
         {
+            url: "simple/simple-canvas-paths.html?pathType=lineFill",
+            name: "Canvas line path, fill"
+        },
+        {
+            url: "simple/simple-canvas-paths.html?pathType=quadraticFill",
+            name: "Canvas quadratic path, fill"
+        },
+        {
+            url: "simple/simple-canvas-paths.html?pathType=bezierFill",
+            name: "Canvas bezier path, fill"
+        },
+        {
             url: "simple/simple-canvas-paths.html?&pathType=arcToFill",
             name: "Canvas arcTo segments, fill"

trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js

@@ -1 +1 @@
 // === PAINT OBJECTS ===
+
+function CanvasLinePoint(stage, coordinateMaximum) {
+    this._point = stage.randomPosition(new Point(Math.min(stage.size.x, coordinateMaximum), Math.min(stage.size.y, coordinateMaximum)));
+}
+CanvasLinePoint.prototype.draw = function(context) {
+    context.lineTo(this._point.x, this._point.y);
+};
 
 function CanvasQuadraticSegment(stage) {
@@ -141 +148 @@
     });
     context.stroke();
+}
+
+function SimpleCanvasPathFillStage(element, options, canvasObject) {
+    SimpleCanvasStage.call(this, element, options, canvasObject);
+}
+SimpleCanvasPathFillStage.prototype = Object.create(SimpleCanvasStage.prototype);
+SimpleCanvasPathFillStage.prototype.constructor = SimpleCanvasPathFillStage;
+SimpleCanvasPathFillStage.prototype.animate = function() {
+    var context = this.context;
+    context.fillStyle = this.randomColor();
+    context.beginPath();
+    context.moveTo(0,0);
+    this._objects.forEach(function(object) {
+        object.draw(context);
+    });
+    context.fill();
 }
 
@@ -167 +190 @@
     case "rect":
         return new SimpleCanvasStage(element, this._options, CanvasRect);
+    case "lineFill":
+        return new SimpleCanvasPathFillStage(element, this._options, CanvasLinePoint);
+    case "quadraticFill":
+        return new SimpleCanvasPathFillStage(element, this._options, CanvasQuadraticPoint);
+    case "bezierFill":
+        return new SimpleCanvasPathFillStage(element, this._options, CanvasBezierPoint);
     case "arcToFill":
         return new SimpleCanvasStage(element, this._options, CanvasArcToSegmentFill);

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2015-10-12  Jon Lee  <jonlee@apple.com>
+
+        Add canvas path fill tests
+        https://bugs.webkit.org/show_bug.cgi?id=150071
+        <rdar://problem/23082001>
+
+        Reviewed by Dean Jackson.
+
+        * Animometer/runner/resources/tests.js: Add new pathTypes for path fills.
+        * Animometer/tests/simple/resources/simple-canvas-paths.js:
+        (CanvasLinePoint): Add basic point for a line, and call lineTo.
+        (SimpleCanvasPathFillStage): Add a new stage similar to SimpleCanvasPathStrokeStage.
+        (CanvasPathBenchmark.prototype.createStage): Add the tests.
+
 2015-10-12  Jon Lee  <jonlee@apple.com>