Changeset 190922 in webkit

Timestamp:

Oct 12, 2015 7:49:33 PM (9 years ago)

Author:

ap@apple.com

Message:

Add a Mac debug EWS queue
​https://bugs.webkit.org/show_bug.cgi?id=150069

Reviewed by Geoffrey Garen.

• QueueStatusServer/config/queues.py:
• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.archive_last_test_results):
(AbstractEarlyWarningSystem.build_style):
(AbstractEarlyWarningSystem.refetch_patch):
(AbstractEarlyWarningSystem.load_ews_classes):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/config/queues.py (modified) (1 diff)
• Scripts/webkitpy/common/config/ews.json (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-10-12  Alexey Proskuryakov  <ap@apple.com>
+
+        Add a Mac debug EWS queue
+        https://bugs.webkit.org/show_bug.cgi?id=150069
+
+        Reviewed by Geoffrey Garen.
+
+        * QueueStatusServer/config/queues.py:
+        * Scripts/webkitpy/common/config/ews.json:
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        (AbstractEarlyWarningSystem):
+        (AbstractEarlyWarningSystem.archive_last_test_results):
+        (AbstractEarlyWarningSystem.build_style):
+        (AbstractEarlyWarningSystem.refetch_patch):
+        (AbstractEarlyWarningSystem.load_ews_classes):
+
 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 

trunk/Tools/QueueStatusServer/config/queues.py

@@ -38 +38 @@
     "mac-ews",
     "mac-wk2-ews",
+    "mac-debug-32bit-ews",
     "win-ews",
     "efl-wk2-ews",

trunk/Tools/Scripts/webkitpy/common/config/ews.json

@@ -35 +35 @@
         ],
         "runTests": true
+    },
+    "Mac Debug 32-bit WK2 EWS": {
+        "port": "mac",
+        "name": "mac-debug-32bit-ews",
+        "style": "debug",
+        "architecture": "i386",
     }
 }

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@ -45 +45 @@
 
 class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDelegate):
-    _build_style = "release"
     # FIXME: Switch _default_run_tests from opt-in to opt-out once more bots are ready to run tests.
     run_tests = False
@@ -125 +124 @@
 
     def build_style(self):
-        return self._build_style
+        return self.build_style
 
     def refetch_patch(self, patch):
@@ -151 +150 @@
         classes = []
         for name, config in ewses.iteritems():
-            classes.append(type(str(name.replace(' ', '')), (AbstractEarlyWarningSystem,), {
-                'name': config['port'] + '-ews',
+            classes.append(type(str(name).translate(None, ' -'), (AbstractEarlyWarningSystem,), {
+                'name': config.get('name', config['port'] + '-ews'),
                 'port_name': config['port'],
                 'architecture': config.get('architecture', None),
+                'build_style': config.get('style', "release"),
                 'watchers': config.get('watchers', []),
                 'run_tests': config.get('runTests', cls.run_tests),