Changeset 192496 in webkit


Ignore:
Timestamp:
Nov 16, 2015 4:26:57 PM (8 years ago)
Author:
ryuan.choi@navercorp.com
Message:

WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
https://bugs.webkit.org/show_bug.cgi?id=151248

Reviewed by Darin Adler.

Like r188287, calling an empty std::function results in a std::bad_function_call
exception being thrown when sendSync is failed.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r192486 r192496  
     12015-11-16  Ryuan Choi  <ryuan.choi@navercorp.com>
     2
     3        WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
     4        https://bugs.webkit.org/show_bug.cgi?id=151248
     5
     6        Reviewed by Darin Adler.
     7
     8        Like r188287, calling an empty std::function results in a std::bad_function_call
     9        exception being thrown when sendSync is failed.
     10
     11        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     12        (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
     13
    1142015-11-16  Beth Dakin  <bdakin@apple.com>
    215
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r192342 r192496  
    810810    WebCore::Frame* originatingCoreFrame = originatingFrame ? originatingFrame->coreFrame() : nullptr;
    811811    if (!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForNavigationAction(m_frame->frameID(), SecurityOriginData::fromFrame(coreFrame), documentLoader->navigationID(), navigationActionData, originatingFrame ? originatingFrame->frameID() : 0, SecurityOriginData::fromFrame(originatingCoreFrame), navigationAction.resourceRequest(), request, listenerID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())), Messages::WebPageProxy::DecidePolicyForNavigationAction::Reply(receivedPolicyAction, newNavigationID, policyAction, downloadID))) {
    812         function(PolicyIgnore);
     812        m_frame->didReceivePolicyDecision(listenerID, PolicyIgnore, 0, 0);
    813813        return;
    814814    }
Note: See TracChangeset for help on using the changeset viewer.