Changeset 192575 in webkit


Ignore:
Timestamp:
Nov 18, 2015 6:52:29 AM (8 years ago)
Author:
adam.bergkvist@ericsson.com
Message:

WebRTC: Initial testing of updated RTCPeerConnection API
​https://bugs.webkit.org/show_bug.cgi?id=151304

Reviewed by Eric Carlson.

Source/WebCore:

Add an empty implementation of MediaEndpointPeerConnection which
realizes the PeerConnectionBackend interface. This makes it possible
to construct an RTCPeerConnection and do initial testing.

Tests: fast/mediastream/RTCPeerConnection-overloaded-operations-params.html

fast/mediastream/RTCPeerConnection-overloaded-operations.html

Also unskip three existing RTCPeerConnection tests on GTK.

  • CMakeLists.txt:
  • Modules/mediastream/MediaEndpointPeerConnection.cpp: Added.

(WebCore::createMediaEndpointPeerConnection):
(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):
(WebCore::MediaEndpointPeerConnection::createOffer):
(WebCore::MediaEndpointPeerConnection::createAnswer):
(WebCore::MediaEndpointPeerConnection::setLocalDescription):
(WebCore::MediaEndpointPeerConnection::localDescription):
(WebCore::MediaEndpointPeerConnection::currentLocalDescription):
(WebCore::MediaEndpointPeerConnection::pendingLocalDescription):
(WebCore::MediaEndpointPeerConnection::setRemoteDescription):
(WebCore::MediaEndpointPeerConnection::remoteDescription):
(WebCore::MediaEndpointPeerConnection::currentRemoteDescription):
(WebCore::MediaEndpointPeerConnection::pendingRemoteDescription):
(WebCore::MediaEndpointPeerConnection::setConfiguration):
(WebCore::MediaEndpointPeerConnection::addIceCandidate):
(WebCore::MediaEndpointPeerConnection::getStats):
(WebCore::MediaEndpointPeerConnection::stop):
(WebCore::MediaEndpointPeerConnection::markAsNeedingNegotiation):

  • Modules/mediastream/MediaEndpointPeerConnection.h: Added.
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add two new tests and unskip three old ones (details below).

  • fast/mediastream/RTCPeerConnection-overloaded-operations-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-overloaded-operations-params.html: Added.

Feeds some good but mostly bad input to the overloaded operations to verify JS built-ins
argument checking.

  • fast/mediastream/RTCPeerConnection-overloaded-operations.html: Added.

Verifies that the correct overloaded operation is invoked. For examaple, createOffer()
without arguments should invoke the promise based function, but the same operation with
two function arguments should invoke the legacy callback version.

  • platform/gtk/TestExpectations:

Unskip fast/mediastream/RTCIceCandidate.html, fast/mediastream/RTCPeerConnection.html
and fast/mediastream/RTCSessionDescription.html.

Location:
trunk
Files:
6 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r192573 r192575  
     12015-11-18  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Initial testing of updated RTCPeerConnection API
     4        https://bugs.webkit.org/show_bug.cgi?id=151304
     5
     6        Reviewed by Eric Carlson.
     7
     8        Add two new tests and unskip three old ones (details below).
     9
     10        * fast/mediastream/RTCPeerConnection-overloaded-operations-expected.txt: Added.
     11        * fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Added.
     12        * fast/mediastream/RTCPeerConnection-overloaded-operations-params.html: Added.
     13        Feeds some good but mostly bad input to the overloaded operations to verify JS built-ins
     14        argument checking.
     15        * fast/mediastream/RTCPeerConnection-overloaded-operations.html: Added.
     16        Verifies that the correct overloaded operation is invoked. For examaple, createOffer()
     17        without arguments should invoke the promise based function, but the same operation with
     18        two function arguments should invoke the legacy callback version.
     19        * platform/gtk/TestExpectations:
     20        Unskip fast/mediastream/RTCIceCandidate.html, fast/mediastream/RTCPeerConnection.html
     21        and fast/mediastream/RTCSessionDescription.html.
     22
    1232015-11-18  Javier Fernandez  <jfernandez@igalia.com>
    224

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r192571 r192575  
    332332webkit.org/b/79203 fast/mediastream/MediaStreamTrack.html [ Skip ]
    333333webkit.org/b/79203 fast/mediastream/MediaStreamTrack-onended.html [ Skip ]
    334 webkit.org/b/79203 fast/mediastream/RTCIceCandidate.html [ Skip ]
    335334webkit.org/b/79203 fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
    336335webkit.org/b/79203 fast/mediastream/RTCPeerConnection-createAnswer.html [ Skip ]
    … …  
    344343webkit.org/b/79203 fast/mediastream/RTCPeerConnection-have-remote-offer.html [ Skip ]
    345344webkit.org/b/79203 fast/mediastream/RTCPeerConnection-have-remote-pranswer.html [ Skip ]
    346 webkit.org/b/79203 fast/mediastream/RTCPeerConnection.html [ Skip ]
    347345webkit.org/b/79203 fast/mediastream/RTCPeerConnection-ice.html [ Skip ]
    348346webkit.org/b/79203 fast/mediastream/RTCPeerConnection-localDescription.html [ Skip ]
    … …  
    353351webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Skip ]
    354352webkit.org/b/79203 fast/mediastream/RTCPeerConnection-statsSelector.html [ Skip ]
    355 webkit.org/b/79203 fast/mediastream/RTCSessionDescription.html [ Skip ]
    356353webkit.org/b/79203 fast/events/constructors/media-stream-event-constructor.html [ Skip ]
    357354webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ]

  • trunk/Source/WebCore/CMakeLists.txt

    r192490 r192575  
    948948    Modules/mediastream/MediaDevices.cpp
    949949    Modules/mediastream/MediaDevicesRequest.cpp
     950    Modules/mediastream/MediaEndpointPeerConnection.cpp
    950951    Modules/mediastream/MediaSourceStates.cpp
    951952    Modules/mediastream/MediaStream.cpp
    … …  
    961962    Modules/mediastream/NavigatorMediaDevices.cpp
    962963    Modules/mediastream/NavigatorUserMediaError.cpp
    963     Modules/mediastream/PeerConnectionBackend.cpp
    964964    Modules/mediastream/RTCConfiguration.cpp
    965965    Modules/mediastream/RTCDTMFSender.cpp

  • trunk/Source/WebCore/ChangeLog

    r192574 r192575  
     12015-11-18  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Initial testing of updated RTCPeerConnection API
     4        https://bugs.webkit.org/show_bug.cgi?id=151304
     5
     6        Reviewed by Eric Carlson.
     7
     8        Add an empty implementation of MediaEndpointPeerConnection which
     9        realizes the PeerConnectionBackend interface. This makes it possible
     10        to construct an RTCPeerConnection and do initial testing.
     11
     12        Tests: fast/mediastream/RTCPeerConnection-overloaded-operations-params.html
     13               fast/mediastream/RTCPeerConnection-overloaded-operations.html
     14
     15        Also unskip three existing RTCPeerConnection tests on GTK.
     16
     17        * CMakeLists.txt:
     18        * Modules/mediastream/MediaEndpointPeerConnection.cpp: Added.
     19        (WebCore::createMediaEndpointPeerConnection):
     20        (WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):
     21        (WebCore::MediaEndpointPeerConnection::createOffer):
     22        (WebCore::MediaEndpointPeerConnection::createAnswer):
     23        (WebCore::MediaEndpointPeerConnection::setLocalDescription):
     24        (WebCore::MediaEndpointPeerConnection::localDescription):
     25        (WebCore::MediaEndpointPeerConnection::currentLocalDescription):
     26        (WebCore::MediaEndpointPeerConnection::pendingLocalDescription):
     27        (WebCore::MediaEndpointPeerConnection::setRemoteDescription):
     28        (WebCore::MediaEndpointPeerConnection::remoteDescription):
     29        (WebCore::MediaEndpointPeerConnection::currentRemoteDescription):
     30        (WebCore::MediaEndpointPeerConnection::pendingRemoteDescription):
     31        (WebCore::MediaEndpointPeerConnection::setConfiguration):
     32        (WebCore::MediaEndpointPeerConnection::addIceCandidate):
     33        (WebCore::MediaEndpointPeerConnection::getStats):
     34        (WebCore::MediaEndpointPeerConnection::stop):
     35        (WebCore::MediaEndpointPeerConnection::markAsNeedingNegotiation):
     36        * Modules/mediastream/MediaEndpointPeerConnection.h: Added.
     37        * WebCore.xcodeproj/project.pbxproj:
     38
    1392015-11-18  Alejandro G. Castro  <alex@igalia.com>
    240

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r192490 r192575  
    23612361                5DFE8F570D16477C0076E937 /* ScheduledAction.h in Headers */ = {isa = PBXBuildFile; fileRef = BCA378BB0D15F64200B793D6 /* ScheduledAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
    23622362                5DFEBAB718592B6D00C75BEB /* WebKitAvailability.h in Headers */ = {isa = PBXBuildFile; fileRef = 5DFEBAB618592B6D00C75BEB /* WebKitAvailability.h */; settings = {ATTRIBUTES = (Private, ); }; };
    2363                 5E2C43501BCEE2F60001E2BC /* PeerConnectionBackend.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5E2C434C1BCEE2E50001E2BC /* PeerConnectionBackend.cpp */; settings = {ASSET_TAGS = (); }; };
     2363                5E16A2E41BFA650B0029A21E /* MediaEndpointPeerConnection.h in Headers */ = {isa = PBXBuildFile; fileRef = 5E16A2E31BFA64FB0029A21E /* MediaEndpointPeerConnection.h */; settings = {ASSET_TAGS = (); }; };
     2364                5E16A2E51BFA650F0029A21E /* MediaEndpointPeerConnection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5E16A2E21BFA64FB0029A21E /* MediaEndpointPeerConnection.cpp */; settings = {ASSET_TAGS = (); }; };
    23642365                5E2C43511BCEE2F60001E2BC /* PeerConnectionBackend.h in Headers */ = {isa = PBXBuildFile; fileRef = 5E2C434D1BCEE2E50001E2BC /* PeerConnectionBackend.h */; settings = {ASSET_TAGS = (); }; };
    23652366                5E2C43521BCEE2F60001E2BC /* PeerConnectionStates.h in Headers */ = {isa = PBXBuildFile; fileRef = 5E2C434E1BCEE2E50001E2BC /* PeerConnectionStates.h */; settings = {ASSET_TAGS = (); }; };
    … …  
    98189819                5DB1BC6910715A6400EFAA49 /* TransformSourceLibxslt.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TransformSourceLibxslt.cpp; sourceTree = "<group>"; };
    98199820                5DFEBAB618592B6D00C75BEB /* WebKitAvailability.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebKitAvailability.h; sourceTree = "<group>"; };
    9820                 5E2C434C1BCEE2E50001E2BC /* PeerConnectionBackend.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PeerConnectionBackend.cpp; sourceTree = "<group>"; };
     9821                5E16A2E21BFA64FB0029A21E /* MediaEndpointPeerConnection.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaEndpointPeerConnection.cpp; sourceTree = "<group>"; };
     9822                5E16A2E31BFA64FB0029A21E /* MediaEndpointPeerConnection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaEndpointPeerConnection.h; sourceTree = "<group>"; };
    98219823                5E2C434D1BCEE2E50001E2BC /* PeerConnectionBackend.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PeerConnectionBackend.h; sourceTree = "<group>"; };
    98229824                5E2C434E1BCEE2E50001E2BC /* PeerConnectionStates.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PeerConnectionStates.h; sourceTree = "<group>"; };
    … …  
    1513715139                                07394EC71BAB2CCD00BE99CD /* MediaDevicesRequest.cpp */,
    1513815140                                07394EC91BAB2CD700BE99CD /* MediaDevicesRequest.h */,
     15141                                5E16A2E21BFA64FB0029A21E /* MediaEndpointPeerConnection.cpp */,
     15142                                5E16A2E31BFA64FB0029A21E /* MediaEndpointPeerConnection.h */,
    1513915143                                07C59B6517F784BA000FBCBB /* MediaSourceStates.cpp */,
    1514015144                                07C59B6617F784BA000FBCBB /* MediaSourceStates.h */,
    … …  
    1517815182                                07221B5D17CEC32700848E51 /* NavigatorUserMediaError.h */,
    1517915183                                07221B5E17CEC32700848E51 /* NavigatorUserMediaError.idl */,
    15180                                 5E2C434C1BCEE2E50001E2BC /* PeerConnectionBackend.cpp */,
    1518115184                                5E2C434D1BCEE2E50001E2BC /* PeerConnectionBackend.h */,
    1518215185                                5E2C434E1BCEE2E50001E2BC /* PeerConnectionStates.h */,
    … …  
    2562325626                                628D214E12131EF40055DCFC /* FrameNetworkingContext.h in Headers */,
    2562425627                                93309E0E099E64920056E581 /* FrameSelection.h in Headers */,
     25628                                5E16A2E41BFA650B0029A21E /* MediaEndpointPeerConnection.h in Headers */,
    2562525629                                C4CD629B18383766007EBAF1 /* FrameSnapshotting.h in Headers */,
    2562625630                                65A21485097A3F5300B9050A /* FrameTree.h in Headers */,
    … …  
    3067430678                                CDFC360518CA61C20026E56F /* RemoteCommandListener.cpp in Sources */,
    3067530679                                CDFC360718CA696C0026E56F /* RemoteCommandListenerIOS.mm in Sources */,
     30680                                5E16A2E51BFA650F0029A21E /* MediaEndpointPeerConnection.cpp in Sources */,
    3067630681                                93309E00099E64920056E581 /* RemoveCSSPropertyCommand.cpp in Sources */,
    3067730682                                D06C0D900CFD11460065F43F /* RemoveFormatCommand.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.