Changeset 192675 in webkit
- Timestamp:
- Nov 19, 2015 8:51:18 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r192671 r192675 1 2015-11-19 Adam Bergkvist <adam.bergkvist@ericsson.com> 2 3 WebRTC: Initial testing of updated RTCPeerConnection API 4 https://bugs.webkit.org/show_bug.cgi?id=151304 5 6 Reviewed by Eric Carlson. 7 8 Unskip two previously crashing tests. 9 fast/mediastream/RTCPeerConnection-overloaded-operations.html 10 fast/mediastream/RTCPeerConnection-overloaded-operations-params.html 11 12 * platform/mac-wk2/TestExpectations: 13 * platform/mac/TestExpectations: 14 1 15 2015-11-19 Saam barati <sbarati@apple.com> 2 16 -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r192652 r192675 566 566 imported/blink/fast/multicol/span/adjacent-spanners-with-margin.html [ Pass ImageOnlyFailure ] 567 567 imported/blink/fast/overflow/hidden-html-auto-body.html [ Pass ImageOnlyFailure ] 568 569 webkit.org/b/151304 [ Debug ] fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Pass Crash ]570 webkit.org/b/151304 [ Debug ] fast/mediastream/RTCPeerConnection-overloaded-operations.html [ Pass Crash ] -
trunk/LayoutTests/platform/mac/TestExpectations
r192670 r192675 192 192 fast/mediastream/RTCPeerConnection-localDescription.html 193 193 fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 194 fast/mediastream/RTCPeerConnection-overloaded-operations.html195 fast/mediastream/RTCPeerConnection-overloaded-operations-params.html196 194 fast/mediastream/RTCPeerConnection-remoteDescription.html 197 195 fast/mediastream/RTCPeerConnection-stats.html -
trunk/Source/WebCore/ChangeLog
r192672 r192675 1 2015-11-19 Adam Bergkvist <adam.bergkvist@ericsson.com> 2 3 WebRTC: Initial testing of updated RTCPeerConnection API 4 https://bugs.webkit.org/show_bug.cgi?id=151304 5 6 Reviewed by Eric Carlson. 7 8 Remove faulty ASSERT since the selector argument to 9 RTCPeerConnection.getStats() is nullable. Also use 10 pointers instead of a ref (for the same reason). 11 12 Tests: Unskip two crashing tests. 13 14 * Modules/mediastream/MediaEndpointPeerConnection.cpp: 15 (WebCore::MediaEndpointPeerConnection::getStats): 16 * Modules/mediastream/MediaEndpointPeerConnection.h: 17 * Modules/mediastream/PeerConnectionBackend.h: 18 * Modules/mediastream/RTCPeerConnection.cpp: 19 (WebCore::RTCPeerConnection::privateGetStats): 20 1 21 2015-11-19 Hunseop Jeong <hs85.jeong@samsung.com> 2 22 -
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
r192575 r192675 147 147 } 148 148 149 void MediaEndpointPeerConnection::getStats(MediaStreamTrack &, PeerConnection::StatsPromise&& promise)149 void MediaEndpointPeerConnection::getStats(MediaStreamTrack*, PeerConnection::StatsPromise&& promise) 150 150 { 151 151 notImplemented(); -
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h
r192575 r192675 63 63 void addIceCandidate(RTCIceCandidate&, PeerConnection::VoidPromise&&) override; 64 64 65 void getStats(MediaStreamTrack &, PeerConnection::StatsPromise&&) override;65 void getStats(MediaStreamTrack*, PeerConnection::StatsPromise&&) override; 66 66 67 67 void stop() override; -
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
r192464 r192675 100 100 virtual void addIceCandidate(RTCIceCandidate&, PeerConnection::VoidPromise&&) = 0; 101 101 102 virtual void getStats(MediaStreamTrack &, PeerConnection::StatsPromise&&) = 0;102 virtual void getStats(MediaStreamTrack*, PeerConnection::StatsPromise&&) = 0; 103 103 104 104 virtual void stop() = 0; -
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
r192464 r192675 358 358 void RTCPeerConnection::privateGetStats(MediaStreamTrack* selector, PeerConnection::StatsPromise&& promise) 359 359 { 360 ASSERT(selector); 361 m_backend->getStats(*selector, WTF::move(promise)); 360 m_backend->getStats(selector, WTF::move(promise)); 362 361 } 363 362
Note: See TracChangeset
for help on using the changeset viewer.