Changeset 19275 in webkit

Timestamp:

Jan 30, 2007 3:24:24 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Geoff.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12050 REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)

• plugins/createScriptableObject-before-start-expected.txt: Added.
• plugins/createScriptableObject-before-start.html: Added.

WebKit:

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12050 REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)

Test: plugins/createScriptableObject-before-start.html

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if the plugin is not started.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/plugins/createScriptableObject-before-start-expected.txt (added)
• LayoutTests/plugins/createScriptableObject-before-start.html (added)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Plugins/WebBaseNetscapePluginView.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-01-30  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Geoff.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=12050
+          REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)
+
+        * plugins/createScriptableObject-before-start-expected.txt: Added.
+        * plugins/createScriptableObject-before-start.html: Added.
+
 2007-01-30  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-01-30  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Geoff.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12050
+          REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)
+
+        Test: plugins/createScriptableObject-before-start.html
+
+        * Plugins/WebBaseNetscapePluginView.mm:
+        (-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if
+        the plugin is not started.
+
 2007-01-30  Maciej Stachowiak  <mjs@apple.com>
 

trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

@@ -1767 +1767 @@
 - (NPObject *)createPluginScriptableObject
 {
-    if (!NPP_GetValue)
+    if (!NPP_GetValue || ![self isStarted])
         return NULL;