Changeset 192771 in webkit

Timestamp:

Nov 25, 2015 12:53:51 PM (8 years ago)

Author:

BJ Burg

Message:

Web Inspector: save Inspector's breakpoints to localStorage whenever they are modified
​https://bugs.webkit.org/show_bug.cgi?id=151581

Reviewed by Timothy Hatcher.

Serialize all breakpoints to the "breakpoints" Setting in local storage
whenever any breakpoint model object is added, removed, or modified.

Remove the old listener that attempted to save breakpoints on the
pagehide event. It did not fire in important scenarios like exiting
the browser via Cmd-Q or killing the process via Ctrl-C / SIGKILL.

This is not expected to be a performance problem because most people
do not keep thousands of breakpoints active, and breakpoints are not
set very often. If it's a problem, we can mitigate it with coalescing.

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.addBreakpoint):
(WebInspector.DebuggerManager.prototype.removeBreakpoint):
(WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
(WebInspector.DebuggerManager.prototype._saveBreakpoints):
(WebInspector.DebuggerManager.prototype._inspectorClosing): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DebuggerManager.js (modified) (6 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-11-24  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: save Inspector's breakpoints to localStorage whenever they are modified
+        https://bugs.webkit.org/show_bug.cgi?id=151581
+
+        Reviewed by Timothy Hatcher.
+
+        Serialize all breakpoints to the "breakpoints" Setting in local storage
+        whenever any breakpoint model object is added, removed, or modified.
+
+        Remove the old listener that attempted to save breakpoints on the
+        pagehide event. It did not fire in important scenarios like exiting
+        the browser via Cmd-Q or killing the process via Ctrl-C / SIGKILL.
+
+        This is not expected to be a performance problem because most people
+        do not keep thousands of breakpoints active, and breakpoints are not
+        set very often. If it's a problem, we can mitigate it with coalescing.
+
+        * UserInterface/Controllers/DebuggerManager.js:
+        (WebInspector.DebuggerManager.prototype.addBreakpoint):
+        (WebInspector.DebuggerManager.prototype.removeBreakpoint):
+        (WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
+        (WebInspector.DebuggerManager.prototype._saveBreakpoints):
+        (WebInspector.DebuggerManager.prototype._inspectorClosing): Deleted.
+
 2015-11-24  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js

@@ -42 +42 @@
         WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
 
-        window.addEventListener("pagehide", this._inspectorClosing.bind(this));
-
         this._allExceptionsBreakpointEnabledSetting = new WebInspector.Setting("break-on-all-exceptions", false);
         this._allUncaughtExceptionsBreakpointEnabledSetting = new WebInspector.Setting("break-on-all-uncaught-exceptions", false);
@@ -363 +361 @@
             this._setBreakpoint(breakpoint, shouldSpeculativelyResolve ? speculativelyResolveBreakpoint.bind(null, breakpoint) : null);
 
+        this._saveBreakpoints();
+
         if (!skipEventDispatch)
             this.dispatchEventToListeners(WebInspector.DebuggerManager.Event.BreakpointAdded, {breakpoint});
@@ -403 +403 @@
         breakpoint.disabled = true;
         breakpoint.clearActions();
+
+        this._saveBreakpoints();
 
         this.dispatchEventToListeners(WebInspector.DebuggerManager.Event.BreakpointRemoved, {breakpoint});
@@ -765 +767 @@
     _breakpointDisabledStateDidChange(event)
     {
-        var breakpoint = event.target;
-
+        this._saveBreakpoints();
+
+        let breakpoint = event.target;
         if (breakpoint === this._allExceptionsBreakpoint) {
             if (!breakpoint.disabled)
@@ -791 +794 @@
     _breakpointEditablePropertyDidChange(event)
     {
-        var breakpoint = event.target;
+        this._saveBreakpoints();
+
+        let breakpoint = event.target;
         if (breakpoint.disabled)
             return;
@@ -863 +868 @@
     }
 
-    _inspectorClosing(event)
-    {
-        this._saveBreakpoints();
-    }
-
     _saveBreakpoints()
     {
-        var savedBreakpoints = [];
-
-        for (var i = 0; i < this._breakpoints.length; ++i) {
-            var breakpoint = this._breakpoints[i];
-
-            // Only breakpoints with URLs can be saved. Breakpoints for transient scripts can't.
-            if (!breakpoint.url)
-                continue;
-
-            savedBreakpoints.push(breakpoint.info);
-        }
-
-        this._breakpointsSetting.value = savedBreakpoints;
+        if (this._restoringBreakpoints)
+            return;
+
+        let breakpointsToSave = this._breakpoints.filter((breakpoint) => !!breakpoint.url);
+        let serializedBreakpoints = breakpointsToSave.map((breakpoint) => breakpoint.info);
+        this._breakpointsSetting.value = serializedBreakpoints;
     }