Changeset 192775 in webkit

Timestamp:

Nov 27, 2015 12:37:44 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Do not use the WebCore garbage collector timer
​https://bugs.webkit.org/show_bug.cgi?id=151623

Reviewed by Martin Robinson.

Now that garbage collector timers have been implemented in
JavaScriptCore for glib, we don't need to use another Timer in WebCore.

• bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNowIfNotDoneRecently):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/GCController.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Do not use the WebCore garbage collector timer
+        https://bugs.webkit.org/show_bug.cgi?id=151623
+
+        Reviewed by Martin Robinson.
+
+        Now that garbage collector timers have been implemented in
+        JavaScriptCore for glib, we don't need to use another Timer in WebCore.
+
+        * bindings/js/GCController.cpp:
+        (WebCore::GCController::garbageCollectSoon):
+        (WebCore::GCController::garbageCollectNowIfNotDoneRecently):
+
 2015-11-18  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/bindings/js/GCController.cpp

@@ -58 +58 @@
 void GCController::garbageCollectSoon()
 {
-    // We only use reportAbandonedObjectGraph on systems with CoreFoundation 
-    // since it uses a run-loop-based timer that is currently only available on
-    // systems with CoreFoundation. If and when the notion of a run loop is pushed 
-    // down into WTF so that more platforms can take advantage of it, we will be 
-    // able to use reportAbandonedObjectGraph on more platforms.
-#if USE(CF)
+    // We only use reportAbandonedObjectGraph for systems for which there's an implementation
+    // of the garbage collector timers in JavaScriptCore. We wouldn't need this if JavaScriptCore
+    // used a timer implementation from WTF like RunLoop::Timer.
+#if USE(CF) || USE(GLIB)
     JSLockHolder lock(JSDOMWindow::commonVM());
     JSDOMWindow::commonVM().heap.reportAbandonedObjectGraph();
@@ -93 +91 @@
 void GCController::garbageCollectNowIfNotDoneRecently()
 {
-#if USE(CF)
+#if USE(CF) || USE(GLIB)
     JSLockHolder lock(JSDOMWindow::commonVM());
     if (!JSDOMWindow::commonVM().heap.isBusy())