Changeset 192810 in webkit

Timestamp:

Nov 30, 2015 11:27:26 AM (8 years ago)

Author:

Chris Dumez

Message:

location.origin is undefined in a web worker
​https://bugs.webkit.org/show_bug.cgi?id=151614

Reviewed by Darin Adler.

Source/WebCore:

Expose location.origin to web workers, as per:
​https://html.spec.whatwg.org/multipage/workers.html#workerlocation

This behavior is consistent with the behavior of Firefox and Chrome.

Test: fast/workers/worker-location.html

• workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::origin):

• workers/WorkerLocation.h:
• workers/WorkerLocation.idl:

LayoutTests:

Update existing layout test to confirm the existence of location.origin when in a
WorkerGlobalScope.

• fast/workers/resources/worker-location.js:
• fast/workers/worker-location-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/workers/resources/worker-location.js (modified) (1 diff)
• LayoutTests/fast/workers/worker-location-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/workers/WorkerLocation.cpp (modified) (2 diffs)
• Source/WebCore/workers/WorkerLocation.h (modified) (1 diff)
• Source/WebCore/workers/WorkerLocation.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-11-30  Chris Dumez  <cdumez@apple.com>
+
+        location.origin is undefined in a web worker
+        https://bugs.webkit.org/show_bug.cgi?id=151614
+
+        Reviewed by Darin Adler.
+
+        Update existing layout test to confirm the existence of location.origin when in a
+        WorkerGlobalScope.
+
+        * fast/workers/resources/worker-location.js:
+        * fast/workers/worker-location-expected.txt:
+
 2015-11-30  Brady Eidson  <beidson@apple.com>
 

trunk/LayoutTests/fast/workers/resources/worker-location.js

@@ -31 +31 @@
 worker.postMessage("eval location.search");
 worker.postMessage("eval location.hash");
+worker.postMessage("eval location.origin");
 worker.postMessage("eval foo//bar");
 

trunk/LayoutTests/fast/workers/worker-location-expected.txt

@@ -12 +12 @@
 location.search: 
 location.hash: 
+location.origin: file://
 DONE
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-11-30  Chris Dumez  <cdumez@apple.com>
+
+        location.origin is undefined in a web worker
+        https://bugs.webkit.org/show_bug.cgi?id=151614
+
+        Reviewed by Darin Adler.
+
+        Expose location.origin to web workers, as per:
+        https://html.spec.whatwg.org/multipage/workers.html#workerlocation
+
+        This behavior is consistent with the behavior of Firefox and Chrome.
+
+        Test: fast/workers/worker-location.html
+
+        * workers/WorkerLocation.cpp:
+        (WebCore::WorkerLocation::origin):
+        * workers/WorkerLocation.h:
+        * workers/WorkerLocation.idl:
+
 2015-11-30  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/workers/WorkerLocation.cpp

@@ -26 +26 @@
 
 #include "config.h"
-
 #include "WorkerLocation.h"
 
+#include "SecurityOrigin.h"
 #include <wtf/text/WTFString.h>
 
@@ -73 +73 @@
 }
 
+String WorkerLocation::origin() const
+{
+    return SecurityOrigin::create(m_url)->toString();
+}
 
 } // namespace WebCore

trunk/Source/WebCore/workers/WorkerLocation.h

@@ -55 +55 @@
         String search() const;
         String hash() const;
+        String origin() const;
 
         String toString() const { return href(); }

trunk/Source/WebCore/workers/WorkerLocation.idl

@@ -40 +40 @@
     readonly attribute DOMString search;
     readonly attribute DOMString hash;
+    readonly attribute DOMString origin;
 
     [NotEnumerable] DOMString toString();