Changeset 193613 in webkit

Timestamp:

Dec 6, 2015 10:27:08 PM (8 years ago)

Author:

Simon Fraser

Message:

Clipping along compositing borders in svg-edit
​https://bugs.webkit.org/show_bug.cgi?id=151791

Reviewed by Zalan Bujtas.

Source/WebCore:

RenderSVGRoot::layout() failed to clear overflow before recomputing
visual overflow, which could cause it to get stuck with stale overflow.
This would cause underpainting if its size went from small to large.

Test: svg/overflow/visual-overflow-change.html

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

LayoutTests:

Ref test that triggers recomputation of overflow.

• svg/overflow/visual-overflow-change-expected.html: Added.
• svg/overflow/visual-overflow-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/overflow/visual-overflow-change-expected.html (added)
• LayoutTests/svg/overflow/visual-overflow-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGRoot.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-12-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Clipping along compositing borders in svg-edit
+        https://bugs.webkit.org/show_bug.cgi?id=151791
+
+        Reviewed by Zalan Bujtas.
+        
+        Ref test that triggers recomputation of overflow.
+
+        * svg/overflow/visual-overflow-change-expected.html: Added.
+        * svg/overflow/visual-overflow-change.html: Added.
+
 2015-12-06  Andy VanWagoner  <thetalecrafter@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-12-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Clipping along compositing borders in svg-edit
+        https://bugs.webkit.org/show_bug.cgi?id=151791
+
+        Reviewed by Zalan Bujtas.
+        
+        RenderSVGRoot::layout() failed to clear overflow before recomputing
+        visual overflow, which could cause it to get stuck with stale overflow.
+        This would cause underpainting if its size went from small to large.
+
+        Test: svg/overflow/visual-overflow-change.html
+
+        * rendering/svg/RenderSVGRoot.cpp:
+        (WebCore::RenderSVGRoot::layout):
+
 2015-12-06  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

@@ -197 +197 @@
     }
 
+    clearOverflow();
     if (!shouldApplyViewportClip()) {
         FloatRect contentRepaintRect = repaintRectInLocalCoordinates();