Changeset 193829 in webkit


Ignore:
Timestamp:
Dec 9, 2015 6:46:11 AM (8 years ago)
Author:
fred.wang@free.fr
Message:

Bad position of large operators inside an munderover element
​https://bugs.webkit.org/show_bug.cgi?id=151916

Reviewed by Alejandro G. Castro.

Source/WebCore:

Test: mathml/opentype/large-operators-munderover.html

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators.

LayoutTests:

  • mathml/opentype/large-operators-munderover-expected.txt: Added.
  • mathml/opentype/large-operators-munderover.html: Added.

Add a test to verify the position and size of a large operator used as an munderover base.

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r193825 r193829  
     12015-12-09  Frederic Wang  <fred.wang@free.fr>
     2
     3        Bad position of large operators inside an munderover element
     4        https://bugs.webkit.org/show_bug.cgi?id=151916
     5
     6        Reviewed by Alejandro G. Castro.
     7
     8        * mathml/opentype/large-operators-munderover-expected.txt: Added.
     9        * mathml/opentype/large-operators-munderover.html: Added.
     10
     11        Add a test to verify the position and size of a large operator used as an munderover base.
     12
    1132015-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r193828 r193829  
     12015-12-09  Frederic Wang  <fred.wang@free.fr>
     2
     3        Bad position of large operators inside an munderover element
     4        https://bugs.webkit.org/show_bug.cgi?id=151916
     5
     6        Reviewed by Alejandro G. Castro.
     7
     8        Test: mathml/opentype/large-operators-munderover.html
     9
     10        * rendering/mathml/RenderMathMLOperator.h:
     11        (WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator.
     12        * rendering/mathml/RenderMathMLUnderOver.cpp:
     13        (WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators.
     14
    1152015-12-09  Zan Dobersek  <zdobersek@igalia.com>
    216

  • trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h

    r183857 r193829  
    7272    // FIXME: The displaystyle property is not implemented (https://bugs.webkit.org/show_bug.cgi?id=118737).
    7373    bool isLargeOperatorInDisplayStyle() const { return !hasOperatorFlag(MathMLOperatorDictionary::Stretchy) && hasOperatorFlag(MathMLOperatorDictionary::LargeOp); }
     74    bool isVertical() const { return m_isVertical; }
    7475
    7576    virtual void updateStyle() override final;

  • trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp

    r181398 r193829  
    8181            if (is<RenderMathMLBlock>(child)) {
    8282                if (auto renderOperator = downcast<RenderMathMLBlock>(*child).unembellishedOperator()) {
    83                     renderOperator->resetStretchSize();
    84                     renderOperators.append(renderOperator);
     83                    if (!renderOperator->isVertical()) {
     84                        renderOperator->resetStretchSize();
     85                        renderOperators.append(renderOperator);
     86                    }
    8587                }
    8688            }
Note: See TracChangeset for help on using the changeset viewer.