Changeset 193832 in webkit

Timestamp:

Dec 9, 2015 7:34:28 AM (8 years ago)

Author:

calvaris@igalia.com

Message:

[Streams API] pipeThrough test failing
​https://bugs.webkit.org/show_bug.cgi?id=152061

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.

Source/WebCore:

Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html

• Modules/streams/ReadableStream.js:

(pipeThrough): Mimic destructuring for the streams parameter.

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/streams/ReadableStream.js (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.
+
 2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt

@@ -3 +3 @@
 PASS ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object 
 PASS ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method 
-FAIL ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable assert_unreached: pipeTo should not be called Reached unreachable code
+PASS ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable 
 PASS ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options 
 FAIL Load pipe-through.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html
+
+        * Modules/streams/ReadableStream.js:
+        (pipeThrough): Mimic destructuring for the streams parameter.
+
 2015-12-09  Frederic Wang  <fred.wang@free.fr>
 

trunk/Source/WebCore/Modules/streams/ReadableStream.js

@@ -95 +95 @@
     "use strict";
 
-    this.pipeTo(streams.writable, options);
-    return streams.readable;
+    const writable = streams.writable;
+    const readable = streams.readable;
+    this.pipeTo(writable, options);
+    return readable;
 }