Changeset 193968 in webkit
- Timestamp:
- Dec 11, 2015 11:13:38 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r193958 r193968 1 2015-12-11 Brady Eidson <beidson@apple.com> 2 3 Modern IDB: storage/indexeddb/index-count.html fails. 4 https://bugs.webkit.org/show_bug.cgi?id=152175 5 6 Reviewed by Alex Christensen. 7 8 * platform/mac-wk1/TestExpectations: 9 * storage/indexeddb/index-count-expected.txt: 10 * storage/indexeddb/modern/index-get-count-failures-expected.txt: 11 1 12 2015-12-11 Daniel Bates <dabates@apple.com> 2 13 -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r193949 r193968 97 97 storage/indexeddb/delete-closed-database-object.html [ Failure ] 98 98 storage/indexeddb/index-basics.html [ Failure ] 99 storage/indexeddb/index-count.html [ Failure ]100 99 storage/indexeddb/index-duplicate-keypaths.html [ Failure ] 101 100 storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html [ Failure ] -
trunk/LayoutTests/storage/indexeddb/index-count-expected.txt
r164014 r193968 89 89 PASS code is 0 90 90 PASS ename is 'DataError' 91 Exception message: DataError: DOM IDBDatabase Exception 091 Exception message: Failed to execute 'count' on 'IDBIndex': The parameter is not a valid key. 92 92 Expecting exception from index.count({}) 93 93 PASS Exception was thrown. 94 94 PASS code is 0 95 95 PASS ename is 'DataError' 96 Exception message: DataError: DOM IDBDatabase Exception 096 Exception message: Failed to execute 'count' on 'IDBIndex': The parameter is not a valid key. 97 97 Expecting exception from index.count(/regex/) 98 98 PASS Exception was thrown. 99 99 PASS code is 0 100 100 PASS ename is 'DataError' 101 Exception message: DataError: DOM IDBDatabase Exception 0101 Exception message: Failed to execute 'count' on 'IDBIndex': The parameter is not a valid key. 102 102 103 103 test = {"key":0,"expected":1} -
trunk/LayoutTests/storage/indexeddb/modern/index-get-count-failures-expected.txt
r192645 r193968 3 3 Failed to get with a null key 4 4 Failed to getKey with a null key 5 Failed to count with a null range6 5 Failed to get with deleted IDBIndex 7 6 Failed to getKey with deleted IDBIndex -
trunk/Source/WebCore/ChangeLog
r193959 r193968 1 2015-12-11 Brady Eidson <beidson@apple.com> 2 3 Modern IDB: storage/indexeddb/index-count.html fails. 4 https://bugs.webkit.org/show_bug.cgi?id=152175 5 6 Reviewed by Alex Christensen. 7 8 No new tests (At least one failing test now passes). 9 10 * Modules/indexeddb/client/IDBIndexImpl.cpp: 11 (WebCore::IDBClient::IDBIndex::count): If the passed in IDBKeyRange* is nullptr, use IDBKeyRangeData::allKeys. 12 (WebCore::IDBClient::IDBIndex::doCount): Change an isNull check to a more correct !isValid() check. 13 1 14 2015-12-11 Per Arne Vollan <peavo@outlook.com> 2 15 -
trunk/Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp
r193428 r193968 140 140 } 141 141 142 IDBKeyRangeData range; 143 range.isNull = false; 144 return doCount(*context, range, ec);} 142 return doCount(*context, IDBKeyRangeData::allKeys(), ec);} 145 143 146 144 RefPtr<WebCore::IDBRequest> IDBIndex::count(ScriptExecutionContext* context, IDBKeyRange* range, ExceptionCodeWithMessage& ec) … … 153 151 } 154 152 155 return doCount(*context, IDBKeyRangeData(range), ec);153 return doCount(*context, range ? IDBKeyRangeData(range) : IDBKeyRangeData::allKeys(), ec); 156 154 } 157 155 … … 183 181 } 184 182 185 if ( range.isNull) {183 if (!range.isValid()) { 186 184 ec.code = IDBDatabaseException::DataError; 187 185 return nullptr;
Note: See TracChangeset
for help on using the changeset viewer.