Changeset 194009 in webkit

Timestamp:

Dec 12, 2015 9:37:35 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes
​https://bugs.webkit.org/show_bug.cgi?id=152173

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-12
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
Disable the keyboard shortcuts when they are created. They will be
enabled when the panel is shown / hidden. It doesn't really make sense
that these are on the sidebar panel instead of the tab, but things
will be changing in Timelines soon anyways so just fix this now.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-12  Joseph Pecoraro  <pecoraro@apple.com>
+
+        REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes
+        https://bugs.webkit.org/show_bug.cgi?id=152173
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel):
+        Disable the keyboard shortcuts when they are created. They will be
+        enabled when the panel is shown / hidden. It doesn't really make sense
+        that these are on the sidebar panel instead of the tab, but things
+        will be changing in Timelines soon anyways so just fix this now.
+
 2015-12-12  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

@@ -176 +176 @@
         this._toggleRecordingShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Space, this._toggleRecordingOnSpacebar.bind(this));
         this._toggleRecordingShortcut.implicitlyPreventsDefault = false;
+        this._toggleRecordingShortcut.disabled = true;
 
         this._toggleNewRecordingShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Space, this._toggleNewRecordingOnSpacebar.bind(this));
         this._toggleNewRecordingShortcut.implicitlyPreventsDefault = false;
+        this._toggleNewRecordingShortcut.disabled = true;
     }