Changeset 194150 in webkit

Timestamp:

Dec 16, 2015 9:42:11 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Improve copy of console message containing Array and Map output
​https://bugs.webkit.org/show_bug.cgi?id=152329

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-16
Reviewed by Timothy Hatcher.

Introduce a real space in the content instead of style specific
margins so the existing copy/paste mechanism (innerText)
will have spaces between index/key and value.

• UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-name): Deleted.

• UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:

(WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeArrayIndexTreeElement):

• UserInterface/Views/ObjectTreeMapEntryTreeElement.css:

(.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name): Deleted.

• UserInterface/Views/ObjectTreeMapEntryTreeElement.js:

(WebInspector.ObjectTreeMapEntryTreeElement.prototype.titleFragment):
(WebInspector.ObjectTreeMapEntryTreeElement):

• UserInterface/Views/ObjectTreeSetIndexTreeElement.js:

(WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeSetIndexTreeElement):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (modified) (1 diff)
• UserInterface/Views/ObjectTreeArrayIndexTreeElement.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeMapEntryTreeElement.css (modified) (1 diff)
• UserInterface/Views/ObjectTreeMapEntryTreeElement.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeSetIndexTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-16  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve copy of console message containing Array and Map output
+        https://bugs.webkit.org/show_bug.cgi?id=152329
+
+        Reviewed by Timothy Hatcher.
+
+        Introduce a real space in the content instead of style specific
+        margins so the existing copy/paste mechanism (innerText)
+        will have spaces between index/key and value.
+
+        * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+        (.object-tree-array-index .index-name): Deleted.
+        * UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:
+        (WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
+        (WebInspector.ObjectTreeArrayIndexTreeElement):
+        * UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
+        (.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name): Deleted.
+        * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
+        (WebInspector.ObjectTreeMapEntryTreeElement.prototype.titleFragment):
+        (WebInspector.ObjectTreeMapEntryTreeElement):
+        * UserInterface/Views/ObjectTreeSetIndexTreeElement.js:
+        (WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):
+        (WebInspector.ObjectTreeSetIndexTreeElement):
+
 2015-12-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css

@@ -47 +47 @@
     display: inline-block;
     width: 30px;
-    margin-right: 7px;
     text-align: right;
 }

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js

@@ -61 +61 @@
         nameElement.title = this.propertyPathString(this.thisPropertyPath());
 
+        // Space. For copy/paste to have space between the index and value.
+        container.append(" ");
+
         // Value.
         var valueElement = container.appendChild(document.createElement("span"));

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css

@@ -27 +27 @@
     width: 40px;
     text-align: right;
-    margin-right: 5px;
 }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js

@@ -70 +70 @@
         nameElement.title = this.propertyPathString(propertyPath);
 
+        // Space. For copy/paste to have space between the key and value.
+        container.append(" ");
+
         // Value.
         var valueElement = container.appendChild(document.createElement("span"));

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js

@@ -72 +72 @@
         nameElement.title = WebInspector.UIString("Unable to determine path to property from root");
 
+        // Space. For copy/paste to have space between the bullet and value.
+        container.append(" ");
+
         // Value.
         var valueElement = container.appendChild(document.createElement("span"));