Changeset 194151 in webkit

Timestamp:

Dec 16, 2015 9:44:10 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Improve copy of console messages with multiple arguments - console.log(obj1, obj2)
​https://bugs.webkit.org/show_bug.cgi?id=152330

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-16
Reviewed by Timothy Hatcher.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype.toClipboardString):
Copy the inner text of the extra arguments list as well, for
console messages with multiple objects. Rearrange the sections
that, if there is a stack trace it comes at the end after
multiple arguments. If there is no stack trace, include the
location info next to the top line, before multiple arguments.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-16  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve copy of console messages with multiple arguments - console.log(obj1, obj2)
+        https://bugs.webkit.org/show_bug.cgi?id=152330
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype.toClipboardString):
+        Copy the inner text of the extra arguments list as well, for
+        console messages with multiple objects. Rearrange the sections
+        that, if there is a stack trace it comes at the end after
+        multiple arguments. If there is no stack trace, include the
+        location info next to the top line, before multiple arguments.
+
 2015-12-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -194 +194 @@
 
         let hasStackTrace = this._shouldShowStackTrace();
-        if (hasStackTrace) {
-            this._message.stackTrace.callFrames.forEach(function(frame) {
-                clipboardString += "\n\t" + (frame.functionName || WebInspector.UIString("(anonymous function)"));
-                if (frame.sourceCodeLocation)
-                    clipboardString += " (" + frame.sourceCodeLocation.originalLocationString() + ")";
-            });
-        } else {
+        if (!hasStackTrace) {
             let repeatString = this.repeatCount > 1 ? "x" + this.repeatCount : "";
             let urlLine = "";
@@ -216 +210 @@
                 clipboardString = lines.join("\n");
             }
+        }
+
+        if (this._extraElementsList)
+            clipboardString += "\n" + this._extraElementsList.innerText.removeWordBreakCharacters().trim();
+
+        if (hasStackTrace) {
+            this._message.stackTrace.callFrames.forEach(function(frame) {
+                clipboardString += "\n\t" + (frame.functionName || WebInspector.UIString("(anonymous function)"));
+                if (frame.sourceCodeLocation)
+                    clipboardString += " (" + frame.sourceCodeLocation.originalLocationString() + ")";
+            });
         }