Changeset 194207 in webkit

Timestamp:

Dec 16, 2015 8:26:32 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

Perf Dashboard v3 UI doesn't show recent data points on v2 UI
​https://bugs.webkit.org/show_bug.cgi?id=152368

Reviewed by Chris Dumez.

The bug was caused by the last modified date in measurement set JSON being a string instead of a POSIX timestamp,
which prevented the v3 UI from invalidating the cache. Specifically, the following boolean logic always evaluated
to false because +datalastModified? was NaN in MeasurementSet.prototype._fetch (/v3/models/measurement-set.js):

!clusterEndTime && useCache && +datalastModified? < self._lastModified

Fixed the bug by calling Database::to_js_time on the last modified date fetched from the database.

• public/api/measurement-set.php:

(MeasurementSetFetcher::fetch_config_list): Convert the string returned by the database to a POSIX timestamp.

• tests/api-measurement-set.js: Added a test to ensure the last modified date in JSON is numeric. Since the value

of the last modified date depends on when tests run, we can't assert it to be a certain value.

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/api/measurement-set.php (modified) (1 diff)
• tests/api-measurement-set.js (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf Dashboard v3 UI doesn't show recent data points on v2 UI
+        https://bugs.webkit.org/show_bug.cgi?id=152368
+
+        Reviewed by Chris Dumez.
+
+        The bug was caused by the last modified date in measurement set JSON being a string instead of a POSIX timestamp,
+        which prevented the v3 UI from invalidating the cache. Specifically, the following boolean logic always evaluated
+        to false because +data['lastModified'] was NaN in MeasurementSet.prototype._fetch (/v3/models/measurement-set.js):
+
+        !clusterEndTime && useCache && +data['lastModified'] < self._lastModified
+
+        Fixed the bug by calling Database::to_js_time on the last modified date fetched from the database.
+
+        * public/api/measurement-set.php:
+        (MeasurementSetFetcher::fetch_config_list): Convert the string returned by the database to a POSIX timestamp.
+        * tests/api-measurement-set.js: Added a test to ensure the last modified date in JSON is numeric. Since the value
+        of the last modified date depends on when tests run, we can't assert it to be a certain value.
+
 2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/api/measurement-set.php

@@ -86 +86 @@
             $query = $this->execute_query($config_row['config_id']);
 
-            $this->last_modified = max($this->last_modified, $config_row['config_runs_last_modified']);
+            $this->last_modified = max($this->last_modified, Database::to_js_time($config_row['config_runs_last_modified']));
 
             $measurement_row = $this->db->fetch_next_row($query);

trunk/Websites/perf.webkit.org/tests/api-measurement-set.js

@@ -207 +207 @@
 
                         assert.equal(paresdResult['startTime'], reportWithBuildTime.startTime);
+                        assert(typeof(paresdResult['lastModified']) == 'number', 'lastModified time should be a numeric');
 
                         assert.deepEqual(Object.keys(paresdResult['configurations']), ['current']);