Changeset 194319 in webkit


Ignore:
Timestamp:
Dec 20, 2015 2:27:02 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r194033 and r194267.
​https://bugs.webkit.org/show_bug.cgi?id=152465

Caused crashes on Mac WK1 bots (Requested by youenn on
#webkit).

Reverted changesets:

"[Streams API] Expose ReadableStream and relatives to Worker"
​https://bugs.webkit.org/show_bug.cgi?id=152066
​http://trac.webkit.org/changeset/194033

"[Streams API] imported/w3c/web-platform-tests/streams-api
/readable-streams/cancel.html has a flaky test"
​https://bugs.webkit.org/show_bug.cgi?id=152065
​http://trac.webkit.org/changeset/194267

Location:
trunk
Files:
1 deleted
34 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r194313 r194319  
     12015-12-20  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r194033 and r194267.
     4        https://bugs.webkit.org/show_bug.cgi?id=152465
     5
     6        Caused crashes on Mac WK1 bots (Requested by youenn on
     7        #webkit).
     8
     9        Reverted changesets:
     10
     11        "[Streams API] Expose ReadableStream and relatives to Worker"
     12        https://bugs.webkit.org/show_bug.cgi?id=152066
     13        http://trac.webkit.org/changeset/194033
     14
     15        "[Streams API] imported/w3c/web-platform-tests/streams-api
     16        /readable-streams/cancel.html has a flaky test"
     17        https://bugs.webkit.org/show_bug.cgi?id=152065
     18        http://trac.webkit.org/changeset/194267
     19
    1202015-12-18  Antti Koivisto  <antti@apple.com>
    221

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r194267 r194319  
     12015-12-20  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r194033 and r194267.
     4        https://bugs.webkit.org/show_bug.cgi?id=152465
     5
     6        Caused crashes on Mac WK1 bots (Requested by youenn on
     7        #webkit).
     8
     9        Reverted changesets:
     10
     11        "[Streams API] Expose ReadableStream and relatives to Worker"
     12        https://bugs.webkit.org/show_bug.cgi?id=152066
     13        http://trac.webkit.org/changeset/194033
     14
     15        "[Streams API] imported/w3c/web-platform-tests/streams-api
     16        /readable-streams/cancel.html has a flaky test"
     17        https://bugs.webkit.org/show_bug.cgi?id=152065
     18        http://trac.webkit.org/changeset/194267
     19
    1202015-12-18  Xabier Rodriguez Calvar  <calvaris@igalia.com>
    221

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/README.txt

    r194267 r194319  
    44automatic.
    55
    6 Current version: https://github.com/whatwg/streams/tree/f7cb0eac03e6a6d045d6e8c09df1f9f8a264fdef/reference-implementation/web-platform-tests.
     6Current version: https://github.com/whatwg/streams/tree/18ed463e50c189c0198e2336dfbd10b17f379081/reference-implementation/web-platform-tests

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/byte-length-queuing-strategy-expected.txt

    r194033 r194319  
    99FAIL Load byte-length-queuing-strategy.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    1010FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    11 PASS Can construct a ByteLengthQueuingStrategy with a valid high water mark
    12 PASS Can construct a ByteLengthQueuingStrategy with any value as its high water mark
    13 PASS ByteLengthQueuingStrategy constructor behaves as expected with strange arguments
    14 PASS ByteLengthQueuingStrategy size behaves as expected with strange arguments
    15 PASS ByteLengthQueuingStrategy.prototype.size should work generically on its this and its arguments
    16 PASS ByteLengthQueuingStrategy instances have the correct properties
    17 PASS ByteLengthQueuingStrategy's highWaterMark property can be set to anything
     11FAIL Can construct a ByteLengthQueuingStrategy with a valid high water mark Can't find variable: ByteLengthQueuingStrategy
     12FAIL Can construct a ByteLengthQueuingStrategy with any value as its high water mark Can't find variable: ByteLengthQueuingStrategy
     13FAIL ByteLengthQueuingStrategy constructor behaves as expected with strange arguments assert_throws: construction fails with undefined function "() => new ByteLengthQueuingStrategy()" threw object "ReferenceError: Can't find variable: ByteLengthQueuingStr..." ("ReferenceError") expected object "[object Object]" ("TypeError")
     14FAIL ByteLengthQueuingStrategy size behaves as expected with strange arguments assert_throws: size fails with undefined function "() => ByteLengthQueuingStrategy.prototype.size()" threw object "ReferenceError: Can't find variable: ByteLengthQueuingStr..." ("ReferenceError") expected object "[object Object]" ("TypeError")
     15FAIL ByteLengthQueuingStrategy.prototype.size should work generically on its this and its arguments Can't find variable: ByteLengthQueuingStrategy
     16FAIL ByteLengthQueuingStrategy instances have the correct properties Can't find variable: ByteLengthQueuingStrategy
     17FAIL ByteLengthQueuingStrategy's highWaterMark property can be set to anything Can't find variable: ByteLengthQueuingStrategy
    1818

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/count-queuing-strategy-expected.txt

    r194033 r194319  
    99FAIL Load count-queuing-strategy.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    1010FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    11 PASS Can construct a CountQueuingStrategy with a valid high water mark
    12 PASS Can construct a CountQueuingStrategy with any value as its high water mark
    13 PASS CountQueuingStrategy constructor behaves as expected with strange arguments
    14 PASS CountQueuingStrategy.prototype.size should work generically on its this and its arguments
    15 PASS CountQueuingStrategy size behaves as expected with strange arguments
    16 PASS CountQueuingStrategy instances have the correct properties
    17 PASS CountQueuingStrategy's highWaterMark property can be set to anything
     11FAIL Can construct a CountQueuingStrategy with a valid high water mark Can't find variable: CountQueuingStrategy
     12FAIL Can construct a CountQueuingStrategy with any value as its high water mark Can't find variable: CountQueuingStrategy
     13FAIL CountQueuingStrategy constructor behaves as expected with strange arguments assert_throws: construction fails with undefined function "() => new CountQueuingStrategy()" threw object "ReferenceError: Can't find variable: CountQueuingStrategy" ("ReferenceError") expected object "[object Object]" ("TypeError")
     14FAIL CountQueuingStrategy.prototype.size should work generically on its this and its arguments Can't find variable: CountQueuingStrategy
     15FAIL CountQueuingStrategy size behaves as expected with strange arguments Can't find variable: CountQueuingStrategy
     16FAIL CountQueuingStrategy instances have the correct properties Can't find variable: CountQueuingStrategy
     17FAIL CountQueuingStrategy's highWaterMark property can be set to anything Can't find variable: CountQueuingStrategy
    1818

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies-expected.txt

    r194033 r194319  
    77FAIL Load bad-strategies.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    88FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    9 PASS Readable stream: throwing strategy.size getter
    10 PASS Readable stream: throwing strategy.size method
    11 PASS Readable stream: throwing strategy.highWaterMark getter
    12 PASS Readable stream: invalid strategy.highWaterMark
    13 PASS Readable stream: invalid strategy.size return value
     9FAIL Readable stream: throwing strategy.size getter assert_throws: construction should re-throw the error function "() => {
     10    new ReadableStream({}, {
     11      get size() {
     12 ..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
     13FAIL Readable stream: throwing strategy.size method Can't find variable: ReadableStream
     14FAIL Readable stream: throwing strategy.highWaterMark getter assert_throws: construction should re-throw the error function "() => {
     15    new ReadableStream({}, {
     16      size() {
     17     ..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
     18FAIL Readable stream: invalid strategy.highWaterMark assert_throws: construction should throw a RangeError for -1 function "() => {
     19      new ReadableStream({}, {
     20        size() {
     21 ..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "RangeError" ("RangeError")
     22FAIL Readable stream: invalid strategy.size return value Can't find variable: ReadableStream
    1423

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-underlying-sources-expected.txt

    r194033 r194319  
    2323FAIL Load bad-underlying-sources.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    2424FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    25 PASS Underlying source start: throwing getter
    26 PASS Underlying source start: throwing method
    27 PASS Underlying source: throwing pull getter (initial pull)
    28 PASS Underlying source: throwing pull method (initial pull)
    29 PASS Underlying source pull: throwing getter (second pull)
    30 PASS Underlying source pull: throwing method (second pull)
    31 PASS Underlying source cancel: throwing getter
    32 PASS Underlying source cancel: throwing method
    33 PASS Underlying source: calling enqueue on an empty canceled stream should not throw
    34 PASS Underlying source: calling enqueue on a non-empty canceled stream should not throw
    35 PASS Underlying source: calling enqueue on a closed stream should throw
    36 PASS Underlying source: calling enqueue on an errored stream should throw
    37 PASS Underlying source: calling close twice on an empty stream should throw the second time
    38 PASS Underlying source: calling close twice on a non-empty stream should throw the second time
    39 PASS Underlying source: calling close on an empty canceled stream should not throw
    40 PASS Underlying source: calling close on a non-empty canceled stream should not throw
    41 PASS Underlying source: calling close after error should throw
    42 PASS Underlying source: calling error twice should throw the second time
    43 PASS Underlying source: calling error after close should throw
    44 PASS Underlying source: calling error and returning a rejected promise from start should cause the stream to error with the first error
    45 PASS Underlying source: calling error and returning a rejected promise from pull should cause the stream to error with the first error
     25FAIL Underlying source start: throwing getter assert_throws: constructing the stream should re-throw the error function "() => {
     26    new ReadableStream({
     27      get start() {
     28    ..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
     29FAIL Underlying source start: throwing method assert_throws: constructing the stream should re-throw the error function "() => {
     30    new ReadableStream({
     31      start() {
     32        ..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
     33FAIL Underlying source: throwing pull getter (initial pull) Can't find variable: ReadableStream
     34FAIL Underlying source: throwing pull method (initial pull) Can't find variable: ReadableStream
     35FAIL Underlying source pull: throwing getter (second pull) Can't find variable: ReadableStream
     36FAIL Underlying source pull: throwing method (second pull) Can't find variable: ReadableStream
     37FAIL Underlying source cancel: throwing getter Can't find variable: ReadableStream
     38FAIL Underlying source cancel: throwing method Can't find variable: ReadableStream
     39FAIL Underlying source: calling enqueue on an empty canceled stream should not throw Can't find variable: ReadableStream
     40FAIL Underlying source: calling enqueue on a non-empty canceled stream should not throw Can't find variable: ReadableStream
     41FAIL Underlying source: calling enqueue on a closed stream should throw Can't find variable: ReadableStream
     42FAIL Underlying source: calling enqueue on an errored stream should throw Can't find variable: ReadableStream
     43FAIL Underlying source: calling close twice on an empty stream should throw the second time Can't find variable: ReadableStream
     44FAIL Underlying source: calling close twice on a non-empty stream should throw the second time Can't find variable: ReadableStream
     45FAIL Underlying source: calling close on an empty canceled stream should not throw Can't find variable: ReadableStream
     46FAIL Underlying source: calling close on a non-empty canceled stream should not throw Can't find variable: ReadableStream
     47FAIL Underlying source: calling close after error should throw Can't find variable: ReadableStream
     48FAIL Underlying source: calling error twice should throw the second time Can't find variable: ReadableStream
     49FAIL Underlying source: calling error after close should throw Can't find variable: ReadableStream
     50FAIL Underlying source: calling error and returning a rejected promise from start should cause the stream to error with the first error Can't find variable: ReadableStream
     51FAIL Underlying source: calling error and returning a rejected promise from pull should cause the stream to error with the first error Can't find variable: ReadableStream
    4652

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/brand-checks-expected.txt

    r194033 r194319  
    1717FAIL Load brand-checks.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    1818FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    19 PASS Can get the ReadableStreamReader constructor indirectly
    20 PASS Can get the ReadableStreamController constructor indirectly
    21 PASS ReadableStream.prototype.cancel enforces a brand check
    22 PASS ReadableStream.prototype.getReader enforces a brand check
    23 PASS ReadableStream.prototype.tee enforces a brand check
     19FAIL Can get the ReadableStreamReader constructor indirectly Can't find variable: ReadableStream
     20FAIL Can get the ReadableStreamController constructor indirectly Can't find variable: ReadableStream
     21FAIL ReadableStream.prototype.cancel enforces a brand check Can't find variable: ReadableStream
     22FAIL ReadableStream.prototype.getReader enforces a brand check Can't find variable: ReadableStream
     23FAIL ReadableStream.prototype.tee enforces a brand check Can't find variable: ReadableStream
    2424PASS ReadableStreamReader enforces a brand check on its argument
    25 PASS ReadableStreamReader.prototype.closed enforces a brand check
    26 PASS ReadableStreamReader.prototype.cancel enforces a brand check
    27 PASS ReadableStreamReader.prototype.read enforces a brand check
    28 PASS ReadableStreamReader.prototype.releaseLock enforces a brand check
     25FAIL ReadableStreamReader.prototype.closed enforces a brand check undefined is not an object (evaluating 'ReadableStreamReader.prototype')
     26FAIL ReadableStreamReader.prototype.cancel enforces a brand check undefined is not an object (evaluating 'ReadableStreamReader.prototype')
     27FAIL ReadableStreamReader.prototype.read enforces a brand check undefined is not an object (evaluating 'ReadableStreamReader.prototype')
     28FAIL ReadableStreamReader.prototype.releaseLock enforces a brand check undefined is not an object (evaluating 'ReadableStreamReader.prototype')
    2929PASS ReadableStreamController enforces a brand check on its argument
    30 PASS ReadableStreamController can't be given a fully-constructed ReadableStream
    31 PASS ReadableStreamController.prototype.close enforces a brand check
    32 PASS ReadableStreamController.prototype.enqueue enforces a brand check
    33 PASS ReadableStreamController.prototype.error enforces a brand check
     30FAIL ReadableStreamController can't be given a fully-constructed ReadableStream assert_throws: Constructing a ReadableStreamController should throw function "() => new ReadableStreamController(realReadableStream())" threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "TypeError" ("TypeError")
     31FAIL ReadableStreamController.prototype.close enforces a brand check undefined is not an object (evaluating 'ReadableStreamController.prototype')
     32FAIL ReadableStreamController.prototype.enqueue enforces a brand check undefined is not an object (evaluating 'ReadableStreamController.prototype')
     33FAIL ReadableStreamController.prototype.error enforces a brand check undefined is not an object (evaluating 'ReadableStreamController.prototype')
    3434

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/cancel-expected.txt

    r194267 r194319  
    11
    2 PASS ReadableStream cancellation: integration test on an infinite stream derived from a random push source
     2FAIL ReadableStream cancellation: integration test on an infinite stream derived from a random push source promise_test: Unhandled rejection with value: object "Error: forced error"
    33PASS ReadableStream cancellation: cancel(reason) should pass through the given reason to the underlying source
    44PASS ReadableStream cancellation: cancel() on a locked stream should fail and not call the underlying source cancel
    … …  
    1212FAIL Load cancel.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    1313FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    14 PASS ReadableStream cancellation: integration test on an infinite stream derived from a random push source
    15 PASS ReadableStream cancellation: cancel(reason) should pass through the given reason to the underlying source
    16 PASS ReadableStream cancellation: cancel() on a locked stream should fail and not call the underlying source cancel
    17 PASS ReadableStream cancellation: should fulfill promise when cancel callback went fine
    18 PASS ReadableStream cancellation: returning a value from the underlying source's cancel should not affect the fulfillment value of the promise returned by the stream's cancel
    19 PASS ReadableStream cancellation: should reject promise when cancel callback raises an exception
    20 PASS ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should fulfill when that one does (1)
    21 PASS ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should fulfill when that one does (2)
    22 PASS ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should reject when that one does
    23 PASS ReadableStream cancellation: cancelling before start finishes should prevent pull() from being called
     14FAIL ReadableStream cancellation: integration test on an infinite stream derived from a random push source promise_test: Unhandled rejection with value: object "Error: forced error"
     15FAIL ReadableStream cancellation: cancel(reason) should pass through the given reason to the underlying source Can't find variable: ReadableStream
     16FAIL ReadableStream cancellation: cancel() on a locked stream should fail and not call the underlying source cancel Can't find variable: ReadableStream
     17FAIL ReadableStream cancellation: should fulfill promise when cancel callback went fine Can't find variable: ReadableStream
     18FAIL ReadableStream cancellation: returning a value from the underlying source's cancel should not affect the fulfillment value of the promise returned by the stream's cancel Can't find variable: ReadableStream
     19FAIL ReadableStream cancellation: should reject promise when cancel callback raises an exception Can't find variable: ReadableStream
     20FAIL ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should fulfill when that one does (1) Can't find variable: ReadableStream
     21FAIL ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should fulfill when that one does (2) Can't find variable: ReadableStream
     22FAIL ReadableStream cancellation: if the underlying source's cancel method returns a promise, the promise returned by the stream's cancel should reject when that one does Can't find variable: ReadableStream
     23FAIL ReadableStream cancellation: cancelling before start finishes should prevent pull() from being called Can't find variable: ReadableStream
    2424

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.js

    r194267 r194319  
    88
    99promise_test(() => {
     10
     11  // WebKit edit. We force a failure in this tests for now because it is flaky.
     12  return Promise.reject(new Error("forced error"));
    1013
    1114  const randomSource = new RandomPushSource();
    … …  
    4043  // We call delay multiple times to avoid cancelling too early for the
    4144  // source to enqueue at least one chunk.
    42   const cancel = delay(5).then(() => delay(5)).then(() => delay(5)).then(() => {
    43     let cancelPromise = reader.cancel();
    44     assert_false(cancellationFinished, 'cancellation in source should happen later');
    45     return cancelPromise;
    46   })
     45  const cancel = delay(5).then(() => delay(5)).then(() => delay(5)).then(() => reader.cancel());
    4746
    4847  return readableStreamToArray(rs, reader).then(chunks => {
    … …  
    5150      assert_equals(chunks[i].length, 128, 'chunk ' + i + ' should have 128 bytes');
    5251    }
     52    assert_false(cancellationFinished, 'it did not wait for the cancellation process to finish before closing');
    5353    return cancel;
    5454  }).then(() => {

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration-expected.txt

    r194033 r194319  
    66FAIL Load count-queuing-strategy-integration.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    77FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    8 PASS Can construct a readable stream with a valid CountQueuingStrategy
    9 PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 0)
    10 PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 1)
    11 PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 4)
     8FAIL Can construct a readable stream with a valid CountQueuingStrategy Can't find variable: ReadableStream
     9FAIL Correctly governs a ReadableStreamController's desiredSize property (HWM = 0) Can't find variable: ReadableStream
     10FAIL Correctly governs a ReadableStreamController's desiredSize property (HWM = 1) Can't find variable: ReadableStream
     11FAIL Correctly governs a ReadableStreamController's desiredSize property (HWM = 4) Can't find variable: ReadableStream
    1212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt

    r194033 r194319  
    66FAIL Load garbage-collection.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    77FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    8 PASS ReadableStreamController methods should continue working properly when scripts lose their reference to the readable stream
    9 PASS ReadableStream closed promise should fulfill even if the stream and reader JS references are lost
    10 PASS ReadableStream closed promise should reject even if stream and reader JS references are lost
    11 PASS Garbage-collecting a ReadableStreamReader should not unlock its stream
     8FAIL ReadableStreamController methods should continue working properly when scripts lose their reference to the readable stream Can't find variable: ReadableStream
     9FAIL ReadableStream closed promise should fulfill even if the stream and reader JS references are lost Can't find variable: ReadableStream
     10FAIL ReadableStream closed promise should reject even if stream and reader JS references are lost Can't find variable: ReadableStream
     11FAIL Garbage-collecting a ReadableStreamReader should not unlock its stream Can't find variable: ReadableStream
    1212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/general-expected.txt

    r194033 r194319  
    3535FAIL Load general.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    3636FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    37 PASS ReadableStream can be constructed with no errors
    38 PASS ReadableStream can't be constructed with garbage
    39 FAIL ReadableStream instances should have the correct list of properties assert_false: method should be non-enumerable expected false got true
    40 PASS ReadableStream constructor should throw for non-function start arguments
    41 PASS ReadableStream constructor can get initial garbage as cancel argument
    42 PASS ReadableStream constructor can get initial garbage as pull argument
    43 FAIL ReadableStream start should be called with the proper parameters assert_false: close should be non-enumerable expected false got true
    44 PASS ReadableStream start controller parameter should be extensible
    45 PASS ReadableStream should be able to call start method within prototype chain of its source
    46 PASS ReadableStream start should be able to return a promise
    47 PASS ReadableStream start should be able to return a promise and reject it
    48 PASS ReadableStream should be able to enqueue different objects.
    49 PASS ReadableStream: if pull rejects, it should error the stream
    50 PASS ReadableStream: should only call pull once upon starting the stream
    51 PASS ReadableStream: should call pull when trying to read from a started, empty stream
    52 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills
    53 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills
    54 PASS ReadableStream: should call pull in reaction to read()ing the last chunk, if not draining
    55 PASS ReadableStream: should not call pull() in reaction to read()ing the last chunk, if draining
    56 PASS ReadableStream: should not call pull until the previous pull call's promise fulfills
    57 PASS ReadableStream: should pull after start, and after every read
    58 PASS ReadableStream: should not call pull after start if the stream is now closed
    59 PASS ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows
    60 PASS ReadableStream pull should be able to close a stream.
    61 PASS ReadableStream: enqueue should throw when the stream is readable but draining
    62 PASS ReadableStream: enqueue should throw when the stream is closed
    63 PASS ReadableStream: enqueue should throw the stored error when the stream is errored
    64 PASS ReadableStream: should call underlying source methods as methods
    65 PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue
    66 PASS ReadableStream strategies: the default strategy should continue giving desiredSize of 1 if the chunks are read immediately
    67 PASS ReadableStream integration test: adapting a random push source
    68 PASS ReadableStream integration test: adapting a sync pull source
    69 PASS ReadableStream integration test: adapting an async pull source
     37FAIL ReadableStream can be constructed with no errors Can't find variable: ReadableStream
     38FAIL ReadableStream can't be constructed with garbage assert_throws: constructor should throw when the source is null function "() => new ReadableStream(null)" threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "TypeError" ("TypeError")
     39FAIL ReadableStream instances should have the correct list of properties Can't find variable: ReadableStream
     40FAIL ReadableStream constructor should throw for non-function start arguments assert_throws: constructor should throw when start is not a function function "() => {
     41    new ReadableStream({ start: 'potato' });
     42  }" threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "TypeError" ("TypeError")
     43FAIL ReadableStream constructor can get initial garbage as cancel argument Can't find variable: ReadableStream
     44FAIL ReadableStream constructor can get initial garbage as pull argument Can't find variable: ReadableStream
     45FAIL ReadableStream start should be called with the proper parameters Can't find variable: ReadableStream
     46FAIL ReadableStream start controller parameter should be extensible Can't find variable: ReadableStream
     47FAIL ReadableStream should be able to call start method within prototype chain of its source Can't find variable: ReadableStream
     48FAIL ReadableStream start should be able to return a promise Can't find variable: ReadableStream
     49FAIL ReadableStream start should be able to return a promise and reject it Can't find variable: ReadableStream
     50FAIL ReadableStream should be able to enqueue different objects. Can't find variable: ReadableStream
     51FAIL ReadableStream: if pull rejects, it should error the stream Can't find variable: ReadableStream
     52FAIL ReadableStream: should only call pull once upon starting the stream Can't find variable: ReadableStream
     53FAIL ReadableStream: should call pull when trying to read from a started, empty stream Can't find variable: ReadableStream
     54FAIL ReadableStream: should only call pull once on a non-empty stream read from before start fulfills Can't find variable: ReadableStream
     55FAIL ReadableStream: should only call pull once on a non-empty stream read from after start fulfills Can't find variable: ReadableStream
     56FAIL ReadableStream: should call pull in reaction to read()ing the last chunk, if not draining Can't find variable: ReadableStream
     57FAIL ReadableStream: should not call pull() in reaction to read()ing the last chunk, if draining Can't find variable: ReadableStream
     58FAIL ReadableStream: should not call pull until the previous pull call's promise fulfills Can't find variable: ReadableStream
     59FAIL ReadableStream: should pull after start, and after every read Can't find variable: ReadableStream
     60FAIL ReadableStream: should not call pull after start if the stream is now closed Can't find variable: ReadableStream
     61FAIL ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows Can't find variable: ReadableStream
     62FAIL ReadableStream pull should be able to close a stream. Can't find variable: ReadableStream
     63FAIL ReadableStream: enqueue should throw when the stream is readable but draining Can't find variable: ReadableStream
     64FAIL ReadableStream: enqueue should throw when the stream is closed Can't find variable: ReadableStream
     65FAIL ReadableStream: enqueue should throw the stored error when the stream is errored Can't find variable: ReadableStream
     66FAIL ReadableStream: should call underlying source methods as methods Can't find variable: ReadableStream
     67FAIL ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue Can't find variable: ReadableStream
     68FAIL ReadableStream strategies: the default strategy should continue giving desiredSize of 1 if the chunks are read immediately Can't find variable: ReadableStream
     69FAIL ReadableStream integration test: adapting a random push source Can't find variable: ReadableStream
     70FAIL ReadableStream integration test: adapting a sync pull source Can't find variable: ReadableStream
     71FAIL ReadableStream integration test: adapting an async pull source Can't find variable: ReadableStream
    7072

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt

    r194033 r194319  
    77FAIL Load pipe-through.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    88FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    9 PASS ReadableStream.prototype.pipeThrough should work generically on its this and its arguments
    10 PASS ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object
    11 PASS ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method
    12 PASS ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable
    13 PASS ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options
     9FAIL ReadableStream.prototype.pipeThrough should work generically on its this and its arguments Can't find variable: ReadableStream
     10FAIL ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object Can't find variable: ReadableStream
     11FAIL ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method Can't find variable: ReadableStream
     12FAIL ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable assert_throws: pipeThrough should rethrow the error thrown by pipeTo function "() => ReadableStream.prototype.pipeThrough.call(throwingP..." threw object "ReferenceError: Can't find variable: ReadableStream" ("ReferenceError") expected object "Error: potato" ("Error")
     13FAIL ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options Can't find variable: ReadableStream
    1414

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/readable-stream-reader-expected.txt

    r194033 r194319  
    2828FAIL Load readable-stream-reader.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    2929FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    30 PASS Can get the ReadableStreamReader constructor indirectly
     30FAIL Can get the ReadableStreamReader constructor indirectly Can't find variable: ReadableStream
    3131PASS ReadableStreamReader constructor should get a ReadableStream object as argument
    32 FAIL ReadableStreamReader instances should have the correct list of properties assert_equals: method should be non-enumerable expected false but got true
    33 PASS ReadableStreamReader closed should always return the same promise object
    34 PASS Constructing a ReadableStreamReader directly should fail if the stream is already locked (via direct construction)
    35 PASS Getting a ReadableStreamReader via getReader should fail if the stream is already locked (via direct construction)
    36 PASS Constructing a ReadableStreamReader directly should fail if the stream is already locked (via getReader)
    37 PASS Getting a ReadableStreamReader via getReader should fail if the stream is already locked (via getReader)
    38 PASS Constructing a ReadableStreamReader directly should be OK if the stream is closed
    39 PASS Constructing a ReadableStreamReader directly should be OK if the stream is errored
    40 PASS Reading from a reader for an empty stream will wait until a chunk is available
    41 PASS cancel() on a reader does not release the reader
    42 PASS closed should be fulfilled after stream is closed (.closed access before acquiring)
    43 PASS closed should be rejected after reader releases its lock (multiple stream locks)
    44 PASS Multiple readers can access the stream in sequence
    45 PASS Cannot use an already-released reader to unlock a stream again
    46 PASS cancel() on a released reader is a no-op and does not pass through
    47 PASS Getting a second reader after erroring the stream and releasing the reader should succeed
    48 PASS ReadableStreamReader closed promise should be rejected with undefined if that is the error
    49 PASS ReadableStreamReader: if start rejects with no parameter, it should error the stream with an undefined error
    50 PASS Erroring a ReadableStream after checking closed should reject ReadableStreamReader closed promise
    51 PASS Erroring a ReadableStream before checking closed should reject ReadableStreamReader closed promise
    52 PASS Reading twice on a stream that gets closed
    53 PASS Reading twice on a closed stream
    54 PASS Reading twice on an errored stream
    55 PASS Reading twice on a stream that gets errored
     32FAIL ReadableStreamReader instances should have the correct list of properties Can't find variable: ReadableStream
     33FAIL ReadableStreamReader closed should always return the same promise object Can't find variable: ReadableStream
     34FAIL Constructing a ReadableStreamReader directly should fail if the stream is already locked (via direct construction) Can't find variable: ReadableStream
     35FAIL Getting a ReadableStreamReader via getReader should fail if the stream is already locked (via direct construction) Can't find variable: ReadableStream
     36FAIL Constructing a ReadableStreamReader directly should fail if the stream is already locked (via getReader) Can't find variable: ReadableStream
     37FAIL Getting a ReadableStreamReader via getReader should fail if the stream is already locked (via getReader) Can't find variable: ReadableStream
     38FAIL Constructing a ReadableStreamReader directly should be OK if the stream is closed Can't find variable: ReadableStream
     39FAIL Constructing a ReadableStreamReader directly should be OK if the stream is errored Can't find variable: ReadableStream
     40FAIL Reading from a reader for an empty stream will wait until a chunk is available Can't find variable: ReadableStream
     41FAIL cancel() on a reader does not release the reader Can't find variable: ReadableStream
     42FAIL closed should be fulfilled after stream is closed (.closed access before acquiring) Can't find variable: ReadableStream
     43FAIL closed should be rejected after reader releases its lock (multiple stream locks) Can't find variable: ReadableStream
     44FAIL Multiple readers can access the stream in sequence Can't find variable: ReadableStream
     45FAIL Cannot use an already-released reader to unlock a stream again Can't find variable: ReadableStream
     46FAIL cancel() on a released reader is a no-op and does not pass through Can't find variable: ReadableStream
     47FAIL Getting a second reader after erroring the stream and releasing the reader should succeed Can't find variable: ReadableStream
     48FAIL ReadableStreamReader closed promise should be rejected with undefined if that is the error Can't find variable: ReadableStream
     49FAIL ReadableStreamReader: if start rejects with no parameter, it should error the stream with an undefined error Can't find variable: ReadableStream
     50FAIL Erroring a ReadableStream after checking closed should reject ReadableStreamReader closed promise Can't find variable: ReadableStream
     51FAIL Erroring a ReadableStream before checking closed should reject ReadableStreamReader closed promise Can't find variable: ReadableStream
     52FAIL Reading twice on a stream that gets closed Can't find variable: ReadableStream
     53FAIL Reading twice on a closed stream Can't find variable: ReadableStream
     54FAIL Reading twice on an errored stream Can't find variable: ReadableStream
     55FAIL Reading twice on a stream that gets errored Can't find variable: ReadableStream
    5656

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/tee-expected.txt

    r194033 r194319  
    1212FAIL Load tee.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
    1313FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    14 PASS ReadableStream teeing: rs.tee() returns an array of two ReadableStreams
    15 PASS ReadableStream teeing: should be able to read one branch to the end without affecting the other
    16 PASS ReadableStream teeing: values should be equal across each branch
    17 PASS ReadableStream teeing: errors in the source should propagate to both branches
    18 PASS ReadableStream teeing: canceling branch1 should not impact branch2
    19 PASS ReadableStream teeing: canceling branch2 should not impact branch2
    20 PASS ReadableStream teeing: canceling both branches should aggregate the cancel reasons into an array
    21 PASS ReadableStream teeing: failing to cancel the original stream should cause cancel() to reject on branches
    22 PASS ReadableStream teeing: closing the original should immediately close the branches
    23 PASS ReadableStream teeing: erroring the original should immediately error the branches
     14FAIL ReadableStream teeing: rs.tee() returns an array of two ReadableStreams Can't find variable: ReadableStream
     15FAIL ReadableStream teeing: should be able to read one branch to the end without affecting the other Can't find variable: ReadableStream
     16FAIL ReadableStream teeing: values should be equal across each branch Can't find variable: ReadableStream
     17FAIL ReadableStream teeing: errors in the source should propagate to both branches Can't find variable: ReadableStream
     18FAIL ReadableStream teeing: canceling branch1 should not impact branch2 Can't find variable: ReadableStream
     19FAIL ReadableStream teeing: canceling branch2 should not impact branch2 Can't find variable: ReadableStream
     20FAIL ReadableStream teeing: canceling both branches should aggregate the cancel reasons into an array Can't find variable: ReadableStream
     21FAIL ReadableStream teeing: failing to cancel the original stream should cause cancel() to reject on branches Can't find variable: ReadableStream
     22FAIL ReadableStream teeing: closing the original should immediately close the branches Can't find variable: ReadableStream
     23FAIL ReadableStream teeing: erroring the original should immediately error the branches Can't find variable: ReadableStream
    2424

  • trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/templated-expected.txt

    r194033 r194319  
    8888FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
    8989PASS Running templatedRSEmpty with ReadableStream (empty)
    90 PASS instances have the correct methods and properties
     90FAIL instances have the correct methods and properties Can't find variable: ReadableStream
    9191PASS Running templatedRSEmptyReader with ReadableStream (empty) reader
    92 PASS instances have the correct methods and properties
    93 PASS locked should be true
    94 PASS read() should never settle
    95 PASS two read()s should both never settle
    96 PASS read() should return distinct promises each time
    97 PASS getReader() again on the stream should fail
    98 PASS releasing the lock with pending read requests should throw but the read requests should stay pending
    99 PASS releasing the lock should cause further read() calls to reject with a TypeError
    100 PASS releasing the lock should cause closed calls to reject with a TypeError
    101 PASS releasing the lock should cause locked to become false
    102 PASS canceling via the reader should cause the reader to act closed
    103 PASS canceling via the stream should fail
     92FAIL instances have the correct methods and properties Can't find variable: ReadableStream
     93FAIL locked should be true Can't find variable: ReadableStream
     94FAIL read() should never settle Can't find variable: ReadableStream
     95FAIL two read()s should both never settle Can't find variable: ReadableStream
     96FAIL read() should return distinct promises each time Can't find variable: ReadableStream
     97FAIL getReader() again on the stream should fail Can't find variable: ReadableStream
     98FAIL releasing the lock with pending read requests should throw but the read requests should stay pending Can't find variable: ReadableStream
     99FAIL releasing the lock should cause further read() calls to reject with a TypeError Can't find variable: ReadableStream
     100FAIL releasing the lock should cause closed calls to reject with a TypeError Can't find variable: ReadableStream
     101FAIL releasing the lock should cause locked to become false Can't find variable: ReadableStream
     102FAIL canceling via the reader should cause the reader to act closed Can't find variable: ReadableStream
     103FAIL canceling via the stream should fail Can't find variable: ReadableStream
    104104PASS Running templatedRSClosed with ReadableStream (closed via call in start)
    105 PASS cancel() should return a distinct fulfilled promise each time
    106 PASS locked should be false
    107 PASS getReader() should be OK
    108 PASS should be able to acquire multiple readers if they are released in succession
    109 PASS should not be able to acquire a second reader if we don't release the first one
     105FAIL cancel() should return a distinct fulfilled promise each time Can't find variable: ReadableStream
     106FAIL locked should be false Can't find variable: ReadableStream
     107FAIL getReader() should be OK Can't find variable: ReadableStream
     108FAIL should be able to acquire multiple readers if they are released in succession Can't find variable: ReadableStream
     109FAIL should not be able to acquire a second reader if we don't release the first one Can't find variable: ReadableStream
    110110PASS Running templatedRSClosedReader with ReadableStream reader (closed before getting reader)
    111 PASS read() should fulfill with { value: undefined, done: true }
    112 PASS read() multiple times should fulfill with { value: undefined, done: true }
    113 PASS read() should work when used within another read() fulfill callback
    114 PASS closed should fulfill with undefined
    115 PASS releasing the lock should cause closed to reject and change identity
    116 PASS cancel() should return a distinct fulfilled promise each time
     111FAIL read() should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     112FAIL read() multiple times should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     113FAIL read() should work when used within another read() fulfill callback Can't find variable: ReadableStream
     114FAIL closed should fulfill with undefined Can't find variable: ReadableStream
     115FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     116FAIL cancel() should return a distinct fulfilled promise each time Can't find variable: ReadableStream
    117117PASS Running templatedRSClosedReader with ReadableStream reader (closed after getting reader)
    118 PASS read() should fulfill with { value: undefined, done: true }
    119 PASS read() multiple times should fulfill with { value: undefined, done: true }
    120 PASS read() should work when used within another read() fulfill callback
    121 PASS closed should fulfill with undefined
    122 PASS releasing the lock should cause closed to reject and change identity
    123 PASS cancel() should return a distinct fulfilled promise each time
     118FAIL read() should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     119FAIL read() multiple times should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     120FAIL read() should work when used within another read() fulfill callback Can't find variable: ReadableStream
     121FAIL closed should fulfill with undefined Can't find variable: ReadableStream
     122FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     123FAIL cancel() should return a distinct fulfilled promise each time Can't find variable: ReadableStream
    124124PASS Running templatedRSClosed with ReadableStream (closed via cancel)
    125 PASS cancel() should return a distinct fulfilled promise each time
    126 PASS locked should be false
    127 PASS getReader() should be OK
    128 PASS should be able to acquire multiple readers if they are released in succession
    129 PASS should not be able to acquire a second reader if we don't release the first one
     125FAIL cancel() should return a distinct fulfilled promise each time Can't find variable: ReadableStream
     126FAIL locked should be false Can't find variable: ReadableStream
     127FAIL getReader() should be OK Can't find variable: ReadableStream
     128FAIL should be able to acquire multiple readers if they are released in succession Can't find variable: ReadableStream
     129FAIL should not be able to acquire a second reader if we don't release the first one Can't find variable: ReadableStream
    130130PASS Running templatedRSClosedReader with ReadableStream reader (closed via cancel after getting reader)
    131 PASS read() should fulfill with { value: undefined, done: true }
    132 PASS read() multiple times should fulfill with { value: undefined, done: true }
    133 PASS read() should work when used within another read() fulfill callback
    134 PASS closed should fulfill with undefined
    135 PASS releasing the lock should cause closed to reject and change identity
    136 PASS cancel() should return a distinct fulfilled promise each time
     131FAIL read() should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     132FAIL read() multiple times should fulfill with { value: undefined, done: true } Can't find variable: ReadableStream
     133FAIL read() should work when used within another read() fulfill callback Can't find variable: ReadableStream
     134FAIL closed should fulfill with undefined Can't find variable: ReadableStream
     135FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     136FAIL cancel() should return a distinct fulfilled promise each time Can't find variable: ReadableStream
    137137PASS Running templatedRSErrored with ReadableStream (errored via call in start)
    138 PASS getReader() should return a reader that acts errored
    139 PASS read() twice should give the error each time
    140 PASS locked should be false
     138FAIL getReader() should return a reader that acts errored Can't find variable: ReadableStream
     139FAIL read() twice should give the error each time Can't find variable: ReadableStream
     140FAIL locked should be false Can't find variable: ReadableStream
    141141PASS Running templatedRSErroredSyncOnly with ReadableStream (errored via call in start)
    142 PASS should be able to obtain a second reader, with the correct closed promise
    143 PASS should not be able to obtain additional readers if we don't release the first lock
    144 PASS cancel() should return a distinct rejected promise each time
    145 PASS reader cancel() should return a distinct rejected promise each time
     142FAIL should be able to obtain a second reader, with the correct closed promise Can't find variable: ReadableStream
     143FAIL should not be able to obtain additional readers if we don't release the first lock Can't find variable: ReadableStream
     144FAIL cancel() should return a distinct rejected promise each time Can't find variable: ReadableStream
     145FAIL reader cancel() should return a distinct rejected promise each time Can't find variable: ReadableStream
    146146PASS Running templatedRSErrored with ReadableStream (errored via returning a rejected promise in start)
    147 PASS getReader() should return a reader that acts errored
    148 PASS read() twice should give the error each time
    149 PASS locked should be false
     147FAIL getReader() should return a reader that acts errored Can't find variable: ReadableStream
     148FAIL read() twice should give the error each time Can't find variable: ReadableStream
     149FAIL locked should be false Can't find variable: ReadableStream
    150150PASS Running templatedRSErroredReader with ReadableStream (errored via returning a rejected promise in start) reader
    151 PASS closed should reject with the error
    152 PASS releasing the lock should cause closed to reject and change identity
    153 PASS read() should reject with the error
     151FAIL closed should reject with the error Can't find variable: ReadableStream
     152FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     153FAIL read() should reject with the error Can't find variable: ReadableStream
    154154PASS Running templatedRSErroredReader with ReadableStream reader (errored before getting reader)
    155 PASS closed should reject with the error
    156 PASS releasing the lock should cause closed to reject and change identity
    157 PASS read() should reject with the error
     155FAIL closed should reject with the error Can't find variable: ReadableStream
     156FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     157FAIL read() should reject with the error Can't find variable: ReadableStream
    158158PASS Running templatedRSErroredReader with ReadableStream reader (errored after getting reader)
    159 PASS closed should reject with the error
    160 PASS releasing the lock should cause closed to reject and change identity
    161 PASS read() should reject with the error
     159FAIL closed should reject with the error Can't find variable: ReadableStream
     160FAIL releasing the lock should cause closed to reject and change identity Can't find variable: ReadableStream
     161FAIL read() should reject with the error Can't find variable: ReadableStream
    162162PASS Running templatedRSTwoChunksOpenReader with ReadableStream (two chunks enqueued, still open) reader
    163 PASS calling read() twice without waiting will eventually give both chunks (sequential)
    164 PASS calling read() twice without waiting will eventually give both chunks (nested)
    165 PASS read() should return distinct promises each time
    166 PASS cancel() after a read() should still give that single read result
     163FAIL calling read() twice without waiting will eventually give both chunks (sequential) Can't find variable: ReadableStream
     164FAIL calling read() twice without waiting will eventually give both chunks (nested) Can't find variable: ReadableStream
     165FAIL read() should return distinct promises each time Can't find variable: ReadableStream
     166FAIL cancel() after a read() should still give that single read result Can't find variable: ReadableStream
    167167PASS Running templatedRSTwoChunksClosedReader with ReadableStream (two chunks enqueued, then closed) reader
    168 PASS third read(), without waiting, should give { value: undefined, done: true } (sequential)
    169 PASS third read(), without waiting, should give { value: undefined, done: true } (nested)
    170 PASS draining the stream via read() should cause the reader closed promise to fulfill, but locked stays true
    171 PASS releasing the lock after the stream is closed should cause locked to become false
    172 PASS releasing the lock should cause further read() calls to reject with a TypeError
    173 PASS reader's closed property always returns the same promise
     168FAIL third read(), without waiting, should give { value: undefined, done: true } (sequential) Can't find variable: ReadableStream
     169FAIL third read(), without waiting, should give { value: undefined, done: true } (nested) Can't find variable: ReadableStream
     170FAIL draining the stream via read() should cause the reader closed promise to fulfill, but locked stays true Can't find variable: ReadableStream
     171FAIL releasing the lock after the stream is closed should cause locked to become false Can't find variable: ReadableStream
     172FAIL releasing the lock should cause further read() calls to reject with a TypeError Can't find variable: ReadableStream
     173FAIL reader's closed property always returns the same promise Can't find variable: ReadableStream
    174174

  • trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

    r194033 r194319  
    1010PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Blob').enumerable is false
    1111PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Blob').configurable is true
    12 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').value is ByteLengthQueuingStrategy
    13 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').hasOwnProperty('get') is false
    14 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').hasOwnProperty('set') is false
    15 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').enumerable is false
    16 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').configurable is true
    17 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').value is CountQueuingStrategy
    18 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').hasOwnProperty('get') is false
    19 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').hasOwnProperty('set') is false
    20 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').enumerable is false
    21 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').configurable is true
    2212PASS [Worker] Object.getOwnPropertyDescriptor(global, 'DedicatedWorkerGlobalScope').value is DedicatedWorkerGlobalScope
    2313PASS [Worker] Object.getOwnPropertyDescriptor(global, 'DedicatedWorkerGlobalScope').hasOwnProperty('get') is false
    … …  
    5545PASS [Worker] Object.getOwnPropertyDescriptor(global, 'MessageEvent').enumerable is false
    5646PASS [Worker] Object.getOwnPropertyDescriptor(global, 'MessageEvent').configurable is true
    57 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').value is ReadableStream
    58 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').hasOwnProperty('get') is false
    59 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').hasOwnProperty('set') is false
    60 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    61 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    6247PASS [Worker] Object.getOwnPropertyDescriptor(global, 'URL').value is URL
    6348PASS [Worker] Object.getOwnPropertyDescriptor(global, 'URL').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

    r194033 r194319  
    1010PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Blob').enumerable is false
    1111PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Blob').configurable is true
    12 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').value is ByteLengthQueuingStrategy
    13 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').hasOwnProperty('get') is false
    14 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').hasOwnProperty('set') is false
    15 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').enumerable is false
    16 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ByteLengthQueuingStrategy').configurable is true
    17 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').value is CountQueuingStrategy
    18 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').hasOwnProperty('get') is false
    19 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').hasOwnProperty('set') is false
    20 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').enumerable is false
    21 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'CountQueuingStrategy').configurable is true
    2212PASS [Worker] Object.getOwnPropertyDescriptor(global, 'DedicatedWorkerGlobalScope').value is DedicatedWorkerGlobalScope
    2313PASS [Worker] Object.getOwnPropertyDescriptor(global, 'DedicatedWorkerGlobalScope').hasOwnProperty('get') is false
    … …  
    5545PASS [Worker] Object.getOwnPropertyDescriptor(global, 'MessageEvent').enumerable is false
    5646PASS [Worker] Object.getOwnPropertyDescriptor(global, 'MessageEvent').configurable is true
    57 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').value is ReadableStream
    58 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').hasOwnProperty('get') is false
    59 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').hasOwnProperty('set') is false
    60 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    61 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    6247PASS [Worker] Object.getOwnPropertyDescriptor(global, 'URL').value is URL
    6348PASS [Worker] Object.getOwnPropertyDescriptor(global, 'URL').hasOwnProperty('get') is false

  • trunk/Source/WebCore/CMakeLists.txt

    r194122 r194319  
    12571257    bindings/js/ScriptState.cpp
    12581258    bindings/js/SerializedScriptValue.cpp
    1259     bindings/js/WebCoreJSBuiltinInternals.cpp
    12601259    bindings/js/WebCoreJSBuiltins.cpp
    12611260    bindings/js/WebCoreTypedArrayController.cpp

  • trunk/Source/WebCore/ChangeLog

    r194318 r194319  
     12015-12-20  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r194033 and r194267.
     4        https://bugs.webkit.org/show_bug.cgi?id=152465
     5
     6        Caused crashes on Mac WK1 bots (Requested by youenn on
     7        #webkit).
     8
     9        Reverted changesets:
     10
     11        "[Streams API] Expose ReadableStream and relatives to Worker"
     12        https://bugs.webkit.org/show_bug.cgi?id=152066
     13        http://trac.webkit.org/changeset/194033
     14
     15        "[Streams API] imported/w3c/web-platform-tests/streams-api
     16        /readable-streams/cancel.html has a flaky test"
     17        https://bugs.webkit.org/show_bug.cgi?id=152065
     18        http://trac.webkit.org/changeset/194267
     19
    1202015-12-19  Dan Bernstein  <mitz@apple.com>
    221

  • trunk/Source/WebCore/Modules/streams/ByteLengthQueuingStrategy.idl

    r194033 r194319  
    3232    Constructor,
    3333    Conditional=STREAMS_API,
    34     GlobalContext=DOMWindow&WorkerGlobalScope,
    3534] interface ByteLengthQueuingStrategy {
    3635    double size();

  • trunk/Source/WebCore/Modules/streams/CountQueuingStrategy.idl

    r194033 r194319  
    3232    Constructor,
    3333    Conditional=STREAMS_API,
    34     GlobalContext=DOMWindow&WorkerGlobalScope,
    3534] interface CountQueuingStrategy {
    3635    double size();

  • trunk/Source/WebCore/Modules/streams/ReadableStream.idl

    r194033 r194319  
    3131    Conditional=STREAMS_API,
    3232    Constructor,
    33     GlobalContext=DOMWindow&WorkerGlobalScope,
    3433    JSBuiltin
    3534] interface ReadableStream {

  • trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl

    r194033 r194319  
    3131    Conditional=STREAMS_API,
    3232    CustomConstructor,
    33     GlobalContext=DOMWindow&WorkerGlobalScope,
    3433    JSBuiltin,
    3534    NoInterfaceObject

  • trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl

    r194033 r194319  
    3131    Conditional=STREAMS_API,
    3232    CustomConstructor,
    33     GlobalContext=DOMWindow&WorkerGlobalScope,
    3433    JSBuiltin,
    3534    NoInterfaceObject

  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

    r194033 r194319  
    1901619016    </ClCompile>
    1901719017    <ClCompile Include="..\bindings\js\WebCoreTypedArrayController.cpp">
    19018       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
    19019       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
    19020       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</ExcludedFromBuild>
    19021       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'">true</ExcludedFromBuild>
    19022       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
    19023       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|x64'">true</ExcludedFromBuild>
    19024       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
    19025       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
    19026       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</ExcludedFromBuild>
    19027       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</ExcludedFromBuild>
    19028       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
    19029       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
    19030     </ClCompile>
    19031     <ClCompile Include="..\bindings\js\WebCoreJSBuiltinInternals.cpp">
    1903219018      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
    1903319019      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r194156 r194319  
    14821482                40ECAE8116B8B68A00C36103 /* JSDOMError.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 40ECAE8016B8B68A00C36103 /* JSDOMError.cpp */; };
    14831483                410B7E721045FAB000D8224F /* JSMessageEventCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 410B7E711045FAB000D8224F /* JSMessageEventCustom.cpp */; };
    1484                 410D33241C19985000F7FDE2 /* WebCoreJSBuiltinInternals.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 410D33231C19984100F7FDE2 /* WebCoreJSBuiltinInternals.cpp */; };
    14851484                4123081B138C429700BCCFCA /* WebCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 93F19B1A08245E5A001E9ABC /* WebCore.framework */; };
    14861485                41230913138C42FF00BCCFCA /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F8216299029F4FB501000131 /* JavaScriptCore.framework */; };
    … …  
    88398838                40ECAE8016B8B68A00C36103 /* JSDOMError.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMError.cpp; sourceTree = "<group>"; };
    88408839                410B7E711045FAB000D8224F /* JSMessageEventCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSMessageEventCustom.cpp; sourceTree = "<group>"; };
    8841                 410D33231C19984100F7FDE2 /* WebCoreJSBuiltinInternals.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebCoreJSBuiltinInternals.cpp; sourceTree = "<group>"; };
    88428840                41189EF71AD8232800B90A0D /* ReadableStreamController.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ReadableStreamController.idl; sourceTree = "<group>"; };
    88438841                4127D5360F8AAB1D00E424F5 /* ScriptState.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScriptState.cpp; sourceTree = "<group>"; };
    … …  
    2197721975                                419BE7521BC7F3DB00E1C85B /* WebCoreBuiltinNames.h */,
    2197821976                                419BE7531BC7F3DB00E1C85B /* WebCoreJSBuiltinInternals.h */,
    21979                                 410D33231C19984100F7FDE2 /* WebCoreJSBuiltinInternals.cpp */,
    2198021977                                419BE7541BC7F3DB00E1C85B /* WebCoreJSBuiltins.cpp */,
    2198121978                                419BE7551BC7F3DB00E1C85B /* WebCoreJSBuiltins.h */,
    … …  
    3096230959                                D01A27AD10C9BFD800026A42 /* SpaceSplitString.cpp in Sources */,
    3096330960                                626CDE0E1140424C001E5A68 /* SpatialNavigation.cpp in Sources */,
    30964                                 410D33241C19985000F7FDE2 /* WebCoreJSBuiltinInternals.cpp in Sources */,
    3096530961                                AA2A5AD516A4861400975A25 /* SpeechSynthesis.cpp in Sources */,
    3096630962                                AA2A5AD316A4860D00975A25 /* SpeechSynthesisEvent.cpp in Sources */,

  • trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp

    r194033 r194319  
    3131#include "JSDOMWindow.h"
    3232#include "JSEventListener.h"
    33 #include "JSReadableStreamPrivateConstructors.h"
    3433#include "JSWorkerGlobalScope.h"
    35 #include "WebCoreJSClientData.h"
    3634#include "WorkerGlobalScope.h"
    3735
    … …  
    4745    , m_world(world)
    4846    , m_worldIsNormal(m_world->isNormal())
    49     , m_internalFunctions(vm)
    5047{
    5148    ASSERT(m_world);
    … …  
    5754}
    5855
    59 void JSDOMGlobalObject::addBuiltinGlobals(VM& vm)
    60 {
    61     m_internalFunctions.initialize(*this, vm);
    62 #if ENABLE(STREAMS_API)
    63     JSVMClientData& clientData = *static_cast<JSVMClientData*>(vm.clientData);
    64     GlobalPropertyInfo staticGlobals[] = {
    65         GlobalPropertyInfo(clientData.builtinNames().streamClosedPrivateName(), jsNumber(1), DontDelete | ReadOnly),
    66         GlobalPropertyInfo(clientData.builtinNames().streamClosingPrivateName(), jsNumber(2), DontDelete | ReadOnly),
    67         GlobalPropertyInfo(clientData.builtinNames().streamErroredPrivateName(), jsNumber(3), DontDelete | ReadOnly),
    68         GlobalPropertyInfo(clientData.builtinNames().streamReadablePrivateName(), jsNumber(4), DontDelete | ReadOnly),
    69         GlobalPropertyInfo(clientData.builtinNames().streamWaitingPrivateName(), jsNumber(5), DontDelete | ReadOnly),
    70         GlobalPropertyInfo(clientData.builtinNames().streamWritablePrivateName(), jsNumber(6), DontDelete | ReadOnly),
    71         GlobalPropertyInfo(clientData.builtinNames().ReadableStreamControllerPrivateName(), createReadableStreamControllerPrivateConstructor(vm, *this), DontDelete | ReadOnly),
    72         GlobalPropertyInfo(clientData.builtinNames().ReadableStreamReaderPrivateName(), createReadableStreamReaderPrivateConstructor(vm, *this), DontDelete | ReadOnly),
    73     };
    74     addStaticGlobals(staticGlobals, WTF_ARRAY_LENGTH(staticGlobals));
    75 #endif
    76 }
    77 
    7856void JSDOMGlobalObject::finishCreation(VM& vm)
    7957{
    8058    Base::finishCreation(vm);
    8159    ASSERT(inherits(info()));
    82 
    83     addBuiltinGlobals(vm);
    8460}
    8561
    … …  
    8864    Base::finishCreation(vm, thisValue);
    8965    ASSERT(inherits(info()));
    90 
    91     addBuiltinGlobals(vm);
    9266}
    9367
    … …  
    11387    for (auto& constructor : thisObject->constructors().values())
    11488        visitor.append(&constructor);
    115 
    116     thisObject->m_internalFunctions.visit(visitor);
    11789}
    11890

  • trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h

    r194033 r194319  
    2929
    3030#include "PlatformExportMacros.h"
    31 #include "WebCoreJSBuiltinInternals.h"
    3231#include <runtime/JSGlobalObject.h>
    3332
    … …  
    8079        }
    8180
    82         void addBuiltinGlobals(JSC::VM&);
    83         friend void JSBuiltinInternalFunctions::initialize(JSDOMGlobalObject&, JSC::VM&);
    84 
    8581    protected:
    8682        JSDOMStructureMap m_structures;
    … …  
    9086        const RefPtr<DOMWrapperWorld> m_world;
    9187        bool m_worldIsNormal;
    92 
    93         JSBuiltinInternalFunctions m_internalFunctions;
    9488    };
    9589

  • trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp

    r194033 r194319  
    5353#endif
    5454
     55#if ENABLE(STREAMS_API)
     56#include "JSReadableStreamPrivateConstructors.h"
     57#include "ReadableStreamInternalsBuiltins.h"
     58#include "StreamInternalsBuiltins.h"
     59#include "WritableStreamInternalsBuiltins.h"
     60#endif
     61
     62#if ENABLE(MEDIA_STREAM)
     63#include "RTCPeerConnectionInternalsBuiltins.h"
     64#endif
     65
    5566using namespace JSC;
    5667
    … …  
    7182    , m_wrapped(window)
    7283    , m_shell(shell)
     84    , m_privateFunctions(vm)
    7385{
    7486}
    … …  
    7890    Base::finishCreation(vm, shell);
    7991    ASSERT(inherits(info()));
     92
     93    m_privateFunctions.init(*this);
     94
     95#if ENABLE(STREAMS_API) || ENABLE(MEDIA_STREAM)
     96    JSVMClientData& clientData = *static_cast<JSVMClientData*>(vm.clientData);
     97#endif
    8098
    8199    GlobalPropertyInfo staticGlobals[] = {
    82100        GlobalPropertyInfo(vm.propertyNames->document, jsNull(), DontDelete | ReadOnly),
    83101        GlobalPropertyInfo(vm.propertyNames->window, m_shell, DontDelete | ReadOnly),
     102#if ENABLE(STREAMS_API)
     103        GlobalPropertyInfo(clientData.builtinNames().streamClosedPrivateName(), jsNumber(1), DontDelete | ReadOnly),
     104        GlobalPropertyInfo(clientData.builtinNames().streamClosingPrivateName(), jsNumber(2), DontDelete | ReadOnly),
     105        GlobalPropertyInfo(clientData.builtinNames().streamErroredPrivateName(), jsNumber(3), DontDelete | ReadOnly),
     106        GlobalPropertyInfo(clientData.builtinNames().streamReadablePrivateName(), jsNumber(4), DontDelete | ReadOnly),
     107        GlobalPropertyInfo(clientData.builtinNames().streamWaitingPrivateName(), jsNumber(5), DontDelete | ReadOnly),
     108        GlobalPropertyInfo(clientData.builtinNames().streamWritablePrivateName(), jsNumber(6), DontDelete | ReadOnly),
     109        GlobalPropertyInfo(clientData.builtinNames().ReadableStreamControllerPrivateName(), createReadableStreamControllerPrivateConstructor(vm, *this), DontDelete | ReadOnly),
     110        GlobalPropertyInfo(clientData.builtinNames().ReadableStreamReaderPrivateName(), createReadableStreamReaderPrivateConstructor(vm, *this), DontDelete | ReadOnly),
     111#define DECLARE_GLOBAL_STATIC(name)\
     112        GlobalPropertyInfo(\
     113            clientData.builtinFunctions().readableStreamInternalsBuiltins().name##PrivateName(), m_privateFunctions.readableStreamInternals().m_##name##Function.get() , DontDelete | ReadOnly),
     114        WEBCORE_FOREACH_READABLESTREAMINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
     115#undef DECLARE_GLOBAL_STATIC
     116#define DECLARE_GLOBAL_STATIC(name)\
     117        GlobalPropertyInfo(\
     118            clientData.builtinFunctions().streamInternalsBuiltins().name##PrivateName(), m_privateFunctions.streamInternals().m_##name##Function.get() , DontDelete | ReadOnly),
     119        WEBCORE_FOREACH_STREAMINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
     120#undef DECLARE_GLOBAL_STATIC
     121#define DECLARE_GLOBAL_STATIC(name)\
     122        GlobalPropertyInfo(\
     123            clientData.builtinFunctions().writableStreamInternalsBuiltins().name##PrivateName(), m_privateFunctions.writableStreamInternals().m_##name##Function.get() , DontDelete | ReadOnly),
     124        WEBCORE_FOREACH_WRITABLESTREAMINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
     125#undef DECLARE_GLOBAL_STATIC
     126#endif
     127#if ENABLE(MEDIA_STREAM)
     128#define DECLARE_GLOBAL_STATIC(name)\
     129        GlobalPropertyInfo(\
     130            clientData.builtinFunctions().rtcPeerConnectionInternalsBuiltins().name##PrivateName(), m_privateFunctions.rtcPeerConnectionInternals().m_##name##Function.get() , DontDelete | ReadOnly),
     131        WEBCORE_FOREACH_RTCPEERCONNECTIONINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
     132#undef DECLARE_GLOBAL_STATIC
     133#endif
    84134    };
    85135
    … …  
    92142    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
    93143    Base::visitChildren(thisObject, visitor);
     144    thisObject->m_privateFunctions.visit(visitor);
    94145}
    95146

  • trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h

    r194033 r194319  
    2323#include "JSDOMBinding.h"
    2424#include "JSDOMGlobalObject.h"
     25#include "WebCoreJSBuiltinInternals.h"
    2526#include <wtf/Forward.h>
    2627
    … …  
    8687        RefPtr<DOMWindow> m_wrapped;
    8788        JSDOMWindowShell* m_shell;
     89
     90        JSBuiltinInternalFunctions m_privateFunctions;
    8891    };
    8992

  • trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h

    r194033 r194319  
    2828#define WebCoreJSBuiltinInternals_h
    2929
    30 #if ENABLE(MEDIA_STREAM)
    31 #include "RTCPeerConnectionInternalsBuiltins.h"
    32 #endif
    33 
    3430#if ENABLE(STREAMS_API)
    3531#include "ReadableStreamInternalsBuiltins.h"
    3632#include "StreamInternalsBuiltins.h"
    3733#include "WritableStreamInternalsBuiltins.h"
     34#endif
     35
     36#if ENABLE(MEDIA_STREAM)
     37#include "RTCPeerConnectionInternalsBuiltins.h"
    3838#endif
    3939
    … …  
    4444namespace WebCore {
    4545
    46 class JSDOMGlobalObject;
    47 
    4846class JSBuiltinInternalFunctions {
    4947public:
    50     explicit JSBuiltinInternalFunctions(JSC::VM&);
     48explicit JSBuiltinInternalFunctions(JSC::VM& v)
     49        : vm(v)
     50#if ENABLE(STREAMS_API)
     51        , m_readableStreamInternalsFunctions(vm)
     52        , m_streamInternalsFunctions(vm)
     53        , m_writableStreamInternalsFunctions(vm)
     54#endif
     55#if ENABLE(MEDIA_STREAM)
     56        , m_rtcPeerConnectionInternalsFunctions(vm)
     57#endif
     58    { }
    5159
    52 #if ENABLE(MEDIA_STREAM)
    53     RTCPeerConnectionInternalsBuiltinFunctions rtcPeerConnectionInternals() { return m_rtcPeerConnectionInternalsFunctions; }
    54 #endif
    5560#if ENABLE(STREAMS_API)
    5661    ReadableStreamInternalsBuiltinFunctions readableStreamInternals() { return m_readableStreamInternalsFunctions; }
    … …  
    5863    WritableStreamInternalsBuiltinFunctions writableStreamInternals() { return m_writableStreamInternalsFunctions; }
    5964#endif
    60 
    61     void visit(JSC::SlotVisitor&);
    62     void initialize(JSDOMGlobalObject&, JSC::VM&);
     65#if ENABLE(MEDIA_STREAM)
     66    RTCPeerConnectionInternalsBuiltinFunctions rtcPeerConnectionInternals() { return m_rtcPeerConnectionInternalsFunctions; }
     67#endif
     68    void visit(JSC::SlotVisitor& visitor) {
     69#if ENABLE(STREAMS_API)
     70        m_readableStreamInternalsFunctions.visit(visitor);
     71        m_streamInternalsFunctions.visit(visitor);
     72        m_writableStreamInternalsFunctions.visit(visitor);
     73#endif
     74#if ENABLE(MEDIA_STREAM)
     75        m_rtcPeerConnectionInternalsFunctions.visit(visitor);
     76#endif
     77#ifndef SKIP_UNUSED_PARAM
     78        UNUSED_PARAM(visitor);
     79#endif
     80    }
     81    void init(JSC::JSGlobalObject& globalObject) {
     82#if ENABLE(STREAMS_API)
     83        m_readableStreamInternalsFunctions.init(globalObject);
     84        m_streamInternalsFunctions.init(globalObject);
     85        m_writableStreamInternalsFunctions.init(globalObject);
     86#endif
     87#if ENABLE(MEDIA_STREAM)
     88        m_rtcPeerConnectionInternalsFunctions.init(globalObject);
     89#endif
     90#ifndef SKIP_UNUSED_PARAM
     91        UNUSED_PARAM(globalObject);
     92#endif
     93    }
    6394
    6495private:
    6596    JSC::VM& vm;
    66 #if ENABLE(MEDIA_STREAM)
    67     RTCPeerConnectionInternalsBuiltinFunctions m_rtcPeerConnectionInternalsFunctions;
    68 #endif
    6997#if ENABLE(STREAMS_API)
    7098    ReadableStreamInternalsBuiltinFunctions m_readableStreamInternalsFunctions;
    7199    StreamInternalsBuiltinFunctions m_streamInternalsFunctions;
    72100    WritableStreamInternalsBuiltinFunctions m_writableStreamInternalsFunctions;
     101#endif
     102#if ENABLE(MEDIA_STREAM)
     103    RTCPeerConnectionInternalsBuiltinFunctions m_rtcPeerConnectionInternalsFunctions;
    73104#endif
    74105

  • trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h

    r194033 r194319  
    5050
    5151namespace WebCore {
    52 
    53 class JSDOMGlobalObject;
    54 
    55 void addBuiltinGlobals(JSDOMGlobalObject&, JSC::VM&);
    5652
    5753class JSBuiltinFunctions {
Note: See TracChangeset for help on using the changeset viewer.