Changeset 194470 in webkit

Timestamp:

Dec 31, 2015 2:49:09 PM (8 years ago)

Author:

aestes@apple.com

Message:

Fix warnings uncovered by migrating to WTF_MOVE
​https://bugs.webkit.org/show_bug.cgi?id=152601

Reviewed by Daniel Bates.

Source/JavaScriptCore:

• create_regex_tables: Moving a return value prevented copy elision.
• ftl/FTLUnwindInfo.cpp:

(JSC::FTL::parseUnwindInfo): Ditto.

• replay/EncodedValue.h: Ditto.

Source/WebCore:

• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
will be implicitly moved in this case.

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::actionsForElement): Ditto.

Tools:

Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
self-move, even if doing so would trigger a warning.

• TestWebKitAPI/Tests/WTF/NakedPtr.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/create_regex_tables (modified) (1 diff)
• Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp (modified) (1 diff)
• Source/JavaScriptCore/replay/EncodedValue.h (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/UIProcess/API/APIUIClient.h (modified) (1 diff)
• Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-12-31  Andy Estes  <aestes@apple.com>
+
+        Fix warnings uncovered by migrating to WTF_MOVE
+        https://bugs.webkit.org/show_bug.cgi?id=152601
+
+        Reviewed by Daniel Bates.
+
+        * create_regex_tables: Moving a return value prevented copy elision.
+        * ftl/FTLUnwindInfo.cpp:
+        (JSC::FTL::parseUnwindInfo): Ditto.
+        * replay/EncodedValue.h: Ditto.
+
 2015-12-30  Aleksandr Skachkov  <gskachkov@gmail.com>
 

trunk/Source/JavaScriptCore/create_regex_tables

@@ -107 +107 @@
         else:
             function += ("    characterClass->m_ranges.append(CharacterRange(0x%02x, 0x%02x));\n" % (min, max))
-    function += ("    return WTF::move(characterClass);\n")
+    function += ("    return characterClass;\n")
     function += ("}\n\n")
     functions += function

trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp

@@ -1017 +1017 @@
 #endif
     registerOffsets->sort();
-    return WTF::move(registerOffsets);
+    return registerOffsets;
 }
 

trunk/Source/JavaScriptCore/replay/EncodedValue.h

@@ -115 +115 @@
             encodedVector.append<T>(value);
 
-        return WTF::move(encodedVector);
+        return encodedVector;
     }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-12-31  Andy Estes  <aestes@apple.com>
+
+        Fix warnings uncovered by migrating to WTF_MOVE
+        https://bugs.webkit.org/show_bug.cgi?id=152601
+
+        Reviewed by Daniel Bates.
+
+        * Modules/encryptedmedia/MediaKeys.cpp:
+        (WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.
+
 2015-12-31  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp

@@ -120 +120 @@
 
     // 6. Return the new object to the caller.
-    return WTF::move(session);
+    return session;
 }
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-12-31  Andy Estes  <aestes@apple.com>
+
+        Fix warnings uncovered by migrating to WTF_MOVE
+        https://bugs.webkit.org/show_bug.cgi?id=152601
+
+        Reviewed by Daniel Bates.
+
+        * UIProcess/API/APIUIClient.h:
+        (API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
+        will be implicitly moved in this case.
+        * UIProcess/Cocoa/UIDelegate.mm:
+        (WebKit::UIDelegate::UIClient::actionsForElement): Ditto.
+
 2015-12-30  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/APIUIClient.h

@@ -160 +160 @@
     virtual bool shouldIncludeAppLinkActionsForElement(_WKActivatedElementInfo *) { return true; }
 #endif
-    virtual RetainPtr<NSArray> actionsForElement(_WKActivatedElementInfo *, RetainPtr<NSArray> defaultActions) { return WTF::move(defaultActions); }
+    virtual RetainPtr<NSArray> actionsForElement(_WKActivatedElementInfo *, RetainPtr<NSArray> defaultActions) { return defaultActions; }
     virtual void didNotHandleTapAsClick(const WebCore::IntPoint&) { }
 #endif

trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm

@@ -361 +361 @@
 {
     if (!m_uiDelegate.m_delegateMethods.webViewActionsForElementDefaultActions)
-        return WTF::move(defaultActions);
-
-    auto delegate = m_uiDelegate.m_delegate.get();
-    if (!delegate)
         return defaultActions;
 
+    auto delegate = m_uiDelegate.m_delegate.get();
+    if (!delegate)
+        return defaultActions;
+
     return [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView actionsForElement:elementInfo defaultActions:defaultActions.get()];
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2015-12-31  Andy Estes  <aestes@apple.com>
+
+        Fix warnings uncovered by migrating to WTF_MOVE
+        https://bugs.webkit.org/show_bug.cgi?id=152601
+
+        Reviewed by Daniel Bates.
+
+        Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
+        self-move, even if doing so would trigger a warning.
+
+        * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
+        (TestWebKitAPI::TEST):
+
 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp

@@ -180 +180 @@
         NakedPtr<RefLogger> ptr(&a);
         ASSERT_EQ(&a, ptr.get());
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
         ptr = WTF::move(ptr);
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
         ASSERT_EQ(&a, ptr.get());
     }

trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

@@ -271 +271 @@
         RefPtr<RefLogger> ptr(&a);
         ASSERT_EQ(&a, ptr.get());
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
         ptr = WTF::move(ptr);
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
         ASSERT_EQ(&a, ptr.get());
     }