Changeset 194596 in webkit

Timestamp:

Jan 5, 2016 12:36:59 PM (8 years ago)

Author:

Antti Koivisto

Message:

Remove selector filter update calls from Element child parsing callbacks
​https://bugs.webkit.org/show_bug.cgi?id=152749

Reviewed by Andreas Kling.

We haven't done style resolve during parsing for a while now. These calls do nothing useful.

• dom/Element.cpp:

(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-05  Antti Koivisto  <antti@apple.com>
+
+        Remove selector filter update calls from Element child parsing callbacks
+        https://bugs.webkit.org/show_bug.cgi?id=152749
+
+        Reviewed by Andreas Kling.
+
+        We haven't done style resolve during parsing for a while now. These calls do nothing useful.
+
+        * dom/Element.cpp:
+        (WebCore::Element::beginParsingChildren):
+        (WebCore::Element::finishParsingChildren):
+
 2016-01-05  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1889 +1889 @@
 {
     clearIsParsingChildrenFinished();
-    if (auto styleResolver = document().styleResolverIfExists())
-        styleResolver->pushParentElement(this);
 }
 
@@ -1898 +1896 @@
     setIsParsingChildrenFinished();
     checkForSiblingStyleChanges(*this, FinishedParsingChildren, ElementTraversal::lastChild(*this), nullptr);
-    if (auto styleResolver = document().styleResolverIfExists())
-        styleResolver->popParentElement(this);
 }