Changeset 195157 in webkit


Ignore:
Timestamp:
Jan 15, 2016 4:08:44 PM (8 years ago)
Author:
Chris Dumez
Message:

Drop obsolete DocumentType.entities / notations
https://bugs.webkit.org/show_bug.cgi?id=153147

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop obsolete DocumentType.entities / notations attributes.

Firefox and Chrome already dropped those. We already dropped support for
entities and notations so these always returned null.

No new tests, already covered by existing tests.

  • dom/DocumentType.h:
  • dom/DocumentType.idl:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r195152 r195157  
     12016-01-15  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop obsolete DocumentType.entities / notations
     4        https://bugs.webkit.org/show_bug.cgi?id=153147
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/dom/historical-expected.txt:
     11
    1122016-01-15  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt

    r191379 r195157  
    3636PASS Historical DOM features must be removed: setIdAttributeNS
    3737PASS Historical DOM features must be removed: setIdAttributeNode
    38 FAIL DocumentType member must be nuked: entities assert_equals: expected (undefined) undefined but got (object) null
    39 FAIL DocumentType member must be nuked: notations assert_equals: expected (undefined) undefined but got (object) null
     38PASS DocumentType member must be nuked: entities
     39PASS DocumentType member must be nuked: notations
    4040FAIL DocumentType member must be nuked: internalSubset assert_equals: expected (undefined) undefined but got (object) null
    4141PASS Text member must be nuked: isElementContentWhitespace
  • trunk/Source/WebCore/ChangeLog

    r195156 r195157  
     12016-01-15  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop obsolete DocumentType.entities / notations
     4        https://bugs.webkit.org/show_bug.cgi?id=153147
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Drop obsolete DocumentType.entities / notations attributes.
     9
     10        Firefox and Chrome already dropped those. We already dropped support for
     11        entities and notations so these always returned null.
     12
     13        No new tests, already covered by existing tests.
     14
     15        * dom/DocumentType.h:
     16        * dom/DocumentType.idl:
     17
    1182016-01-10  Simon Fraser  <simon.fraser@apple.com>
    219
  • trunk/Source/WebCore/dom/DocumentType.h

    r189677 r195157  
    3838    }
    3939
    40     // FIXME: We return null entities and notations. Current implementation of NamedNodeMap doesn't work without an associated Element yet.
    41     NamedNodeMap* entities() const { return nullptr; }
    42     NamedNodeMap* notations() const { return nullptr; }
     40    // These is needed by native bindings for backward compatibility.
     41    NamedNodeMap* entitiesForBindings() const { return nullptr; }
     42    NamedNodeMap* notationsForBindings() const { return nullptr; }
    4343
    4444    const String& name() const { return m_name; }
  • trunk/Source/WebCore/dom/DocumentType.idl

    r189881 r195157  
    2626
    2727    readonly attribute DOMString name;
    28     readonly attribute NamedNodeMap entities;
    29     readonly attribute NamedNodeMap notations;
     28
     29#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
     30    [ImplementedAs=entitiesForBindings] readonly attribute NamedNodeMap entities;
     31    [ImplementedAs=notationsForBindings] readonly attribute NamedNodeMap notations;
     32#endif
    3033
    3134    // DOM Level 2
Note: See TracChangeset for help on using the changeset viewer.