Changeset 195339 in webkit

Timestamp:

Jan 19, 2016 8:39:54 PM (8 years ago)

Author:

sbarati@apple.com

Message:

WTF::Bag should be non-copyable
​https://bugs.webkit.org/show_bug.cgi?id=153253

Reviewed by Filip Pizlo.

• wtf/Bag.h:
• wtf/SegmentedVector.h:

(WTF::SegmentedVector::append):
(WTF::SegmentedVector::alloc):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Bag.h (modified) (1 diff)
• wtf/SegmentedVector.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2016-01-19  Saam barati  <sbarati@apple.com>
+
+        WTF::Bag should be non-copyable
+        https://bugs.webkit.org/show_bug.cgi?id=153253
+
+        Reviewed by Filip Pizlo.
+
+        * wtf/Bag.h:
+        * wtf/SegmentedVector.h:
+        (WTF::SegmentedVector::append):
+        (WTF::SegmentedVector::alloc):
+
 2016-01-19  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WTF/wtf/Bag.h

@@ -31 +31 @@
 template<typename T>
 class Bag {
+    WTF_MAKE_NONCOPYABLE(Bag);
     WTF_MAKE_FAST_ALLOCATED;
 private:

trunk/Source/WTF/wtf/SegmentedVector.h

@@ -133 +133 @@
         }
 
-        template <typename U> void append(U&& value)
+        template<typename... Args>
+        void append(Args&&... args)
         {
             ++m_size;
             if (!segmentExistsFor(m_size - 1))
                 allocateSegment();
-            new (NotNull, &last()) T(std::forward<U>(value));
+            new (NotNull, &last()) T(std::forward<Args>(args)...);
         }
 
@@ -144 +145 @@
         T& alloc(Args&&... args)
         {
-            append<T>(T(std::forward<Args>(args)...));
+            append(std::forward<Args>(args)...);
             return last();
         }