Changeset 195507 in webkit

Timestamp:

Jan 22, 2016 11:13:53 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r195493.
​https://bugs.webkit.org/show_bug.cgi?id=153397

Broke authenticaiton tests (leaks credentials) (Requested by
ap on #webkit).

Reverted changeset:

"LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
unterminated.html crashing"
​https://bugs.webkit.org/show_bug.cgi?id=153250
​http://trac.webkit.org/changeset/195493

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt (deleted)
• LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html (deleted)
• LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt (deleted)
• LayoutTests/http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html (deleted)
• LayoutTests/platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/CredentialStorage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-01-22  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r195493.
+        https://bugs.webkit.org/show_bug.cgi?id=153397
+
+        Broke authenticaiton tests (leaks credentials) (Requested by
+        ap on #webkit).
+
+        Reverted changeset:
+
+        "LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
+        unterminated.html crashing"
+        https://bugs.webkit.org/show_bug.cgi?id=153250
+        http://trac.webkit.org/changeset/195493
+
 2016-01-20  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-22  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r195493.
+        https://bugs.webkit.org/show_bug.cgi?id=153397
+
+        Broke authenticaiton tests (leaks credentials) (Requested by
+        ap on #webkit).
+
+        Reverted changeset:
+
+        "LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
+        unterminated.html crashing"
+        https://bugs.webkit.org/show_bug.cgi?id=153250
+        http://trac.webkit.org/changeset/195493
+
 2016-01-20  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/network/CredentialStorage.cpp

@@ -124 +124 @@
         directoryURL = directoryURL.substring(0, (index == directoryURLPathStart) ? index + 1 : index);
         ASSERT(directoryURL.length() > directoryURLPathStart);
+        ASSERT(directoryURL.length() == directoryURLPathStart + 1 || directoryURL[directoryURL.length() - 1] != '/');
     }
 }