Changeset 195512 in webkit

Timestamp:

Jan 23, 2016 6:47:42 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: AXI: node-link-list should be collapsible
​https://bugs.webkit.org/show_bug.cgi?id=130911

.:

Added a manual test to test the node list in the Accessibility Inspector

Patch by Aaron Chu <​arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.

• ManualTests/accessibility/collapsible-node-link-list.html: Added.

Source/WebInspectorUI:

Patch by Aaron Chu <​arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.

Accessibility Inspector: for a very long children node list, only the first 5 nodes are shown.
Remaining nodes are hidden by a "# More…" link by which a user can click to reveal the remainder
of the node list.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.linkListForNodeIds):

• UserInterface/Views/Main.css:

(.expand-list-button):
(.node-link-list, .node-link-list li:not([hidden])):
(.node-link-list, .node-link-list li): Deleted.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• ManualTests/accessibility/collapsible-node-link-list.html (added)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Views/Main.css (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2016-01-23  Aaron Chu  <arona.chu@gmail.com>
+
+        Web Inspector: AXI: node-link-list should be collapsible
+        https://bugs.webkit.org/show_bug.cgi?id=130911
+        
+        Added a manual test to test the node list in the Accessibility Inspector
+
+        Reviewed by Timothy Hatcher.
+
+        * ManualTests/accessibility/collapsible-node-link-list.html: Added.
+
 2016-01-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-23  Aaron Chu  <arona.chu@gmail.com>
+
+        Web Inspector: AXI: node-link-list should be collapsible
+        https://bugs.webkit.org/show_bug.cgi?id=130911
+        
+        Reviewed by Timothy Hatcher.
+
+        Accessibility Inspector: for a very long children node list, only the first 5 nodes are shown.
+        Remaining nodes are hidden by a "# More…" link by which a user can click to reveal the remainder 
+        of the node list.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.linkListForNodeIds):
+        * UserInterface/Views/Main.css:
+        (.expand-list-button):
+        (.node-link-list, .node-link-list li:not([hidden])):
+        (.node-link-list, .node-link-list li): Deleted.
+
 2016-01-22  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -1 +1 @@
 var localizedStrings = new Object;
 
+localizedStrings["%d More\u2026"] = "%d More\u2026";
 localizedStrings[" (Prototype)"] = " (Prototype)";
 localizedStrings[" (line %s)"] = " (line %s)";

trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

@@ -301 +301 @@
 
         function linkListForNodeIds(nodeIds) {
-            var hasLinks = false;
-            var linkList = null;
-            if (nodeIds !== undefined) {
-                linkList = document.createElement("ul");
-                linkList.className = "node-link-list";    
-                for (var nodeId of nodeIds) {
-                    var node = WebInspector.domTreeManager.nodeForId(nodeId);
-                    if (node) {
-                        var link = WebInspector.linkifyAccessibilityNodeReference(node);
-                        if (link) {
-                            hasLinks = true;
-                            var listitem = document.createElement("li");
-                            listitem.appendChild(link);
-                            linkList.appendChild(listitem);
-                        }
-                    }
-                }
-            }
-            return hasLinks ? linkList : null;
+            if (!nodeIds) 
+                return null;
+
+            const itemsToShow = 5;
+            let hasLinks = false;
+            let listItemCount = 0;
+            let container = document.createElement("div");
+            container.classList.add("list-container")
+            let linkList = container.createChild("ul", "node-link-list");            
+            let initiallyHiddenItems = [];
+            for (let nodeId of nodeIds) {
+                let node = WebInspector.domTreeManager.nodeForId(nodeId);
+                if (!node)
+                    continue;
+                let link = WebInspector.linkifyAccessibilityNodeReference(node);
+                hasLinks = true;
+                let li = linkList.createChild("li");
+                li.appendChild(link);
+                if (listItemCount >= itemsToShow) {  
+                    li.hidden = true;
+                    initiallyHiddenItems.push(li);
+                } 
+                listItemCount++;
+            }
+            container.appendChild(linkList);
+            if (listItemCount > itemsToShow) {
+                let moreNodesButton = container.createChild("button", "expand-list-button");
+                moreNodesButton.textContent = WebInspector.UIString("%d More\u2026").format(listItemCount - itemsToShow);
+                moreNodesButton.addEventListener("click", () => {
+                    initiallyHiddenItems.forEach((element) => element.hidden = false);
+                    moreNodesButton.remove();
+                });
+            }
+            if (hasLinks) 
+                return container;
+
+            return null;
         }
 

trunk/Source/WebInspectorUI/UserInterface/Views/Main.css

@@ -306 +306 @@
 }
 
+.expand-list-button {
+    -webkit-appearance: none;
+    text-decoration: underline;
+    background-color: transparent;
+    padding: 0;
+    margin: 0;
+    border: 0;
+    cursor: pointer;
+    color: black;
+}
+
 .node-link {
     text-decoration: underline;
@@ -311 +322 @@
 }
 
-.node-link-list, .node-link-list li {
+.node-link-list, .node-link-list li:not([hidden]) {
     display: block;
     margin: 0;