Changeset 195536 in webkit

Timestamp:

Jan 25, 2016 8:19:30 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: timelines clear button should be inactive if nothing can be cleared
​https://bugs.webkit.org/show_bug.cgi?id=132756

Patch by Johan K. Jensen <​jj@johanjensen.dk> on 2016-01-25
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.shown):
Enable clear button if timeline is not readonly and contains data, when switching timelines.
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Enable clear button when a capturing starts.
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Disable clear button after resetting recording.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-25  Johan K. Jensen  <jj@johanjensen.dk>
+
+        Web Inspector: timelines clear button should be inactive if nothing can be cleared
+        https://bugs.webkit.org/show_bug.cgi?id=132756
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype.shown):
+        Enable clear button if timeline is not readonly and contains data, when switching timelines.
+        (WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
+        Enable clear button when a capturing starts.
+        (WebInspector.TimelineRecordingContentView.prototype._recordingReset):
+        Disable clear button after resetting recording.
+
 2016-01-25  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -164 +164 @@
         this._currentTimelineOverview.shown();
         this._contentViewContainer.shown();
-        this._clearTimelineNavigationItem.enabled = !this._recording.readonly;
+        this._clearTimelineNavigationItem.enabled = !this._recording.readonly && !isNaN(this._recording.startTime);
 
         this._currentContentViewDidChange();
@@ -503 +503 @@
         if (!this._updating)
             this._startUpdatingCurrentTime(event.data.startTime);
+        this._clearTimelineNavigationItem.enabled = !this._recording.readonly;
     }
 
@@ -655 +656 @@
         for (var timelineView of this._timelineViewMap.values())
             timelineView.reset();
+        this._clearTimelineNavigationItem.enabled = false;
     }