Changeset 195626 in webkit

Timestamp:

Jan 26, 2016 3:14:55 PM (8 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r195610.
​https://bugs.webkit.org/show_bug.cgi?id=153513

The test added with this change is timing out on almost every
run (Requested by ryanhaddad on #webkit).

Reverted changeset:

"Calling video.controls=true during a scrub operation cancels
scrub."
​https://bugs.webkit.org/show_bug.cgi?id=153494
​http://trac.webkit.org/changeset/195610

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-01-26

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/media-controls-drag-timeline-set-controls-property-expected.txt (deleted)
• LayoutTests/media/media-controls-drag-timeline-set-controls-property.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-01-26  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r195610.
+        https://bugs.webkit.org/show_bug.cgi?id=153513
+
+        The test added with this change is timing out on almost every
+        run (Requested by ryanhaddad on #webkit).
+
+        Reverted changeset:
+
+        "Calling video.controls=true during a scrub operation cancels
+        scrub."
+        https://bugs.webkit.org/show_bug.cgi?id=153494
+        http://trac.webkit.org/changeset/195610
+
 2016-01-26  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-26  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r195610.
+        https://bugs.webkit.org/show_bug.cgi?id=153513
+
+        The test added with this change is timing out on almost every
+        run (Requested by ryanhaddad on #webkit).
+
+        Reverted changeset:
+
+        "Calling video.controls=true during a scrub operation cancels
+        scrub."
+        https://bugs.webkit.org/show_bug.cgi?id=153494
+        http://trac.webkit.org/changeset/195610
+
 2016-01-26  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

@@ -1088 +1088 @@
             this.updateBase();
 
-            if (this.shouldHaveControls() && !this.hasControls())
+            if (this.shouldHaveControls())
                 this.addControls();
-            else if (!this.shouldHaveControls() && this.hasControls())
+            else
                 this.removeControls();
         } catch(e) {
@@ -1541 +1541 @@
         this.base.appendChild(this.controls.panel);
         this.updateControls();
-    },
-
-    hasControls: function()
-    {
-        return this.controls.panel.parentElement;
     },