Changeset 195642 in webkit

Timestamp:

Jan 26, 2016 5:16:16 PM (8 years ago)

Author:

Chris Dumez

Message:

Setting HTMLInputElement.value to null to set its value to the empty string
​https://bugs.webkit.org/show_bug.cgi?id=153519

Reviewed by Ryosuke Niwa.

Source/WebCore:

Setting HTMLInputElement.value to null to set its value to the empty string:

• ​https://html.spec.whatwg.org/#htmlinputelement
• ​http://heycam.github.io/webidl/#TreatNullAs

WebKit would previously unset the value attribute instead, which caused
it to fallback to input.defaultValue if set.

Firefox and Chrome behave correctly.

Test: fast/dom/HTMLInputElement/input-value-set-null.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

LayoutTests:

Add a layout test to make sure that setting HTMLInputElement.value to null
actually sets its value to the empty string.

• fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
• fast/dom/HTMLInputElement/input-value-set-null.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLInputElement/input-value-set-null-expected.txt (added)
• LayoutTests/fast/dom/HTMLInputElement/input-value-set-null.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-01-26  Chris Dumez  <cdumez@apple.com>
+
+        Setting HTMLInputElement.value to null to set its value to the empty string
+        https://bugs.webkit.org/show_bug.cgi?id=153519
+
+        Reviewed by Ryosuke Niwa.
+
+        Add a layout test to make sure that setting HTMLInputElement.value to null
+        actually sets its value to the empty string.
+
+        * fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
+        * fast/dom/HTMLInputElement/input-value-set-null.html: Added.
+
 2016-01-26  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-26  Chris Dumez  <cdumez@apple.com>
+
+        Setting HTMLInputElement.value to null to set its value to the empty string
+        https://bugs.webkit.org/show_bug.cgi?id=153519
+
+        Reviewed by Ryosuke Niwa.
+
+        Setting HTMLInputElement.value to null to set its value to the empty string:
+        - https://html.spec.whatwg.org/#htmlinputelement
+        - http://heycam.github.io/webidl/#TreatNullAs
+
+        WebKit would previously unset the value attribute instead, which caused
+        it to fallback to input.defaultValue if set.
+
+        Firefox and Chrome behave correctly.
+
+        Test: fast/dom/HTMLInputElement/input-value-set-null.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValue):
+
 2016-01-26  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -984 +984 @@
         return;
     }
-    setValue(value, eventBehavior);
+    setValue(value.isNull() ? emptyString() : value, eventBehavior);
 }