Changeset 195643 in webkit

Timestamp:

Jan 26, 2016, 5:22:44 PM (9 years ago)

Author:

Simon Fraser

Message:

Use initializers in HTMLCanvasElement
​https://bugs.webkit.org/show_bug.cgi?id=153472

Reviewed by Michael Catanzaro.

Use initializers, and re-order member variables for better packing.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

• html/HTMLCanvasElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLCanvasElement.cpp (modified) (1 diff)
• html/HTMLCanvasElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Use initializers in HTMLCanvasElement
+        https://bugs.webkit.org/show_bug.cgi?id=153472
+
+        Reviewed by Michael Catanzaro.
+
+        Use initializers, and re-order member variables for better packing.
+
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
+        * html/HTMLCanvasElement.h:
+
 2016-01-26  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLCanvasElement.cpp

@@ -82 +82 @@
     : HTMLElement(tagName, document)
     , m_size(DefaultWidth, DefaultHeight)
-    , m_rendererIsCanvas(false)
-    , m_ignoreReset(false)
-    , m_originClean(true)
-    , m_hasCreatedImageBuffer(false)
-    , m_didClearImageBuffer(false)
 {
     ASSERT(hasTagName(canvasTag));

trunk/Source/WebCore/html/HTMLCanvasElement.h

@@ -163 +163 @@
 
     HashSet<CanvasObserver*> m_observers;
+    std::unique_ptr<CanvasRenderingContext> m_context;
 
+    FloatRect m_dirtyRect;
     IntSize m_size;
 
-    std::unique_ptr<CanvasRenderingContext> m_context;
-
-    bool m_rendererIsCanvas;
-
-    bool m_ignoreReset;
-    FloatRect m_dirtyRect;
-
-    bool m_originClean;
+    bool m_originClean { true };
+    bool m_rendererIsCanvas { false };
+    bool m_ignoreReset { false };
 
     // m_createdImageBuffer means we tried to malloc the buffer.  We didn't necessarily get it.
-    mutable bool m_hasCreatedImageBuffer;
-    mutable bool m_didClearImageBuffer;
+    mutable bool m_hasCreatedImageBuffer { false };
+    mutable bool m_didClearImageBuffer { false };
     mutable std::unique_ptr<ImageBuffer> m_imageBuffer;
     mutable std::unique_ptr<GraphicsContextStateSaver> m_contextStateSaver;