Changeset 195706 in webkit


Ignore:
Timestamp:
Jan 27, 2016 4:18:37 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
​https://bugs.webkit.org/show_bug.cgi?id=153563

Patch by Devin Rousso <Devin Rousso> on 2016-01-27
Reviewed by Timothy Hatcher.

Removed duplicate properties and used new methods of TreeOutline to achieve
the desired styling effects.

  • UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.

  • UserInterface/Views/VisualStyleSelectorSection.js:

(WebInspector.VisualStyleSelectorSection):

  • UserInterface/Views/VisualStyleSelectorTreeItem.css:

(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item > .titles > .subtitle):
(.item.visual-style-selector-item.selected > .titles > .subtitle):
(.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.

Location:
trunk/Source/WebInspectorUI
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r195699 r195706  
     12016-01-27  Devin Rousso  <dcrousso+webkit@gmail.com>
     2
     3        Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
     4        https://bugs.webkit.org/show_bug.cgi?id=153563
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Removed duplicate properties and used new methods of TreeOutline to achieve
     9        the desired styling effects.
     10
     11        * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
     12        (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
     13        (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
     14
     15        * UserInterface/Views/VisualStyleSelectorSection.js:
     16        (WebInspector.VisualStyleSelectorSection):
     17
     18        * UserInterface/Views/VisualStyleSelectorTreeItem.css:
     19        (.item.visual-style-selector-item > .icon):
     20        (.item.visual-style-selector-item > .titles):
     21        (.item.visual-style-selector-item > .titles > .subtitle):
     22        (.item.visual-style-selector-item.selected > .titles > .subtitle):
     23        (.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
     24
    1252016-01-27  Simon Fraser  <simon.fraser@apple.com>
    226

  • trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css

    r194876 r195706  
    6666}
    6767
    68 .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles {
    69     padding-left: 3px;
    70 }
    71 
    7268.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item.selected:not(.editor-hidden) > .titles > * {
    7369    color: transparent;
    … …  
    7773    position: absolute;
    7874    top: 0;
    79     right: 3px;
     75    right: 0;
    8076    bottom: 0;
    81     left: 3px;
     77    left: 5px;
    8278    margin: 0;
    8379    padding: 0;
    84     line-height: 13px;
     80    line-height: 17px;
    8581    border: none;
    8682    background-color: transparent;

  • trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js

    r194737 r195706  
    5656
    5757        this._selectors = new WebInspector.TreeOutline(selectorListElement);
     58        this._selectors.disclosureButtons = false;
    5859        this._selectors.addEventListener(WebInspector.TreeOutline.Event.SelectionDidChange, this._selectorChanged, this);
    5960

  • trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css

    r194437 r195706  
    6262    width: 16px;
    6363    height: 16px;
    64     margin-left: 4px;
     64    margin: 0 3px 0 4px;
    6565}
    6666
    … …  
    104104.item.visual-style-selector-item > .titles {
    105105    flex: 1;
     106    top: 0;
     107    line-height: inherit;
    106108    overflow: hidden;
    107109    white-space: nowrap;
    108110    text-overflow: ellipsis;
    109     padding: 0 2px 0 3px;
    110111}
    111112
    … …  
    129130}
    130131
    131 .item.visual-style-selector-item > .titles > .subtitle::before {
    132     margin-right: 5px;
    133     font-size: 11px;
    134     /* The extra space at the beginning is necessary to prevent the -webkit-user-modify
    135     cursor bar from displaying at the beginning of the em-dash. */
    136     content: " \2014"; /* em-dash */
     132.item.visual-style-selector-item > .titles > .subtitle {
     133    vertical-align: 1px;
     134    font-size: 9px;
    137135}
    138136
    139 .item.visual-style-selector-item > .titles > .subtitle {
    140     font-size: 9px;
     137.item.visual-style-selector-item.selected > .titles > .subtitle {
     138    color: inherit;
    141139}
Note: See TracChangeset for help on using the changeset viewer.