Changeset 19573 in webkit

Timestamp:

Feb 12, 2007 3:59:07 AM (17 years ago)

Author:

mjs

Message:

LayoutTests:

Reviewed by Antti.

• test case for <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083) ​http://bugs.webkit.org/show_bug.cgi?id=12083

• fast/text/text-shadow-extreme-value.html: Added.
• fast/text/text-shadow-extreme-value-expected.txt: Added.

WebCore:

Reviewed by Antti.

• fixed <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083) ​http://bugs.webkit.org/show_bug.cgi?id=12083

Test: fast/text/text-shadow-extreme-value.html

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to make CG unhappy.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/text-shadow-extreme-value-expected.txt (added)
• LayoutTests/fast/text/text-shadow-extreme-value.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/cg/GraphicsContextCG.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-12  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Antti.
+        
+        - test case for <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
+        http://bugs.webkit.org/show_bug.cgi?id=12083
+        
+        * fast/text/text-shadow-extreme-value.html: Added.
+        * fast/text/text-shadow-extreme-value-expected.txt: Added.
+
 2007-02-11  Maciej Stachowiak  <mjs@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-12  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Antti.
+
+        - fixed <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
+        http://bugs.webkit.org/show_bug.cgi?id=12083
+        
+        Test: fast/text/text-shadow-extreme-value.html
+
+        * platform/graphics/cg/GraphicsContextCG.cpp:
+        (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to 
+        make CG unhappy.
+
 2007-02-11  Brady Eidson <beidson@apple.com>
 
-        Reviewed by Maciej
+        Reviewed by Maciej.
 
         First in what will be a series of HistoryItem enhancements to help debugging

trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

@@ -596 +596 @@
 void GraphicsContext::setShadow(const IntSize& size, int blur, const Color& color)
 {
+    // Extreme "blur" values can make text drawing crash or take crazy long times, so clamp
+    blur = min(blur, 1000);
+
     if (paintingDisabled())
         return;