Changeset 195910 in webkit

Timestamp:

Jan 30, 2016 1:49:31 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Object tree parent items are misaligned
​https://bugs.webkit.org/show_bug.cgi?id=153699
<rdar://problem/24423683>

Patch by Devin Rousso <Devin Rousso> on 2016-01-30
Reviewed by Darin Adler.

• UserInterface/Views/ObjectTreeView.css:

(.object-tree .object-tree):
Ensure that toplevel Object preview trees are displayed properly while also
making child trees inline.

• UserInterface/Views/TreeOutline.css:

(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
This would apply to all .icon elements contained within a non-parent item,
which is not the desired effect. Instead, this should only apply to only the
.icon element of that particular non-parent item.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ObjectTreeView.css (modified) (1 diff)
• UserInterface/Views/TreeOutline.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-30  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Object tree parent items are misaligned
+        https://bugs.webkit.org/show_bug.cgi?id=153699
+        <rdar://problem/24423683>
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Views/ObjectTreeView.css:
+        (.object-tree .object-tree):
+        Ensure that toplevel Object preview trees are displayed properly while also
+        making child trees inline.
+
+        * UserInterface/Views/TreeOutline.css:
+        (.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
+        (.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
+        This would apply to all .icon elements contained within a non-parent item,
+        which is not the desired effect. Instead, this should only apply to only the
+        .icon element of that particular non-parent item.
+
 2016-01-29  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css

@@ -70 +70 @@
 }
 
+.object-tree .object-tree {
+    display: inline-block;
+}
+
 .object-tree .tree-outline.object {
     display: none;

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css

@@ -69 +69 @@
 }
 
-.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon {
+.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon {
     margin-left: 16px;
 }