Changeset 195966 in webkit

Timestamp:

Feb 1, 2016 10:22:37 AM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
​https://bugs.webkit.org/show_bug.cgi?id=153733
<rdar://problem/24431813>

Reviewed by Brian Burg.

Provide a way to add go-to arrow buttons to any grid cell from within a
DataGridNode subclass's implementation of createCellContent.

• UserInterface/Views/DataGrid.js:

New event type, GoToArrowClicked.
(WebInspector.DataGridNode.prototype.createGoToArrowButton.buttonClicked):
(WebInspector.DataGridNode.prototype.createGoToArrowButton):
Adds a go-to arrow button to the cell's content element. Clicking the button
dispatches an event on the DataGrid, with event data containing the
DataGridNode and identifier of the cell containing the arrow button.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DataGrid.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-02-01  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
+        https://bugs.webkit.org/show_bug.cgi?id=153733
+        <rdar://problem/24431813>
+
+        Reviewed by Brian Burg.
+
+        Provide a way to add go-to arrow buttons to any grid cell from within a
+        DataGridNode subclass's implementation of createCellContent.
+
+        * UserInterface/Views/DataGrid.js:
+        New event type, GoToArrowClicked.
+        (WebInspector.DataGridNode.prototype.createGoToArrowButton.buttonClicked):
+        (WebInspector.DataGridNode.prototype.createGoToArrowButton):
+        Adds a go-to arrow button to the cell's content element. Clicking the button
+        dispatches an event on the DataGrid, with event data containing the
+        DataGridNode and identifier of the cell containing the arrow button.
+
 2016-01-31  Jeremy Jones  <jeremyj@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js

@@ -1345 +1345 @@
     SelectedNodeChanged: "datagrid-selected-node-changed",
     ExpandedNode: "datagrid-expanded-node",
-    CollapsedNode: "datagrid-collapsed-node"
+    CollapsedNode: "datagrid-collapsed-node",
+    GoToArrowClicked: "datagrid-go-to-arrow-clicked"
 };
 
@@ -1455 +1456 @@
     }
 
+    createGoToArrowButton(cellElement)
+    {
+        function buttonClicked(event)
+        {
+            if (this.hidden || !this.revealed)
+                return;
+
+            event.stopPropagation();
+
+            let columnIdentifier = cellElement.__columnIdentifier;
+            this.dataGrid.dispatchEventToListeners(WebInspector.DataGrid.Event.GoToArrowClicked, {dataGridNode: this, columnIdentifier});
+        }
+
+        let button = WebInspector.createGoToArrowButton();
+        button.addEventListener("click", buttonClicked.bind(this));
+
+        let contentElement = cellElement.firstChild;
+        contentElement.appendChild(button);
+    }
+
     refreshIfNeeded()
     {