Changeset 19600 in webkit

Timestamp:

Feb 13, 2007 3:02:37 AM (17 years ago)

Author:

rwlbuis

Message:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12578
WebKit incorrectly strokes zero-width/height rectangles

Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.checksum (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png (modified) (previous)
• LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.checksum (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png (modified) (previous)
• LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.checksum (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png (modified) (previous)
• LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt (modified) (1 diff)
• LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/Path.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-13  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12578
+        WebKit incorrectly strokes zero-width/height rectangles
+
+        Updated test results.
+
+        * svg/W3C-SVG-1.1/animate-elem-32-t-expected.checksum:
+        * svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
+        * svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
+        * svg/W3C-SVG-1.1/shapes-intro-01-t-expected.checksum:
+        * svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
+        * svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
+        * svg/W3C-SVG-1.1/shapes-rect-02-t-expected.checksum:
+        * svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
+        * svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
+        * svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
+
 2007-02-13  Mitz Pettel  <mitz@webkit.org>
 

trunk/LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.checksum

@@ -1 @@
-7a2efe50f6281968b54568cc5ab3092a
+b0aa5b516c99256f34ea3836782020e8

trunk/LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt

@@ -40 +40 @@
           RenderPath {rect} at (393.50,154.50) size 36x61 [stroke={[type=SOLID] [color=#000000]}] [data="M394.00,155.00L429.00,155.00L429.00,215.00L394.00,215.00"]
           RenderPath {rect} at (209.50,259.50) size 61x11 [stroke={[type=SOLID] [color=#000000]}] [data="M210.00,260.00L270.00,260.00L270.00,270.00L210.00,270.00"]
-        RenderPath {rect} at (54.50,55) size 1x50 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#00FF00]}] [data="M55.00,55.00L55.00,55.00L55.00,105.00L55.00,105.00"]
-        RenderPath {rect} at (135,54.50) size 25x1 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#00FF00]}] [data="M135.00,55.00L160.00,55.00L160.00,55.00L135.00,55.00"]
-        RenderPath {rect} at (55,160) size 0x50 [fill={[type=SOLID] [color=#FF0000]}] [data="M55.00,160.00L55.00,160.00L55.00,210.00L55.00,210.00"]
-        RenderPath {rect} at (135,160) size 25x0 [fill={[type=SOLID] [color=#FF0000]}] [data="M135.00,160.00L160.00,160.00L160.00,160.00L135.00,160.00"]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#00FF00]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#00FF00]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]
         RenderPath {circle} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#00FF00]}] [data=""]
         RenderPath {circle} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]

trunk/LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.checksum

@@ -1 @@
-1457be4feaa9ff33d82230f5eb94bf9c
+dddefd7dccccbfe2f754f8aaa8e2ab07

trunk/LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt

@@ -40 +40 @@
             RenderSVGInlineText {#text} at (0,-8) size 63x10
               text run at (0,-8) width 63: "Zero length line"
-        RenderPath {rect} at (54.50,55) size 1x50 [stroke={[type=SOLID] [color=#000000]}] [data="M55.00,55.00L55.00,55.00L55.00,105.00L55.00,105.00"]
-        RenderPath {rect} at (55,160) size 0x50 [fill={[type=SOLID] [color=#FF0000]}] [data="M55.00,160.00L55.00,160.00L55.00,210.00L55.00,210.00"]
-        RenderPath {rect} at (135,54.50) size 25x1 [stroke={[type=SOLID] [color=#0000FF]}] [fill={[type=SOLID] [color=#00FF00]}] [data="M135.00,55.00L160.00,55.00L160.00,55.00L135.00,55.00"]
-        RenderPath {rect} at (135,160) size 25x0 [fill={[type=SOLID] [color=#00FF00]}] [data="M135.00,160.00L160.00,160.00L160.00,160.00L135.00,160.00"]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#0000FF]}] [fill={[type=SOLID] [color=#00FF00]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#00FF00]}] [data=""]
         RenderPath {circle} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [data=""]
         RenderPath {circle} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]

trunk/LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.checksum

@@ -1 @@
-f56b5c3fbfa903076042ec3936b70a62
+351b26eae1634f44a4a45a2ef1b7d755

trunk/LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt

@@ -2 +2 @@
   RenderView at (0,0) size 480x360
     RenderSVGContainer {svg} at (-0.50,-0.50) size 480x360
-      RenderSVGContainer {g} at (-0.50,-0.50) size 400.50x277
+      RenderSVGContainer {g} at (-0.50,-0.50) size 181x277
         RenderPath {rect} at (-0.50,45.50) size 51x81 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,46.00L50.00,46.00L50.00,126.00L0.00,126.00"]
         RenderPath {rect} at (129.50,-0.50) size 51x81 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M130.00,0.00L180.00,0.00L180.00,80.00L130.00,80.00"]
-        RenderPath {rect} at (249.50,46) size 1x80 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M250.00,46.00L250.00,46.00L250.00,126.00L250.00,126.00"]
-        RenderPath {rect} at (350,45.50) size 50x1 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M350.00,46.00L400.00,46.00L400.00,46.00L350.00,46.00"]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data=""]
+        RenderPath {rect} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data=""]
         RenderPath {rect} at (29.50,195.50) size 51x81 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M50.00,196.00L60.00,196.00C71.04,196.00,80.00,204.96,80.00,216.00L80.00,256.00C80.00,267.04,71.04,276.00,60.00,276.00L50.00,276.00C38.96,276.00,30.00,267.04,30.00,256.00L30.00,216.00C30.00,204.96,38.96,196.00,50.00,196.00"]
         RenderPath {rect} at (129.50,195.50) size 51x81 [stroke={[type=SOLID] [color=#000000]}] [fill={[type=SOLID] [color=#FF0000]}] [data="M150.00,196.00L160.00,196.00C171.04,196.00,180.00,204.96,180.00,216.00L180.00,256.00C180.00,267.04,171.04,276.00,160.00,276.00L150.00,276.00C138.96,276.00,130.00,267.04,130.00,256.00L130.00,216.00C130.00,204.96,138.96,196.00,150.00,196.00"]

trunk/LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt

@@ -3 +3 @@
     RenderSVGContainer {svg} at (0.50,0.50) size 479x359
       RenderSVGContainer {g} at (50,186) size 148x18
-        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,0.00L0.00,0.00L0.00,0.00L0.00,0.00"]
+        RenderPath {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [data=""]
         RenderSVGText {text} at (50,200) size 480x18
           RenderSVGInlineText {#text} at (0,-14) size 148x18

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-13  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12578
+        WebKit incorrectly strokes zero-width/height rectangles
+
+        Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.
+
+        * platform/graphics/Path.cpp:
+        (WebCore::Path::createRectangle):
+
 2007-02-13  Rob Buis  <buis@kde.org>
 

trunk/WebCore/platform/graphics/Path.cpp

@@ -162 +162 @@
     double width = rectangle.width();
     double height = rectangle.height();
-    if (width < 0.0 || height < 0.0)
+    if (width <= 0.0 || height <= 0.0)
         return path;