Changeset 196187 in webkit

Timestamp:

Feb 5, 2016 1:38:44 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Navigation bar in sidebars should always fit on a single line
​https://bugs.webkit.org/show_bug.cgi?id=153412
<rdar://problem/24318706>

Patch by Devin Rousso <Devin Rousso> on 2016-02-05
Reviewed by Timothy Hatcher.

This happened because the allowed maximum width of the sidebar was greater
than the minimum width derived from the currently visible sidebar.

• UserInterface/Base/Utilities.js:

(Number.constrain):
Added logic to reverse the values of min and max if max is less than min.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Utilities.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-02-05  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Navigation bar in sidebars should always fit on a single line
+        https://bugs.webkit.org/show_bug.cgi?id=153412
+        <rdar://problem/24318706>
+
+        Reviewed by Timothy Hatcher.
+
+        This happened because the allowed maximum width of the sidebar was greater
+        than the minimum width derived from the currently visible sidebar.
+
+        * UserInterface/Base/Utilities.js:
+        (Number.constrain):
+        Added logic to reverse the values of min and max if max is less than min.
+
 2016-02-05  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js

@@ -853 +853 @@
     value: function(num, min, max)
     {
+        if (max < min) {
+            let temp = max;
+            max = min;
+            min = temp;
+        }
         if (num < min)
             num = min;