Changeset 196308 in webkit

Timestamp:

Feb 9, 2016 4:38:02 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r196286.
​https://bugs.webkit.org/show_bug.cgi?id=154026

Looks like 5% iOS PLT regression (Requested by kling on
#webkit).

Reverted changeset:

"[iOS] Throw away some unlinked code when navigating to a new
page."
​https://bugs.webkit.org/show_bug.cgi?id=154014
​http://trac.webkit.org/changeset/196286

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/VM.cpp (modified) (1 diff)
• JavaScriptCore/runtime/VM.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/GCController.cpp (modified) (1 diff)
• WebCore/bindings/js/GCController.h (modified) (1 diff)
• WebCore/loader/FrameLoader.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-02-09  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r196286.
+        https://bugs.webkit.org/show_bug.cgi?id=154026
+
+        Looks like 5% iOS PLT regression (Requested by kling on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Throw away some unlinked code when navigating to a new
+        page."
+        https://bugs.webkit.org/show_bug.cgi?id=154014
+        http://trac.webkit.org/changeset/196286
+
 2016-02-08  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -543 +543 @@
 }
 
-void VM::deleteAllCodeExceptCaches()
+void VM::deleteAllLinkedCode()
 {
     whenIdle([this]() {
         heap.deleteAllCodeBlocks();
-        heap.deleteAllUnlinkedCodeBlocks();
         heap.reportAbandonedObjectGraph();
     });

trunk/Source/JavaScriptCore/runtime/VM.h

@@ -575 +575 @@
 
     JS_EXPORT_PRIVATE void deleteAllCode();
-    JS_EXPORT_PRIVATE void deleteAllCodeExceptCaches();
+    JS_EXPORT_PRIVATE void deleteAllLinkedCode();
 
     void registerWatchpointForImpureProperty(const Identifier&, Watchpoint*);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-09  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r196286.
+        https://bugs.webkit.org/show_bug.cgi?id=154026
+
+        Looks like 5% iOS PLT regression (Requested by kling on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Throw away some unlinked code when navigating to a new
+        page."
+        https://bugs.webkit.org/show_bug.cgi?id=154014
+        http://trac.webkit.org/changeset/196286
+
 2016-02-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/bindings/js/GCController.cpp

@@ -123 +123 @@
 }
 
-void GCController::deleteAllCodeExceptCaches()
+void GCController::deleteAllLinkedCode()
 {
     JSLockHolder lock(JSDOMWindow::commonVM());
-    JSDOMWindow::commonVM().deleteAllCodeExceptCaches();
+    JSDOMWindow::commonVM().deleteAllLinkedCode();
 }
 

trunk/Source/WebCore/bindings/js/GCController.h

@@ -47 +47 @@
     WEBCORE_EXPORT void setJavaScriptGarbageCollectorTimerEnabled(bool);
     WEBCORE_EXPORT void deleteAllCode();
-    WEBCORE_EXPORT void deleteAllCodeExceptCaches();
+    WEBCORE_EXPORT void deleteAllLinkedCode();
 
 private:

trunk/Source/WebCore/loader/FrameLoader.cpp

@@ -1764 +1764 @@
 
 #if PLATFORM(IOS)
-        // For top-level navigations, have JSC throw away all code used by the current page.
-        // The immediate memory savings far outweigh the cost of recompiling in the case of a future backwards navigation.
-        GCController::singleton().deleteAllCodeExceptCaches();
+        // For top-level navigations, have JSC throw away linked code. The immediate memory savings far
+        // outweigh the cost of recompiling in the case of a future backwards navigation.
+        GCController::singleton().deleteAllLinkedCode();
 #endif
     }