Changeset 196369 in webkit

Timestamp:

Feb 10, 2016 10:13:24 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r196251.
​https://bugs.webkit.org/show_bug.cgi?id=154078

Large regression on Dromaeo needs explanation (Requested by
kling on #webkit).

Reverted changeset:

"Visiting a WeakBlock should report bytes visited, since we
reported them allocated."
​https://bugs.webkit.org/show_bug.cgi?id=153978
​http://trac.webkit.org/changeset/196251

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/SlotVisitor.h (modified) (1 diff)
• heap/WeakBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-02-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r196251.
+        https://bugs.webkit.org/show_bug.cgi?id=154078
+
+        Large regression on Dromaeo needs explanation (Requested by
+        kling on #webkit).
+
+        Reverted changeset:
+
+        "Visiting a WeakBlock should report bytes visited, since we
+        reported them allocated."
+        https://bugs.webkit.org/show_bug.cgi?id=153978
+        http://trac.webkit.org/changeset/196251
+
 2016-02-10  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/JavaScriptCore/heap/SlotVisitor.h

@@ -106 +106 @@
     
     void reportExtraMemoryVisited(size_t);
-    void reportMemoryVisited(size_t bytes) { m_bytesVisited += bytes; }
     
     void addWeakReferenceHarvester(WeakReferenceHarvester*);

trunk/Source/JavaScriptCore/heap/WeakBlock.cpp

@@ -110 +110 @@
     SlotVisitor& visitor = heapRootVisitor.visitor();
 
-    visitor.reportMemoryVisited(WeakBlock::blockSize);
-
     for (size_t i = 0; i < weakImplCount(); ++i) {
         WeakImpl* weakImpl = &weakImpls()[i];