Changeset 196575 in webkit

Timestamp:

Feb 15, 2016 2:30:36 AM (8 years ago)

Author:

Antti Koivisto

Message:

Add test for class change style invalidation optimization
​https://bugs.webkit.org/show_bug.cgi?id=154226

Reviewed by Myles Maxfield.

Test for ​https://trac.webkit.org/r196383

Source/WebCore:

Add internals.styleChangeType function.

Test: fast/css/style-invalidation-class-change-descendants.html

• testing/Internals.cpp:

(WebCore::Internals::nodeNeedsStyleRecalc):
(WebCore::asString):
(WebCore::Internals::styleChangeType):
(WebCore::Internals::description):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
• fast/css/style-invalidation-class-change-descendants.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt (added)
• LayoutTests/fast/css/style-invalidation-class-change-descendants.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (1 diff)
• Source/WebCore/testing/Internals.h (modified) (1 diff)
• Source/WebCore/testing/Internals.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-02-14  Antti Koivisto  <antti@apple.com>
+
+        Add test for class change style invalidation optimization
+        https://bugs.webkit.org/show_bug.cgi?id=154226
+
+        Reviewed by Myles Maxfield.
+
+        Test for https://trac.webkit.org/r196383
+
+        * fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
+        * fast/css/style-invalidation-class-change-descendants.html: Added.
+
 2016-02-15  Hunseop Jeong  <hs85.jeong@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-14  Antti Koivisto  <antti@apple.com>
+
+        Add test for class change style invalidation optimization
+        https://bugs.webkit.org/show_bug.cgi?id=154226
+
+        Reviewed by Myles Maxfield.
+
+        Test for https://trac.webkit.org/r196383
+
+        Add internals.styleChangeType function.
+
+        Test: fast/css/style-invalidation-class-change-descendants.html
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::nodeNeedsStyleRecalc):
+        (WebCore::asString):
+        (WebCore::Internals::styleChangeType):
+        (WebCore::Internals::description):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
 2016-02-14  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -465 +465 @@
 }
 
+static String styleChangeTypeToString(StyleChangeType type)
+{
+    switch (type) {
+    case NoStyleChange:
+        return "NoStyleChange";
+    case InlineStyleChange:
+        return "InlineStyleChange";
+    case FullStyleChange:
+        return "FullStyleChange";
+    case SyntheticStyleChange:
+        return "SyntheticStyleChange";
+    case ReconstructRenderTree:
+        return "ReconstructRenderTree";
+    }
+    ASSERT_NOT_REACHED();
+    return "";
+}
+
+String Internals::styleChangeType(Node* node, ExceptionCode& exception)
+{
+    if (!node) {
+        exception = INVALID_ACCESS_ERR;
+        return { };
+    }
+
+    return styleChangeTypeToString(node->styleChangeType());
+}
+
 String Internals::description(Deprecated::ScriptValue value)
 {

trunk/Source/WebCore/testing/Internals.h

@@ -90 +90 @@
     String address(Node*);
     bool nodeNeedsStyleRecalc(Node*, ExceptionCode&);
+    String styleChangeType(Node*, ExceptionCode&);
     String description(Deprecated::ScriptValue);
 

trunk/Source/WebCore/testing/Internals.idl

@@ -69 +69 @@
     DOMString address(Node node);
     [RaisesException] boolean nodeNeedsStyleRecalc(Node node);
+    [RaisesException] DOMString styleChangeType(Node node);
     DOMString description(any value);