Changeset 196602 in webkit

Timestamp:

Feb 15, 2016 2:36:00 PM (8 years ago)

Author:

jer.noble@apple.com

Message:

Null-deref crash in DefaultAudioDestinationNode::suspend()
​https://bugs.webkit.org/show_bug.cgi?id=154248

Reviewed by Alex Christensen.

Null-check scriptExecutionContext() before deref.

• Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/DefaultAudioDestinationNode.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-15  Jer Noble  <jer.noble@apple.com>
+
+        Null-deref crash in DefaultAudioDestinationNode::suspend()
+        https://bugs.webkit.org/show_bug.cgi?id=154248
+
+        Reviewed by Alex Christensen.
+
+        Null-check scriptExecutionContext() before deref.
+
+        * Modules/webaudio/DefaultAudioDestinationNode.cpp:
+        (WebCore::DefaultAudioDestinationNode::resume):
+        (WebCore::DefaultAudioDestinationNode::suspend):
+        (WebCore::DefaultAudioDestinationNode::close):
+
 2016-02-15  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp

@@ -112 +112 @@
     if (isInitialized())
         m_destination->start();
-    context()->scriptExecutionContext()->postTask(function);
+    if (auto scriptExecutionContext = context()->scriptExecutionContext())
+        scriptExecutionContext->postTask(function);
 }
 
@@ -120 +121 @@
     if (isInitialized())
         m_destination->stop();
-    context()->scriptExecutionContext()->postTask(function);
+    if (auto scriptExecutionContext = context()->scriptExecutionContext())
+        scriptExecutionContext->postTask(function);
 }
 
@@ -127 +129 @@
     ASSERT(isInitialized());
     uninitialize();
-    context()->scriptExecutionContext()->postTask(function);
+    if (auto scriptExecutionContext = context()->scriptExecutionContext())
+        scriptExecutionContext->postTask(function);
 }