Changeset 196733 in webkit

Timestamp:

Feb 17, 2016 5:05:56 PM (8 years ago)

Author:

BJ Burg

Message:

Remove a wrong cast in RemoteInspector::receivedSetupMessage
​https://bugs.webkit.org/show_bug.cgi?id=154361
<rdar://problem/24709281>

Reviewed by Joseph Pecoraro.

• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::receivedSetupMessage):
Not only is this cast unnecessary (the constructor accepts the base class),
but it is wrong since the target could be an automation target. Remove it.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/remote/RemoteInspector.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-02-17  Brian Burg  <bburg@apple.com>
+
+        Remove a wrong cast in RemoteInspector::receivedSetupMessage
+        https://bugs.webkit.org/show_bug.cgi?id=154361
+        <rdar://problem/24709281>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/remote/RemoteInspector.mm:
+        (Inspector::RemoteInspector::receivedSetupMessage):
+        Not only is this cast unnecessary (the constructor accepts the base class),
+        but it is wrong since the target could be an automation target. Remove it.
+
 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/inspector/remote/RemoteInspector.mm

@@ -619 +619 @@
     // Attempt to create a connection. This may fail if the page already has an inspector or if it disallows inspection.
     RemoteControllableTarget* target = findResult->value;
-    RefPtr<RemoteConnectionToTarget> connectionToTarget = adoptRef(new RemoteConnectionToTarget(downcast<RemoteInspectionTarget>(target), connectionIdentifier, sender));
+    RefPtr<RemoteConnectionToTarget> connectionToTarget = adoptRef(new RemoteConnectionToTarget(target, connectionIdentifier, sender));
 
     if (is<RemoteInspectionTarget>(target)) {