Changeset 197024 in webkit
- Timestamp:
- Feb 24, 2016 2:41:11 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r197022 r197024 1 2016-02-24 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949 4 https://bugs.webkit.org/show_bug.cgi?id=153747 5 6 Reviewed by Michael Catanzaro. 7 8 Add test to check that moving to line boundary clears the 9 selection even if the cursor is already at the boundary. 10 11 * editing/selection/move-to-line-boundary-clear-selection-expected.txt: Added. 12 * editing/selection/move-to-line-boundary-clear-selection.html: Added. 13 1 14 2016-02-23 Sergio Villar Senin <svillar@igalia.com> 2 15 -
trunk/Source/WebCore/ChangeLog
r197023 r197024 1 2016-02-24 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949 4 https://bugs.webkit.org/show_bug.cgi?id=153747 5 6 Reviewed by Michael Catanzaro. 7 8 Do not return early when reaching a boundary if there's a range 9 selection. In that case, the selection will be cleared and 10 accessibility will be notified. 11 12 Test: editing/selection/move-to-line-boundary-clear-selection.html 13 14 * editing/FrameSelection.cpp: 15 (WebCore::FrameSelection::modify): 16 1 17 2016-02-24 Alejandro G. Castro <alex@igalia.com> 2 18 -
trunk/Source/WebCore/editing/FrameSelection.cpp
r195949 r197024 1253 1253 willBeModified(alter, direction); 1254 1254 1255 bool shouldNotify = false;1255 bool reachedBoundary = false; 1256 1256 bool wasRange = m_selection.isRange(); 1257 1257 Position originalStartPosition = m_selection.start(); … … 1260 1260 case DirectionRight: 1261 1261 if (alter == AlterationMove) 1262 position = modifyMovingRight(granularity, & shouldNotify);1262 position = modifyMovingRight(granularity, &reachedBoundary); 1263 1263 else 1264 1264 position = modifyExtendingRight(granularity); … … 1268 1268 position = modifyExtendingForward(granularity); 1269 1269 else 1270 position = modifyMovingForward(granularity, & shouldNotify);1270 position = modifyMovingForward(granularity, &reachedBoundary); 1271 1271 break; 1272 1272 case DirectionLeft: 1273 1273 if (alter == AlterationMove) 1274 position = modifyMovingLeft(granularity, & shouldNotify);1274 position = modifyMovingLeft(granularity, &reachedBoundary); 1275 1275 else 1276 1276 position = modifyExtendingLeft(granularity); … … 1280 1280 position = modifyExtendingBackward(granularity); 1281 1281 else 1282 position = modifyMovingBackward(granularity, & shouldNotify);1283 break; 1284 } 1285 1286 if ( shouldNotify&& userTriggered == UserTriggered && m_frame && AXObjectCache::accessibilityEnabled()) {1282 position = modifyMovingBackward(granularity, &reachedBoundary); 1283 break; 1284 } 1285 1286 if (reachedBoundary && !isRange() && userTriggered == UserTriggered && m_frame && AXObjectCache::accessibilityEnabled()) { 1287 1287 notifyAccessibilityForSelectionChange({ AXTextStateChangeTypeSelectionBoundary, textSelectionWithDirectionAndGranularity(direction, granularity) }); 1288 1288 return true;
Note: See TracChangeset
for help on using the changeset viewer.