Changeset 197593 in webkit


Ignore:
Timestamp:
Mar 4, 2016 3:32:14 PM (8 years ago)
Author:
Simon Fraser
Message:

Use BoxExtent instead of EdgeSet in TileController
​https://bugs.webkit.org/show_bug.cgi?id=155040

Reviewed by Zalan Bujtas.

Remove EdgeSet, which was very similar to the existing BoxExtent, and use BoxExtent
in TileController.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/EdgeSet.h: Removed.

(WebCore::EdgeSet::EdgeSet): Deleted.
(WebCore::EdgeSet::top): Deleted.
(WebCore::EdgeSet::setTop): Deleted.
(WebCore::EdgeSet::right): Deleted.
(WebCore::EdgeSet::setRight): Deleted.
(WebCore::EdgeSet::bottom): Deleted.
(WebCore::EdgeSet::setBottom): Deleted.
(WebCore::EdgeSet::left): Deleted.
(WebCore::EdgeSet::setLeft): Deleted.
(WebCore::EdgeSet::operator==): Deleted.
(WebCore::EdgeSet::operator!=): Deleted.

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::setHasMargins):

  • platform/graphics/ca/TileController.h:
Location:
trunk/Source/WebCore
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r197592 r197593  
     12016-03-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Use BoxExtent instead of EdgeSet in TileController
     4        https://bugs.webkit.org/show_bug.cgi?id=155040
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Remove EdgeSet, which was very similar to the existing BoxExtent, and use BoxExtent
     9        in TileController.
     10
     11        * WebCore.xcodeproj/project.pbxproj:
     12        * platform/graphics/EdgeSet.h: Removed.
     13        (WebCore::EdgeSet::EdgeSet): Deleted.
     14        (WebCore::EdgeSet::top): Deleted.
     15        (WebCore::EdgeSet::setTop): Deleted.
     16        (WebCore::EdgeSet::right): Deleted.
     17        (WebCore::EdgeSet::setRight): Deleted.
     18        (WebCore::EdgeSet::bottom): Deleted.
     19        (WebCore::EdgeSet::setBottom): Deleted.
     20        (WebCore::EdgeSet::left): Deleted.
     21        (WebCore::EdgeSet::setLeft): Deleted.
     22        (WebCore::EdgeSet::operator==): Deleted.
     23        (WebCore::EdgeSet::operator!=): Deleted.
     24        * platform/graphics/ca/TileController.cpp:
     25        (WebCore::TileController::setHasMargins):
     26        * platform/graphics/ca/TileController.h:
     27
    1282016-03-04  Brent Fulgham  <bfulgham@apple.com>
    229

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r197592 r197593  
    461461                0F1774801378B772009DA76A /* ScrollAnimatorIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F17747E1378B771009DA76A /* ScrollAnimatorIOS.h */; };
    462462                0F1774811378B772009DA76A /* ScrollAnimatorIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0F17747F1378B772009DA76A /* ScrollAnimatorIOS.mm */; };
    463                 0F2884001C7CF7D500888E9A /* EdgeSet.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F2883FF1C7CF7D500888E9A /* EdgeSet.h */; settings = {ATTRIBUTES = (Private, ); }; };
    464463                0F36E7371BD1837A002DB891 /* LayoutPoint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F36E7361BD1837A002DB891 /* LayoutPoint.cpp */; };
    465464                0F36E7391BD184B9002DB891 /* LayoutSize.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F36E7381BD184B9002DB891 /* LayoutSize.cpp */; };
    … …  
    78527851                0F17747E1378B771009DA76A /* ScrollAnimatorIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScrollAnimatorIOS.h; sourceTree = "<group>"; };
    78537852                0F17747F1378B772009DA76A /* ScrollAnimatorIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollAnimatorIOS.mm; sourceTree = "<group>"; };
    7854                 0F2883FF1C7CF7D500888E9A /* EdgeSet.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EdgeSet.h; sourceTree = "<group>"; };
    78557853                0F36E7361BD1837A002DB891 /* LayoutPoint.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LayoutPoint.cpp; sourceTree = "<group>"; };
    78567854                0F36E7381BD184B9002DB891 /* LayoutSize.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LayoutSize.cpp; sourceTree = "<group>"; };
    … …  
    2186621864                                2D29ECC3192ECC8300984B78 /* DisplayRefreshMonitorManager.cpp */,
    2186721865                                2D29ECC4192ECC8300984B78 /* DisplayRefreshMonitorManager.h */,
    21868                                 0F2883FF1C7CF7D500888E9A /* EdgeSet.h */,
    2186921866                                6E67D2A81280E8BD008758F7 /* Extensions3D.h */,
    2187021867                                B275353A0B053814002CE64F /* FloatPoint.cpp */,
    … …  
    2528425281                                E1FE137B184D21BB00892F13 /* CryptoAlgorithmAES_KW.h in Headers */,
    2528525282                                E125F83A1824104800D84CD9 /* CryptoAlgorithmAesCbcParams.h in Headers */,
    25286                                 0F2884001C7CF7D500888E9A /* EdgeSet.h in Headers */,
    2528725283                                E19AC3F71824E5D100349426 /* CryptoAlgorithmAesKeyGenParams.h in Headers */,
    2528825284                                E157A8ED181851AC009F821D /* CryptoAlgorithmDescriptionBuilder.h in Headers */,

  • trunk/Source/WebCore/platform/graphics/ca/TileController.cpp

    r197580 r197593  
    614614void TileController::setHasMargins(bool marginTop, bool marginBottom, bool marginLeft, bool marginRight)
    615615{
    616     EdgeSet<bool> marginEdges(marginTop, marginRight, marginBottom, marginLeft);
     616    BoxExtent<bool> marginEdges(marginTop, marginRight, marginBottom, marginLeft);
    617617    if (marginEdges == m_marginEdges)
    618618        return;

  • trunk/Source/WebCore/platform/graphics/ca/TileController.h

    r197563 r197593  
    2727#define TileController_h
    2828
    29 #include "EdgeSet.h"
    3029#include "FloatRect.h"
    3130#include "IntRect.h"
     31#include "LengthBox.h"
    3232#include "PlatformCALayer.h"
    3333#include "PlatformCALayerClient.h"
    … …  
    214214    Scrollability m_scrollability { HorizontallyScrollable | VerticallyScrollable };
    215215   
    216     EdgeSet<bool> m_marginEdges;
     216    BoxExtent<bool> m_marginEdges;
    217217   
    218218    bool m_isInWindow { false };
Note: See TracChangeset for help on using the changeset viewer.