Changeset 19797 in webkit
- Timestamp:
- Feb 22, 2007 11:57:49 AM (17 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r19786 r19797 1 2007-02-21 Antti Koivisto <antti@apple.com> 2 3 Reviewed by Darin. 4 5 - tests for http://bugs.webkit.org/show_bug.cgi?id=11447 6 REGRESSION(NativeListBox): List not scrolled to preselected option 7 <rdar://problem/4957463> 8 9 * fast/forms/select-initial-position-expected.checksum: Added. 10 * fast/forms/select-initial-position-expected.png: Added. 11 * fast/forms/select-initial-position-expected.txt: Added. 12 * fast/forms/select-initial-position.html: Added. 13 1 14 2007-02-21 Geoffrey Garen <ggaren@apple.com> 2 15 -
trunk/WebCore/ChangeLog
r19796 r19797 1 2007-02-22 Antti Koivisto <antti@apple.com> 2 3 Reviewed by Darin. 4 5 - fix http://bugs.webkit.org/show_bug.cgi?id=11447 6 REGRESSION(NativeListBox): List not scrolled to preselected option 7 <rdar://problem/4957463> 8 9 Initiate scroll when selected <option> is added to <select>. 10 11 * html/HTMLOptionElement.cpp: 12 (WebCore::HTMLOptionElement::insertedIntoDocument): 13 * html/HTMLOptionElement.h: 14 * html/HTMLSelectElement.cpp: 15 (WebCore::HTMLSelectElement::notifyOptionSelected): 16 (WebCore::HTMLSelectElement::updateListBoxSelection): 17 (WebCore::HTMLSelectElement::scrollToSelection): 18 * html/HTMLSelectElement.h: 19 1 20 2007-02-22 Zack Rusin <zrusin@trolltech.com> 2 21 -
trunk/WebCore/html/HTMLOptionElement.cpp
r19383 r19797 246 246 } 247 247 248 void HTMLOptionElement::insertedIntoDocument() 249 { 250 HTMLSelectElement* select; 251 if (selected() && (select = getSelect())) 252 select->scrollToSelection(); 253 254 HTMLGenericFormElement::insertedIntoDocument(); 255 } 256 248 257 } // namespace -
trunk/WebCore/html/HTMLOptionElement.h
r18874 r19797 80 80 81 81 virtual bool disabled() const; 82 83 virtual void insertedIntoDocument(); 82 84 83 85 private: -
trunk/WebCore/html/HTMLSelectElement.cpp
r19707 r19797 563 563 deselectItems(selectedOption); 564 564 565 if (renderer() && !usesMenuList()) 566 static_cast<RenderListBox*>(renderer())->selectionChanged(); 565 scrollToSelection(); 567 566 568 567 m_lastOnChangeIndex = selectedOption->index(); … … 822 821 } 823 822 824 s tatic_cast<RenderListBox*>(renderer())->selectionChanged();823 scrollToSelection(); 825 824 } 826 825 … … 1009 1008 } 1010 1009 1010 void HTMLSelectElement::scrollToSelection() 1011 { 1012 if (renderer() && !usesMenuList()) 1013 static_cast<RenderListBox*>(renderer())->selectionChanged(); 1014 } 1015 1011 1016 } // namespace -
trunk/WebCore/html/HTMLSelectElement.h
r19520 r19797 135 135 int activeSelectionStartListIndex() const; 136 136 int activeSelectionEndListIndex() const; 137 138 void scrollToSelection(); 137 139 138 140 private:
Note: See TracChangeset
for help on using the changeset viewer.