Changeset 198915 in webkit

Timestamp:

Mar 31, 2016 2:03:52 PM (8 years ago)

Author:

timothy@apple.com

Message:

Web Automation: Add support for script timeouts to the evaluateJavaScriptFunction command

​https://bugs.webkit.org/show_bug.cgi?id=156052
rdar://problem/25457151

Address additional review comments.

• WebProcess/Automation/WebAutomationSessionProxy.js:

(AutomationSessionProxy.prototype.evaluateJavaScriptFunction): Add semicolons and remove
and clearTimeout that wasn't needed.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Automation/WebAutomationSessionProxy.js (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-03-31  Timothy Hatcher  <timothy@apple.com>
+
+        Web Automation: Add support for script timeouts to the evaluateJavaScriptFunction command
+
+        https://bugs.webkit.org/show_bug.cgi?id=156052
+        rdar://problem/25457151
+
+        Address additional review comments.
+
+        * WebProcess/Automation/WebAutomationSessionProxy.js:
+        (AutomationSessionProxy.prototype.evaluateJavaScriptFunction): Add semicolons and remove
+        and clearTimeout that wasn't needed.
+
 2016-03-31  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.js

@@ -51 +51 @@
         let timeoutIdentifier = 0;
 
-        let reportResult = (result) => { clearTimeout(timeoutIdentifier); resultCallback(frameID, callbackID, this._jsonStringify(result), false); }
-        let reportTimeoutError = () => { clearTimeout(timeoutIdentifier); resultCallback(frameID, callbackID, "JavaScriptTimeout", true); }
+        let reportResult = (result) => { clearTimeout(timeoutIdentifier); resultCallback(frameID, callbackID, this._jsonStringify(result), false); };
+        let reportTimeoutError = () => { resultCallback(frameID, callbackID, "JavaScriptTimeout", true); };
 
         if (expectsImplicitCallbackArgument) {