Changeset 198963 in webkit

Timestamp:

Apr 1, 2016 5:19:32 PM (8 years ago)

Author:

Simon Fraser

Message:

Backdrop Filter should repaint when changed via script
​https://bugs.webkit.org/show_bug.cgi?id=149319
rdar://problem/22749892

Reviewed by Tim Horton.

Source/WebCore:

When backdrop filters change, we need to trigger a recomposite, just as we do
for filters. It's ok to re-use ContextSensitivePropertyFilter because
adjustStyleDifference() does the right thing.

Test: css3/filters/backdrop/dynamic-backdrop-filter-change.html

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayerRepaint):

LayoutTests:

• css3/filters/backdrop/dynamic-backdrop-filter-change-expected.html: Added.
• css3/filters/backdrop/dynamic-backdrop-filter-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/filters/backdrop/dynamic-backdrop-filter-change-expected.html (added)
• LayoutTests/css3/filters/backdrop/dynamic-backdrop-filter-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-01  Simon Fraser  <simon.fraser@apple.com>
+
+        Backdrop Filter should repaint when changed via script
+        https://bugs.webkit.org/show_bug.cgi?id=149319
+        rdar://problem/22749892
+
+        Reviewed by Tim Horton.
+
+        * css3/filters/backdrop/dynamic-backdrop-filter-change-expected.html: Added.
+        * css3/filters/backdrop/dynamic-backdrop-filter-change.html: Added.
+
 2016-03-31  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-01  Simon Fraser  <simon.fraser@apple.com>
+
+        Backdrop Filter should repaint when changed via script
+        https://bugs.webkit.org/show_bug.cgi?id=149319
+        rdar://problem/22749892
+
+        Reviewed by Tim Horton.
+
+        When backdrop filters change, we need to trigger a recomposite, just as we do
+        for filters. It's ok to re-use ContextSensitivePropertyFilter because
+        adjustStyleDifference() does the right thing.
+
+        Test: css3/filters/backdrop/dynamic-backdrop-filter-change.html
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::changeRequiresLayerRepaint):
+
 2016-03-31  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -789 +789 @@
         // Don't return; keep looking for another change.
     }
+
+#if ENABLE(FILTERS_LEVEL_2)
+    if (rareNonInheritedData->m_backdropFilter != other.rareNonInheritedData->m_backdropFilter) {
+        changedContextSensitiveProperties |= ContextSensitivePropertyFilter;
+        // Don't return; keep looking for another change.
+    }
+#endif
 
     if (rareNonInheritedData->m_mask != other.rareNonInheritedData->m_mask