Changeset 199021 in webkit

Timestamp:

Apr 4, 2016 2:09:35 PM (8 years ago)

Author:

Brent Fulgham

Message:

REGRESSION(r198955): com.apple.WebKit.Networking.Development crashed in WebKit::NetworkLoad::setPendingDownloadID + 11
​https://bugs.webkit.org/show_bug.cgi?id=156177
<rdar://problem/25508037>

Reviewed by Alex Christensen.

We do not currently create a NetworkDataTask when we encounter a BLOB URL when building with
NETWORK_SESSION enabled. This causes us to crash when the download system attempts to work
with a BLOB URL.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::setPendingDownloadID): Add null check for m_task.
(WebKit::NetworkLoad::setPendingDownload): Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkLoad.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-04  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r198955): com.apple.WebKit.Networking.Development crashed in WebKit::NetworkLoad::setPendingDownloadID + 11
+        https://bugs.webkit.org/show_bug.cgi?id=156177
+        <rdar://problem/25508037>
+
+        Reviewed by Alex Christensen.
+
+        We do not currently create a NetworkDataTask when we encounter a BLOB URL when building with
+        NETWORK_SESSION enabled. This causes us to crash when the download system attempts to work
+        with a BLOB URL.
+
+        * NetworkProcess/NetworkLoad.cpp:
+        (WebKit::NetworkLoad::setPendingDownloadID): Add null check for m_task.
+        (WebKit::NetworkLoad::setPendingDownload): Ditto.
+
 2016-04-03  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp

@@ -184 +184 @@
 void NetworkLoad::setPendingDownloadID(DownloadID downloadID)
 {
+    if (!m_task)
+        return;
+
     m_task->setPendingDownloadID(downloadID);
 }
@@ -189 +192 @@
 void NetworkLoad::setPendingDownload(PendingDownload& pendingDownload)
 {
+    if (!m_task)
+        return;
+
     m_task->setPendingDownload(pendingDownload);
 }