Changeset 199077 in webkit

Timestamp:

Apr 5, 2016 3:32:03 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: Should not allow selecting no Timelines when editing in Timeline tab
​https://bugs.webkit.org/show_bug.cgi?id=156223
<rdar://problem/25552221>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype._startEditingInstruments):
Register EnabledDidChange event handler for all tree elements.

(WebInspector.TimelineOverview.prototype._stopEditingInstruments):
Unregister event handler for enabled tree elements. The rest are removed
from the tree outline once editing has completed.

(WebInspector.TimelineOverview.prototype._timelineTreeElementEnabledDidChange):
Enable "Done" button if at least one timeline is enabled.

• UserInterface/Views/TimelineTreeElement.js:

Dispatch a new event, EnabledDidChange, when the checkbox state changes.

(WebInspector.TimelineTreeElement.prototype._showCheckbox):
(WebInspector.TimelineTreeElement.prototype._clickHandler):
(WebInspector.TimelineTreeElement.prototype._dispatchEnabledDidChangeEvent):
(WebInspector.TimelineTreeElement):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineOverview.js (modified) (3 diffs)
• UserInterface/Views/TimelineTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-04-05  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Should not allow selecting no Timelines when editing in Timeline tab
+        https://bugs.webkit.org/show_bug.cgi?id=156223
+        <rdar://problem/25552221>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TimelineOverview.js:
+        (WebInspector.TimelineOverview):
+        (WebInspector.TimelineOverview.prototype._startEditingInstruments):
+        Register EnabledDidChange event handler for all tree elements.
+
+        (WebInspector.TimelineOverview.prototype._stopEditingInstruments):
+        Unregister event handler for enabled tree elements. The rest are removed
+        from the tree outline once editing has completed.
+
+        (WebInspector.TimelineOverview.prototype._timelineTreeElementEnabledDidChange):
+        Enable "Done" button if at least one timeline is enabled.
+
+        * UserInterface/Views/TimelineTreeElement.js:
+        Dispatch a new event, EnabledDidChange, when the checkbox state changes.
+
+        (WebInspector.TimelineTreeElement.prototype._showCheckbox):
+        (WebInspector.TimelineTreeElement.prototype._clickHandler):
+        (WebInspector.TimelineTreeElement.prototype._dispatchEnabledDidChangeEvent):
+        (WebInspector.TimelineTreeElement):
+
 2016-04-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

@@ -877 +877 @@
 
             treeElement.editing = true;
+            treeElement.addEventListener(WebInspector.TimelineTreeElement.Event.EnabledDidChange, this._timelineTreeElementEnabledDidChange, this);
         }
 
@@ -893 +894 @@
             if (treeElement.status.checked) {
                 treeElement.editing = false;
+                treeElement.removeEventListener(WebInspector.TimelineTreeElement.Event.EnabledDidChange, this._timelineTreeElementEnabledDidChange, this);
                 continue;
             }
@@ -944 +946 @@
         let bTimelineIndex = this._instrumentTypes.indexOf(bTimelineType);
         return aTimelineIndex - bTimelineIndex;
+    }
+
+    _timelineTreeElementEnabledDidChange(event)
+    {
+        let enabled = this._timelinesTreeOutline.children.some((treeElement) => {
+            let timelineType = treeElement.representedObject.type;
+            return this._canShowTimelineType(timelineType) && treeElement.status.checked;
+        });
+
+        this._editInstrumentsButton.enabled = enabled;
     }
 };

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTreeElement.js

@@ -88 +88 @@
 
         let button = new WebInspector.TreeElementStatusButton(checkboxElement);
+        checkboxElement.addEventListener("change", () => { this._dispatchEnabledDidChangeEvent(); });
+
         this.status = checkboxElement;
     }
@@ -105 +107 @@
 
         this.status.checked = !this.status.checked;
+        this._dispatchEnabledDidChangeEvent();
+    }
+
+    _dispatchEnabledDidChangeEvent()
+    {
+        this.dispatchEventToListeners(WebInspector.TimelineTreeElement.Event.EnabledDidChange);
     }
 };
+
+WebInspector.TimelineTreeElement.Event = {
+    EnabledDidChange: "timeline-tree-element-enabled-did-change"
+};