Changeset 199119 in webkit

Timestamp:

Apr 6, 2016 3:22:02 PM (8 years ago)

Author:

Simon Fraser

Message:

Avoid using an unengaged Optional<FloatRect> when positioning the tiled scrolling indicator
​https://bugs.webkit.org/show_bug.cgi?id=156313

Reviewed by Tim Horton.

Fixes an assertion seen when running the WebKit2.AutoLayoutIntegration API test.

• page/FrameView.cpp:

(WebCore::FrameView::setViewExposedRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Avoid using an unengaged Optional<FloatRect> when positioning the tiled scrolling indicator
+        https://bugs.webkit.org/show_bug.cgi?id=156313
+
+        Reviewed by Tim Horton.
+
+        Fixes an assertion seen when running the WebKit2.AutoLayoutIntegration API test.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setViewExposedRect):
+
 2016-04-06  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -4918 +4918 @@
     if (!frame().isMainFrame())
         return;
+
     if (TiledBacking* tiledBacking = this->tiledBacking()) {
         adjustTiledBackingCoverage();
-        tiledBacking->setTiledScrollingIndicatorPosition(m_viewExposedRect.value().location());
+        tiledBacking->setTiledScrollingIndicatorPosition(m_viewExposedRect ? m_viewExposedRect.value().location() : FloatPoint());
     }