Changeset 199142 in webkit

Timestamp:

Apr 6, 2016 7:07:26 PM (8 years ago)

Author:

Gyuyoung Kim

Message:

Remove duplicated parsePortFromStringPosition()
​https://bugs.webkit.org/show_bug.cgi?id=156289

Reviewed by Simon Fraser.

Same parsePortFromStringPosition() functions have been defined in both URLUtils.h and HTMLAnchorElement.cpp.
Remove duplicated one in HTMLAnchorElement.cpp.

No new tests, no behavior change.

• html/HTMLAnchorElement.cpp:

(WebCore::parsePortFromStringPosition): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLAnchorElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
+
+        Remove duplicated parsePortFromStringPosition()
+        https://bugs.webkit.org/show_bug.cgi?id=156289
+
+        Reviewed by Simon Fraser.
+
+        Same parsePortFromStringPosition() functions have been defined in both URLUtils.h and HTMLAnchorElement.cpp.
+        Remove duplicated one in HTMLAnchorElement.cpp.
+
+        No new tests, no behavior change.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::parsePortFromStringPosition): Deleted.
+
 2016-04-06  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/html/HTMLAnchorElement.cpp

@@ -47 +47 @@
 #include "SecurityPolicy.h"
 #include "Settings.h"
+#include "URLUtils.h"
 #include <wtf/text/StringBuilder.h>
 
@@ -75 +76 @@
 {
     clearRootEditableElementForSelectionOnMouseDown();
-}
-
-// This function does not allow leading spaces before the port number.
-static unsigned parsePortFromStringPosition(const String& value, unsigned portStart, unsigned& portEnd)
-{
-    portEnd = portStart;
-    while (isASCIIDigit(value[portEnd]))
-        ++portEnd;
-    return value.substring(portStart, portEnd - portStart).toUInt();
 }