Changeset 199565 in webkit

Timestamp:

Apr 14, 2016 4:04:26 PM (8 years ago)

Author:

BJ Burg

Message:

Web Automation: suppress automatic text correction in pages controlled by automation
​https://bugs.webkit.org/show_bug.cgi?id=156599
<rdar://problem/25712646>

Reviewed by Timothy Hatcher.

If the page is controlled by automation, then automatic text corrections will
cause unexpected behaviors by nondeterministically modifying text inserted by
a test. Just pretend these behaviors are disabled if controlled by automation.

• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm (modified) (4 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-14  Brian Burg  <bburg@apple.com>
+
+        Web Automation: suppress automatic text correction in pages controlled by automation
+        https://bugs.webkit.org/show_bug.cgi?id=156599
+        <rdar://problem/25712646>
+
+        Reviewed by Timothy Hatcher.
+
+        If the page is controlled by automation, then automatic text corrections will
+        cause unexpected behaviors by nondeterministically modifying text inserted by
+        a test. Just pretend these behaviors are disabled if controlled by automation.
+
+        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
+        (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
+        (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
+        (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
+        (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
+
 2016-04-14  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm

@@ -186 +186 @@
 bool WebEditorClient::isAutomaticQuoteSubstitutionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticQuoteSubstitutionEnabled;
 }
@@ -208 +211 @@
 bool WebEditorClient::isAutomaticDashSubstitutionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticDashSubstitutionEnabled;
 }
@@ -219 +225 @@
 bool WebEditorClient::isAutomaticTextReplacementEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticTextReplacementEnabled;
 }
@@ -230 +239 @@
 bool WebEditorClient::isAutomaticSpellingCorrectionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticSpellingCorrectionEnabled;
 }